ROWTYPE to get better query ?

Question

Hello,
I have two identical tables:
PHOTOS_TEMP AND IMAGES_TEST
(ID PK number ,
content blob,
filename varchar2 (200),
mimetype varchar2 (200),
filesize varchar2 (200),
res_id FK number,
watermarked varchar2 (1))I have CODE 1, I want to make it more effecient perhaps by using %ROWTYPE,
So, I tried CODE 2, but it did not work. It tells, "Too many values .... CONTENT must be declared ...."
Can you plesae tune Code 1 ??
h1. CODE 1 is working fine
DECLARE
type source_col is table of blob index by pls_integer ;
V_source source_col;
type id_col is table of number index by pls_integer ;
V_id id_col;
type char_col is table of IMAGES_TEST.FILENAME%TYPE index by pls_integer ;
V_filename char_col;
V_mimetype char_col;
begin
select content,filename,mimetype,id bulk collect into
V_source,v_filename,v_mimetype,v_id from photos_temp
where  temp = :P700_TEMP_IMAGE   for update  ;
for i in V_source.first .. V_source.last
loop
ORDSYS.ORDImage.process(V_source(i), 'fixedScale=800 500');
end loop;
forall i in V_source.first .. V_source.last
insert into IMAGES_test
(res_id ,CONTENT,filename,mimetype,filesize,watermarked)
values
(:P700_res_ID ,V_source(i),V_filename(i),V_mimetype(i),
dbms_lob.getlength(V_source(i)), 'Y');
COMMIT;
EXCEPTION
   WHEN OTHERS THEN
   RAISE;
END;h1. CODE 2 supposed to be more efficient, but not working ?
DECLARE
type new_row is table of IMAGES_TEST%rowtype index by pls_integer ;
v_row new_row;
begin
-- This may collect more than one row
select * bulk collect into
v_row from photos_temp
where  temp = :P700_TEMP_IMAGE   for update  ;
for i in v_row.id.first .. v_row.id.last
loop
ORDSYS.ORDImage.process(v_row.content(i), 'fixedScale=800 500');
end loop;
forall i in v_row.id.first .. v_row.id.last
insert into IMAGES_test
(res_id ,CONTENT,filename,mimetype,filesize,watermarked)
values
(:P700_res_ID ,v_row.contnet(i),v_row.filename(i),v_row.mimetype(i),
dbms_lob.getlength(v_row.content(i)), 'Y');
COMMIT;
EXCEPTION
   WHEN OTHERS THEN
   RAISE;
END;Best Regards,
Fateh
Edited by: Fateh on Nov 26, 2012 5:22 AM

Answer 1

hi,
In your CODE 1
select content,filename,mimetype,id bulk collect into
V_source,v_filename,v_mimetype,v_id from photos_temp
where  temp = :P700_TEMP_IMAGE   for update  ;
-- temp is not a collumn name nor a variable name
...So I think that does not work.
In code 2 you must use the index "( i)" on the table variable and not on the attribute. So:
v_row.contnet(i) --THIS IS WRONG!
v_row(i).contnet -- This is OK
Also:
v_row.id.first --THIS IS WRONG!
v_row.first --This is OK
Below is an working example:
insert into photos_temp (id ,filename) values ( 1,'peter');
insert into photos_temp (id ,filename) values ( 2,'Fateh');
commit;
DECLARE
type new_row is table of IMAGES_TEST%rowtype index by pls_integer ;
v_row new_row;
begin
  select * bulk collect into
   v_row from photos_temp
  --where  temp = :P700_TEMP_IMAGE  
  for update  ;
  --for i in v_row.id.first .. v_row.id.last
  for i in v_row.first .. v_row.last
  loop
  DBMS_OUTPUT.PUT_LINE('Id: ' || v_row(i).id || ' filename: ' || v_row(i).filename);
  end loop;
end;
Result:
Id: 1 filename: peter
Id: 2 filename: FatehAnd in your case for code 2 simplyfied:
DECLARE
type new_row is table of IMAGES_TEST%rowtype index by pls_integer ;
v_row new_row;
begin
  select * bulk collect into
   v_row from photos_temp
  --where  temp = :P700_TEMP_IMAGE  
  for update  ;
  --forall i in v_row.id.first .. v_row.id.last
  forall i in v_row.first .. v_row.last
  insert into IMAGES_test
  (id ,filename)
  values
  (v_row(i).id, v_row(i).filename);
end;
select
  id
  ,filename
from
  images_test;
Result:
ID FILENAME                                                                                                                                                                                              
1 peter                                                                                                                                                                                                   
2 Fateh                                                                                                                                                                                                    Whoever this works in:
Oracle Database 11g Enterprise Edition Release 11.2.0.1.0 - 64bit Production
PL/SQL Release 11.2.0.1.0 - Production
"CORE     11.2.0.1.0     Production"
TNS for 64-bit Windows: Version 11.2.0.1.0 - Production
NLSRTL Version 11.2.0.1.0 - Production
I think in oracle 9 you must use seperate table variables and not one table variable of a scalar type.
Regards,
Peter