Scripts:totaling of all items

Question

hi
i am facing a small problem
actually i used the below code  for summing of all items coming into g_dmshb  and g_mhngf.
but am not able to get get  overall total   am able to get only for last two items
can u suggest me whether the above code is correct or not
thank u
LOOP AT INTAB WHERE NAME = 'F150D-MHNGF' .
    IF SY-SUBRC = 0.
MOVE INTAB-VALUE TO G_MHNGF1.
  G_MHNGF1 = INTAB-VALUE .
  ENDIF.
ENDLOOP.
  G_TOT2 = G_DMSHB + G_MHNGF1.
  DATA G_TOT3(15).
  CLEAR OUTTAB.
READ TABLE OUTTAB WITH KEY NAME = 'G_TOT2'.
  IF SY-SUBRC = 0.
  WRITE G_TOT2 TO G_TOT3 CURRENCY 'GBP'.
    OUTTAB-VALUE = G_TOT3.
    CONDENSE OUTTAB-VALUE NO-GAPS.
    MODIFY OUTTAB INDEX 1 TRANSPORTING VALUE.
  ENDIF.

Answer 1

Hi,
There is an error in your logic see my comments at the side of your code.
LOOP AT INTAB WHERE NAME = 'MHND-DMSHB' .
if sy-subrc = 0.
replace ',' in intab-value with '' .
condense intab-value no-gaps.
Here the value of intab-value is moved to g_dmshb
move intab-value to g_dmshb.         
endif.
*g_tot1 = g_dmshb + intab-value.
g_tot2 = g_tot1 + intab-value.
reAD TABLE INTAB WITH KEY NAME = 'F150D-MHNGF'.
IF SY-SUBRC = 0.
MOVE INTAB-VALUE TO G_MHNGF1.
*G_MHNGF1 = INTAB-VALUE .
ENDIF.
Now here you add it to g_tot2
g_tot2 = g_dmshb + g_mhngf1.
endloop.
In accumulating a value the logic shoud be like
Loop
   a = a + b.
endloop.
So your code should look something like this
LOOP AT INTAB WHERE NAME = 'MHND-DMSHB' .
if sy-subrc = 0.
replace ',' in intab-value with '' .
condense intab-value no-gaps.
move intab-value to g_dmshb.
Here you add g_dmshb to g_tot2
add g_dmshb to g_tot2.
endif.
reAD TABLE INTAB WITH KEY NAME = 'F150D-MHNGF'.
IF SY-SUBRC = 0.
MOVE INTAB-VALUE TO G_MHNGF1.
ENDIF.
Here you add g_mhngf1 to g_tot2 so you have the sum of
both for entries with name = MHND-DMSHB and F150D-MHNGF
g_tot2 = g_tot2 + g_mhngf1. "<- should be like this
endloop.
If you want an optimized code try this one below.
LOOP AT INTAB WHERE NAME = 'MHND-DMSHB' .
IF sy-subrc = 0.
  REPLACE ',' IN intab-value WITH '' .
  CONDENSE intab-value no-gaps.
  MOVE intab-value TO g_dmshb.
ENDIF.
READ TABLE INTAB WITH KEY NAME = 'F150D-MHNGF'.
IF SY-SUBRC = 0.
  MOVE intab-value TO g_mhngf1.
ENDIF.
Here you add g_mhngf1 to g_tot2 so you have the sum of
both for entries with name = MHND-DMSHB and F150D-MHNGF
code should be like this:
g_tot2 = g_tot2 + g_dmshb + g_mhngf1.
ENDLOOP.