[SOLVED] fatal: repository '' does not exist

Question

Ive written a nice little Python library for ADB and Fastboot and figured I would use the opportunity to create my first AUR package, however, Im having some (hopefully) minor issues.
# Maintainer: Edvard Holst <edvard.holst at gmail>
pkgname=python2-pyand-git
pkgver=0.9.1.2
pkgrel=3
pkgdesc="A python wrapper library for ADB and Fastboot"
arch=('any')
url="https://github.com/Zyg0te/pyand"
license=('MIT')
depends=('python2' 'python-setuptools')
makedepends=('git')
source=('git+https://github.com/Zyg0te/pyand.git')
md5sums=('SKIP')
package() {
msg "Connecting to github server...."
if [[ -d $_gitname ]] ; then
( cd "$_gitname" && git pull origin )
msg "The local files are updated."
else
git clone "$_gitroot" --depth=1
fi
msg "GIT checkout done or server timeout"
cd "$_gitname/../../"
sudo easy_install-2.7 pyand
mkdir -p "$pkgdir/usr/share/licenses/$pkgname/"
cd "src/$_gitname/"
cp LICENSE "$pkgdir/usr/share/licenses/$pkgname/LICENSE"
With this, I get the following error when installing..
==> Building and installing package
==> Making package: python2-pyand-git 0.9.1.2-3 (Wed Apr 2 14:34:27 CEST 2014)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving sources...
-> Cloning pyand git repo...
Cloning into bare repository '/tmp/yaourt-tmp-myuser/aur-python2-pyand-git/pyand'...
remote: Reusing existing pack: 96, done.
remote: Counting objects: 46, done.
remote: Compressing objects: 100% (46/46), done.
remote: Total 142 (delta 22), reused 0 (delta 0)
Receiving objects: 100% (142/142), 28.61 KiB | 0 bytes/s, done.
Resolving deltas: 100% (65/65), done.
Checking connectivity... done.
==> Validating source files with md5sums...
pyand ... Skipped
==> Extracting sources...
-> Creating working copy of pyand git repo...
Cloning into 'pyand'...
done.
==> Entering fakeroot environment...
==> Starting package()...
==> Connecting to github server....
fatal: repository '' does not exist
==> ERROR: A failure occurred in package().
Aborting...
==> ERROR: Makepkg was unable to build python2-pyand-git.
Any ideas? And of course, any other feedback, suggestions, etc, is most welcome.
Last edited by Zygote (2014-04-02 15:35:19)

Answer 1

Further improvements can still be made. For example, you should still double quote all instances of $pkgdir and $srcdir.
cd $srcdir/$pkgname/../
Is completely redundant -- you always start in $srcdir, and that is a really odd way of getting to it even if you didn't.
You should write a pkgver function to automatically update the pkgver value each time you run makepkg (explanation is in the wiki link I posted a few posts ago)
I'll see if your packages 'builds' fine in a clean chroot when I get home. In the meantime, you could check your package+PKGBUILD with namcap to see if there are any other improvements you can make.
The first thing I found was your pkgver doesn't work
==> Starting pkgver()...
fatal: No names found, cannot describe anything.
The repository doesn't have any tags, so git describe isn't very useful here. You would be better off using the final git example on the wiki page.
The next problem I found, is that you haven't included the package that provides easy_install-2.7 in the makedepends array. You have, instead, declared the wrong package in the depends array. Note that packages with "python-" at the start of their name are actually python3 packages, whereas your package needs python2.
The next thing I noticed is that you've included pacman as a dependency. You don't need to do that, you can assume that anyone installing the package has pacman installed, this is the Arch User Repository, after all.
Finally, the completed package doesn't have any binary files in it, so nothing is compiled for a specific architecture. In this case, you can drop 'i686' and 'x86_64' from the arch array, and replace them with 'any'.
A further point of interest, is that, what I assume to be the main python file, ADB.py, has a shebang calling /usr/bin/python. This may not be a problem if it isn't meant to be called directly, but will cause problems if it is, and expects to get python 2.x. On ARch, /usr/bin/python is a symbolic link to /usr/bin/python3. Ideally, this shebang should be replaced with '#!/usr/bin/python2', or even better '#!/usr/bin/env python2'. This should be done upstream, but can be done in the PKGBUILD, in a prepare function, using sed.
If the script can be called with either python2 or python3, then the shebang doesn't need to change, and actually complies with PEP394.
Last edited by WorMzy (2014-04-02 20:25:27)