SQL 2012 not recognizing modification of scalar function

Question

I have two scalar functions which are both very similar. Both required three variables. Then I realized that I needed another variable in both functions so I added it to both.  I then modified the call to each function (e.g. select dbo.function(var1,
var2, var3, var4)), but within Management Studio editor, only the change in the first function is recognized. Below is the function that is not recognized and the call to it.  The error is 'insufficient number of arguments'.  Its as if Management
Studio doesn't realize I made the change.
ALTER FUNCTION [dbo].[InvoicePaidLateInFull](@Invoice bigint, @DueDate datetime, @Total decimal(14, 4), @EndDate datetime)
RETURNS bit
AS
BEGIN
DECLARE @PaidLate bit, @Paydate datetime, @Amount decimal(14, 4)
declare @Check int, @CurrentStatus bigint
declare @AmtTol decimal(14,4), @CID bigint
Set @PaidLate = 0
Set @CurrentStatus = (Select top 1 StatusID from RebateData Where InvoiceNo = @Invoice order by ID)
if @CurrentStatus <> 1
Begin
Goto NotDueYet
End
Set @CID = (Select top 1 CID from RebateData Where InvoiceNo = @Invoice order by ID)
Set @AmtTol = (Select AmountTolerance from MasterCustomerProgramContracts where ID = @CID)
If datediff(dd, @DueDate, @EndDate) < 0
Begin
GoTo NotDueYet
End
Set @Check = (Select count(*) from Payments Where InvoiceNo = @Invoice)
if @Check = 0
Begin
--No payments have been received at all. Consider as 'Unpaid'
GoTo NotDueYet
End
Set @Amount = isnull((Select round(sum(Amount) , 2)
from Payments
where invoiceno = @Invoice
and PayDate <= @DueDate
Group by InvoiceNo), 0)
Set @Amount = -(@Amount)
If @Amount between (@Total - (@Total * @AmtTol)) and (@Total + (@Total * @AmtTol))
Begin
Set @PaidLate = 0
End
If @Amount < (@Total - (@Total * @AmtTol))
Begin
Set @PaidLate = 1
End
NotDueYet:
RETURN @PaidLate
END
The Call:
Set @PL = (Select dbo.InvoicePaidLateInFull(@Inv, @DueDate, @Total, @EndDate))
Seems like I read the other day of a script that can be run to 'update' SQL, but I can't remember it now.
Thanks.
Ross

Answer 1

Leaving the Intellisense issue, permit me to point out that incorrectly used, this function can be a performance killer. An occasional call - no problem. But if you do something like:
SELECT ..., dbo.InvoicePaidLateInFull(invoice_id, due_date) AS PaidLade
FROM   MillionRowTable
This is a performance disaster. SQL Server cannot optimize the function, so you will have a cursor in disguise.
Overall, you should be very restrictive with scalar functions that perfoms data access.
Erland Sommarskog, SQL Server MVP, [email protected]