SQL Server Service Broker Updating Stored procedure

Question

how can you update the service broker stored procedure. when i update the stored procedure the changes dont come into affect. i have tried to alter the queue, waited for all jobs to finish, but some how still the old stored procedure is running. is there any
way i can force changes to the stored procedure.
i have tried sql profiler tracing but that didnt show any changes.
I cannot alter the service broker stored procedure, when I update the stored procedure it does not show any error and successfully gets updated but the changes does not come into affect.
Is it because I need to stop the queue of the service broker on both databases before the changes could come into affect?
Note: the service broker stored procedures produce and read xmls.

Answer 1

Presumably, this is because the procedure is executing when you alter the procedure. And if the procedure never exits, the old code will keep on running. One way to address this is to have the procedure to return if a new message has not been picked up in,
say, 1000 milliseconds.
Here is a repro to shows what I'm talking about.
------------------------------- Service Broker Objects ------------------------------------------
CREATE MESSAGE TYPE OrderRequest VALIDATION = NONE
CREATE MESSAGE TYPE OrderResponse VALIDATION = NONE
go
CREATE CONTRACT OrderContract
   (OrderRequest SENT BY INITIATOR,
    OrderResponse SENT BY TARGET)
go
CREATE QUEUE OrderRequests WITH STATUS = OFF
CREATE QUEUE OrderResponses WITH STATUS = ON
go
CREATE SERVICE OrderRequests ON QUEUE OrderRequests (OrderContract)
CREATE SERVICE OrderResponses ON QUEUE OrderResponses (OrderContract)
go
-- Procedure to send a message and receive a response.
CREATE PROCEDURE send_and_get_answer AS
DECLARE @handle uniqueidentifier,
         @binary varbinary(MAX)
      SELECT @binary = CAST (N'Kilroy was here' AS varbinary(MAX))
      BEGIN DIALOG CONVERSATION @handle
      FROM  SERVICE OrderResponses
      TO    SERVICE 'OrderRequests'
      ON    CONTRACT OrderContract
      WITH ENCRYPTION = OFF
      ;SEND ON CONVERSATION @handle
      MESSAGE TYPE OrderRequest (@binary)
   WAITFOR (RECEIVE TOP (1)
                     @handle = conversation_handle,
                     @binary = message_body
            FROM    OrderResponses)
   SELECT cast(@binary AS nvarchar(MAX)) AS response
   END CONVERSATION @handle
go
-- Procedure to process a message
CREATE PROCEDURE ProcessOrders AS
SET NOCOUNT, XACT_ABORT ON
DECLARE @DialogHandle  uniqueidentifier,
        @MessageType   sysname,
        @binarydata    varbinary(MAX)
-- Get next message of the queue.
WAITFOR (
   RECEIVE TOP (1) @DialogHandle = conversation_handle,
                     @MessageType  = message_type_name,
                     @binarydata   = message_body
   FROM    OrderRequests
SELECT @binarydata = CAST( reverse( CAST( @binarydata AS nvarchar(MAX) )) AS varbinary(MAX))
; SEND ON CONVERSATION @DialogHandle
MESSAGE TYPE OrderResponse (@binarydata)
END CONVERSATION @DialogHandle
go       
-- Make this an activaton procedure.
ALTER QUEUE OrderRequests WITH
      STATUS = ON,
      ACTIVATION (STATUS = ON,
                  PROCEDURE_NAME = ProcessOrders,
                  MAX_QUEUE_READERS = 1,
                  EXECUTE AS OWNER)
go
-------------------------------- Send a message  -------------------------------------------
EXEC send_and_get_answer
go
------------------------ Change the procedure --------------------------------
ALTER PROCEDURE ProcessOrders AS
SET NOCOUNT, XACT_ABORT ON
DECLARE @DialogHandle  uniqueidentifier,
        @MessageType   sysname,
        @binarydata    varbinary(MAX)
-- Get next message of the queue.
WAITFOR (
   RECEIVE TOP (1) @DialogHandle = conversation_handle,
                     @MessageType  = message_type_name,
                     @binarydata   = message_body
   FROM    OrderRequests
SELECT @binarydata = CAST( upper( CAST( @binarydata AS nvarchar(MAX) )) AS varbinary(MAX))
; SEND ON CONVERSATION @DialogHandle
MESSAGE TYPE OrderResponse (@binarydata)
END CONVERSATION @DialogHandle
go
-------------------------------- Send new message -------------------------------------------
EXEC send_and_get_answer    -- Still produces a message in reverse.
EXEC send_and_get_answer    -- Now we get the expected result.
go
DROP SERVICE OrderRequests
DROP SERVICE OrderResponses
DROP QUEUE OrderRequests
DROP QUEUE OrderResponses
DROP PROCEDURE ProcessOrders
DROP PROCEDURE send_and_get_answer
DROP CONTRACT OrderContract
DROP MESSAGE TYPE OrderRequest
DROP MESSAGE TYPE OrderResponse
go
Erland Sommarskog, SQL Server MVP, [email protected]