SQL Statement error - Kindly help!

Question

Been scratchin my head but still can't figure why it's failing ..Trying to populate the space usage for the relevant tablespaces: Get the below error. Kindly advice?
column free_space_mb format 9999999.999
column allocated_mb format 9999999.999
column used_mb format 9999999.999
column tablespace format a12
column filename format a20
select ts.name tablespace, trim(substr(df.name, 1,100)) filename,
df.bytes/1024/1024 allocated_mb,
((df.bytes/1024/1024) - nvl(sum(dfs.bytes)/1024/1024,0)) used_mb,
nvl(sum(dfs.bytes)/1024/1024,0) free_space_mb
from v$datafile df left outer join dba_free_space dfs
on df.file# = dfs.file_id join v$tablespace ts
on df.ts# = ts.ts#
on df.name# = ts.name#
and ts.name='DATA_TS'
or ts.name='INDEX_TS'
or ts.name='LOB_TS'
group by ts.name, df.name, dfs.file_id, df.file#, df.bytes
order by filename;
ERROR at line 8:
ORA-00933: SQL command not properly ended

Answer 1

Hi,
user568296 wrote:
select ts.name tablespace, trim(substr(df.name, 1,100)) filename,
df.bytes/1024/1024 allocated_mb,
((df.bytes/1024/1024) - nvl(sum(dfs.bytes)/1024/1024,0)) used_mb,
nvl(sum(dfs.bytes)/1024/1024,0) free_space_mb
from v$datafile df left outer join dba_free_space dfs
on df.file# = dfs.file_id join v$tablespace ts
on df.ts# = ts.ts#
on df.name# = ts.name#
and ts.name='DATA_TS'
or ts.name='INDEX_TS'
or ts.name='LOB_TS'
group by ts.name, df.name, dfs.file_id, df.file#, df.bytes
order by filename;
ERROR at line 8:
ORA-00933: SQL command not properly endedOn line 8 there is a 2nd ON clause for the same join. "AND" in place of "ON" would make syntaic sense, but filenames in v$datafile are usually superstrings of tablespace names in v$ablespace. That is, if ts.name (no # at the end) is 'DATA_TS', then df.name might be 'D:\ORACLE\ORADATA\DEVELOPMENT\DATA_TS01.DBF'.
I don't think you need that condition at all. Try:
select    ts.name                    tablespace,
       trim (substr (df.name, 1, 100))      filename,
       df.bytes/1024/1024                    allocated_mb,
       ( ( df.bytes / 1024 / 1024)
       - nvl ( sum (dfs.bytes) / 1024 / 1024
              , 0
       )                         used_mb,
       nvl ( sum (dfs.bytes) / 1024 / 1024
           , 0
           )                         free_space_mb
from                     v$datafile          df
left outer join      dba_free_space          dfs     on     df.file#     = dfs.file_id
join                   v$tablespace          ts     on     df.ts#          = ts.ts#
--                                   AND     df.name          = ts.name     -- AND, not ON
                                   and     ts.name          IN ( 'DATA_TS'
                                                     , 'INDEX_TS'
                                                     , 'LOB_TS'
group by  ts.name,
             df.name,
       dfs.file_id,
       df.file#,
       df.bytes
order by  filename;It's a bad idea to mix AND and OR at the same level in the same query. In this case, you can use the IN operator to avoid the need for OR. In other situations, use parentheses to isolate the ANDs from the ORs.