Stored Procedure to delete a number of tables with a common name attribute

Question

Hi All,
This is my first post so I hope I have posted to the required level with sufficient information. This is my first stored procedure (SP) and is for Oracle 10.
I am trying to write a script to delete 11 tables and some rows from another 3 tables, all of which are named with a number that I would like to input at the point of creation of the SP. Below is the script I have written and edited. My original has been lost by crashing servers!
When I run the script it gives me the following output:
"Warning: execution complete with warning
procedure ScenarioDelete compiled"
The SP hasn't deleted any of the tables and I'm not sure if it's because my script is poor or because of something else. Any help is greatly appreciated!!
-- table delete SP
-- Run begin ScenarioDelete ('x'); with x as the ScenarioId
create or replace procedure ScenarioDelete (ScenarioNo IN varchar2);
countstable := 'C_' || ScenarioNo;
changetable := 'CG_' || ScenarioNo;
countsinfotable := 'CI_' || ScenarioNo;
datatable1 := 'D_0_' || ScenarioNo;
datatable2 := 'D_1_' || ScenarioNo;
datatable3 := 'D_2_' || ScenarioNo;
hietable1 := 'HI_0_' || ScenarioNo;
hietable2 := 'HI_1_' || ScenarioNo;
hietable3 := 'HI_2_' || ScenarioNo;
hielinktable1 := 'HL_1_' || ScenarioNo;
hielinktable2 := 'HL_2_' || ScenarioNo;
AS
execute immediate 'drop table ' || countstable;
execute immediate 'drop table ' || changetable;
execute immediate 'drop table ' || countsinfotable;
execute immediate 'drop table ' || datatable1;
execute immediate 'drop table ' || datatable2;
execute immediate 'drop table ' || datatable3;
execute immediate 'drop table ' || hietable1;
execute immediate 'drop table ' || hietable2;
execute immediate 'drop table ' || hietable3;
execute immediate 'drop table ' || hielinktable1;
execute immediate 'drop table ' || hielinktable2;
execute immediate 'delete from USERACESS where SCENARIOID = ' || ScenarioNo;
execute immediate 'delete from SCENARIO where SCENARIOID = ' || ScenarioNo;
execute immediate 'delete from SCENARIOINFO where SCENARIOID = ' || ScenarioNo;
-- or --
execute immediate 'delete from USERACESS where SCENARIOID = '' || ScenarioNo || ''';
execute immediate 'delete from SCENARIO where SCENARIOID = '' || ScenarioNo || ''';
execute immediate 'delete from SCENARIOINFO where SCENARIOID = '' || ScenarioNo || ''';
END;

Answer 1

Hi,
Welcome to the forum!
When you compile a stored procedure, you get only the vaguest of error messages by default.
Always say SHOW ERRORS immediately after compiling, to get more detailed error messages. (And, of course, post the complete error message, including line number, when you need help.)
Remember to specify a datatype (and, in the case of VARCHAR2 variables, a maximum length) for all local variables you declare:
create or replace procedure ScenarioDelete (ScenarioNo IN varchar2)     -- no semicolon here
AS  -- AS or IS (it doesn't matter which) required here
    countstable  VARCHAR2 (50) := 'C_'  || ScenarioNo;
    changetable  VARCHAR2 (50) := 'CG_' || ScenarioNo;
...You're not actually wasting any space if you decalre the variable as 50 characters, but only use 3.
It really helps if you format code, so that, for example,
all the local variables are indented before the word BEGIN
everything between BEGIN and its corresponding END is indented
everything between IF and its corresponding END IF is indented,
and so on.
You're probably already doing that, but it doesn't show up on this site unless you type these 6 characters
(small letters only, inside curly brackets) before and after the formatted text.
That's what I did for the code fragement above.
Edited by: Frank Kulash on Mar 23, 2009 12:04 PM
Formatting stuff added.