[svn] 3326: Clean up of resources was happening incorrectly.

Question

Revision: 3326
Author: [email protected]
Date: 2008-09-24 06:58:09 -0700 (Wed, 24 Sep 2008)
Log Message:
Clean up of resources was happening incorrectly.
qa: yes, see bug report
doc: no
bug: LCDS-390
checkintests: passed
Details:
modules/core/src/flex/messaging/factories/JavaFactory.java
modules/core/src/flex/messaging/FactoryDestination.java
modules/core/src/flex/messaging/MessageBroker.java
modules/core/src/flex/messaging/services/AbstractService.java
modules/core/src/flex/messaging/services/MessageService.java
* createDestination should check on whether the destination already exists before trying to create the destination
* the behavior is now more consistent with addDestination
* this should minimize the possibility that the assembler class remains in the application scope even after the createDestination failure
* since both remove and stop call stop on the FactoryDestination, only remove the instance ref if the application is running when stop is called
Ticket Links:
http://bugs.adobe.com/jira/browse/LCDS-390
Modified Paths:
blazeds/trunk/modules/core/src/flex/messaging/FactoryDestination.java
blazeds/trunk/modules/core/src/flex/messaging/MessageBroker.java
blazeds/trunk/modules/core/src/flex/messaging/factories/JavaFactory.java
blazeds/trunk/modules/core/src/flex/messaging/services/AbstractService.java
blazeds/trunk/modules/core/src/flex/messaging/services/MessageService.java
blazeds/trunk/sampledb/flexdemodb/flexdemodb.properties

Answer 1

UlrikaJ, I've heard you talk of this before, do you
know of anywhere that gives a full explanation on the
use of dispose() for Windows and other classes? I've
never called dispose() and so I suppose I just get
away with it.I've collected some of these methods: close of Input/OutputStream, cancel of Timer and dispose of Graphics and Window. There may be more but I havent found any documentation other then the class documentation.
At first I couldn't believe that you sometimes have to call a specific termination method to avoid memory leaks. I argued that it must be enougth just to release all pointers to an object for it to be garbage collected. But Pervel finally convinced me with a memory leaking test program here at post 39,
http://forum.java.sun.com/thread.jsp?forum=31&thread=401418
When I realized I'd been wrong my face went crimson for a week because I had been calling Pervel a wannabe expert -:)
I've
never called dispose() and so I suppose I just get
away with it. Doesn't
setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE) sort
this stuff out for you?
I never know when to check for this kind of thing....Yes I guess if you have selected EXIT_ON_CLOSE both dispose() and System.exit() get called when the user closes the frame window.