[svn:fx-trunk] 10898: Fix for a bug: After playing a hide effect, a window wouldn't be visible again.

Question

Revision: 10898
Author:   [email protected]
Date:     2009-10-06 13:54:04 -0700 (Tue, 06 Oct 2009)
Log Message:
Fix for a bug: After playing a hide effect, a window wouldn't be visible again.
The issue here is that all effects that occur because of HIDE end up calling setVisible() (see EffectManager.effectEndHandler).  Window/WindowedApplication was basically left with two concepts of setVisible...the displayObject one and the native application one, and they were out of synch.  So setting visible=true on the window wasn?\226?\128?\153t calling setVisible(true) which controls the display object visibility.  Now instead of doing our work in the visible setter, we override setVisible() and do it in there.
QE notes: -
Doc notes: -
Bugs: SDK-23263
Reviewer: Darrell
Tests run: checkintests, Rob ran mustella window/windowedapplication
Is noteworthy for integration: No
Ticket Links:
    http://bugs.adobe.com/jira/browse/SDK-23263
Modified Paths:
    flex/sdk/trunk/frameworks/projects/airframework/src/mx/core/Window.as
    flex/sdk/trunk/frameworks/projects/airframework/src/mx/core/WindowedApplication.as
    flex/sdk/trunk/frameworks/projects/airframework/src/spark/components/Window.as
    flex/sdk/trunk/frameworks/projects/airframework/src/spark/components/WindowedApplication. as

Answer 1

I run Suse 9.1 Linux, and Suse has a package called lmsensors which by default on my machine gives readings like this:
Code: [Select]
temp1:       +27°C  (high =    +0°C, hyst =   +22°C)   sensor = thermistor
temp2:     +41.0°C  (high =   +80°C, hyst =   +75°C)   sensor = PII/Celeron diode 
Now that 41C is pretty high for an idle AMD643000+ running at 1000Mhz, 1.08V. Too high, I would say. temp 1 in this case is the SYS temp, temp2 is the CPU temp.
Now, using lmsensors I can duplicate your little trick and tell it that temp 2 is in fact a 3904 transistor. Having done this can I get readings like this:
Code: [Select]
temp1:       +27°C  (high =    +0°C, hyst =   +22°C)   sensor = thermistor
temp2:     +16.0°C  (high =   +80°C, hyst =   +75°C)   sensor = 3904 transistor 
Problem is, I'm not sure that the sensor is actually a 3904 transistor! The number's lower, but I was pretty sure that the sensor in the AMD64 is in fact a diode. Also, surely the CPU temp can't actually be that much lower than the SYS temp.
So, I think your fix succeeds in giving lower temps and that's great in that it will tell your system software that the CPU is not overheating, but I don't think it's the solution to high temp reporting. Anyway, as you say, its a solution for people who can't run with system shutdowns due to bogus high temps.  
I've been looking at these temp issues with the MSI K8T, and I was thinking the problem was simply a miscalibration. The Winbond sensor chip on my board (maybe the K8N is the same, maybe not) has a sensor temp offset that gets added to the temp coming from the sensor. On the K8T this number is +54C.   Funny number I know, but I've "fixed" the problem while I wait for a real bios fix on the K8T by simply reducing this offset to give me a CPU temp that matches SYS temp when idle. This enables cool'n'quiet fan control to work properly on my system, which is my main practical concern.