Swing program accessing oracle

Question

this program does not give output when oracle is being accessed.... please help sks_bank is a table in oracle database having account number, name, balance
import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import java.sql.*;
public class GridBagLoginDemo extends JFrame implements ActionListener
     JLabel l1,l2,l3,l4,l5;
     JTextField t1,t2,t3,t4;
     JButton b1,b2,b3;
     static Connection con;
     static Statement stat;
     static ResultSet result;
     public GridBagLoginDemo()
          super("The query application ");
          setLayout(new GridLayout(11,2));
          Color c=new Color(1,140,123);
          setBackground(c);
          l1=new JLabel("Account no:");
          l2=new JLabel("Amount:");
          l4=new JLabel("Balance:");
          l5=new JLabel("Name:");
          t1=new JTextField(20);
          t2=new JTextField(20);
          t3=new JTextField(20);
          t4=new JTextField(20);
          t3.setEditable(false);
          t4.setEditable(false);
          b2=new JButton("Balance");
          b1=new JButton("Deposit");
          b3=new JButton("Withdrawal");
          add(l1);add(t1);add(l2);add(t2);add(b1);add(b2);add(b3);add(l5);add(t4);add(l4);add(t3);          
          b1.addActionListener(this);
          b2.addActionListener(this);
          b3.addActionListener(this);
          pack();
          setVisible(true);
     public static void main(String a[])
          GridBagLoginDemo obj=new GridBagLoginDemo();
          try
               Class.forName("oracle.jdbc.driver.OracleDriver");
               con=DriverManager.getConnection("jdbc:oracle:thin:@topgun1:1521:topgun1", "scott", "tiger");
               System.out.println("sucess");
          catch(Exception e)
               System.out.println("could not execute the query"+e);
     }//close main method
     public void actionPerformed(ActionEvent a)
          try
               if(a.getSource( )==b2)
                    Statement stat=con.createStatement();
                    String squery="select * from sks_bank where acc_no=";
                    squery=squery+t1.getText();
                    System.out.println("the query is="+squery);
                    ResultSet result=stat.executeQuery(squery);
                    System.out.println("Acc_no U entered:"+t1.getText());
                    if(result != null )
                    System.out.println("result set not null");
                    while( result.next())
                    String s2=result.getString(2);
                    System.out.println("the result is="+s2);
                    System.out.println(result.getString(1)+"\t"+result.getString(2)+"\t"+result.getString(3));
                    }//close if loop
                    //result.next();
          catch(Exception e)
          System.out.println("exceception in query="+e);
Message was edited by:
sanjay_shaswani

Answer 1

String squery="select * from sks_bank where acc_no=";
squery=squery+t1.getText();shudder...
SQL injection attack heaven.
And who's for betting that the column is varchar instead of numeric?