Syntax error in For Loop statement

Question

Hello
Normally my FOR staements have not been a problem as only access one table. I the example below I am accessing three table and therefore I get a Syntax error.
I only wish to select the "Product" recored but need the other table to enable the select the right results.
FOR product_rec IN (SELECT * from PRODUCT, PRODUCT_GROUP,PROD_PROD_GROUP
where PRODUCT_GROUP.PRODUCT_GROUP_KEY = PROD_PROD_GROUP.PRODUCT_GROUP_KEY
and PROD_PROD_GROUP.PRODUCT_KEY = PRODUCT.PRODUCT_KEY
and product.supplier_key = company_no
and PROD_PROD_GROUP.MULTI_WEB_DIS = 1
order by PROD_PROD_GROUP.MULTI_WEB_SEQ)
Can anyone let the correct syntx for this statement.
Thanks
Pete

Answer 1

Like Dom said:
FOR product_rec IN (SELECT PRODUCT.* from PRODUCT, PRODUCT_GROUP,PROD_PROD_GROUP
where PRODUCT_GROUP.PRODUCT_GROUP_KEY = PROD_PROD_GROUP.PRODUCT_GROUP_KEY
and PROD_PROD_GROUP.PRODUCT_KEY = PRODUCT.PRODUCT_KEY
and product.supplier_key = company_no
and PROD_PROD_GROUP.MULTI_WEB_DIS = 1
order by PROD_PROD_GROUP.MULTI_WEB_SEQ) Or what he meant by "nice to have", use aliases:
select p.*
from
  product p,
  product_group pg,
  prod_prod_group ppg
where
  pg.product_group_key = ppg.product_group_key
  and ppg.product_key = p.product_key
  and p.supplier_key = company_no
  and ppg.multi_web_dis = 1
order by
  ppg.multi_web_seqAlso, note that company_no is not aliased in the above query. If this is a column, it should be aliased as well (either with the full table name or the alias if you switch to using them). If it is a PL/SQL variable, it is fine as is.
Edited by: cmartin2 on Feb 2, 2011 1:56 PM