To download file but still the Save Dialog box still not show? Please help.

Question

Hi All,
Below is my full code to download file but still the Save Dialog box still not show..
<%@ taglib prefix="cs" uri="futuretense_cs/ftcs1_0.tld"
%><%@ taglib prefix="asset" uri="futuretense_cs/asset.tld"
%><%@ taglib prefix="assetset" uri="futuretense_cs/assetset.tld"
%><%@ taglib prefix="commercecontext" uri="futuretense_cs/commercecontext.tld"
%><%@ taglib prefix="ics" uri="futuretense_cs/ics.tld"
%><%@ taglib prefix="listobject" uri="futuretense_cs/listobject.tld"
%><%@ taglib prefix="render" uri="futuretense_cs/render.tld"
%><%@ taglib prefix="siteplan" uri="futuretense_cs/siteplan.tld"
%><%@ taglib prefix="searchstate" uri="futuretense_cs/searchstate.tld"
%><%@ taglib prefix="locale" uri="futuretense_cs/locale1.tld"
%><%@ taglib prefix="dateformat" uri="futuretense_cs/dateformat.tld"
%><%@ taglib prefix="blobservice" uri="futuretense_cs/blobservice.tld"
%><%@ taglib prefix="satellite" uri="futuretense_cs/satellite.tld"     
%><%@ taglib prefix="date" uri="futuretense_cs/date.tld"
%><%@ page import="COM.FutureTense.Interfaces.*,
COM.FutureTense.Util.ftMessage,
COM.FutureTense.Util.ftErrors"
%><%@ page import="COM.FutureTense.Interfaces.*,
COM.FutureTense.Util.ftMessage,
COM.FutureTense.Util.ftErrors"
%>
<%@ page language="java" contentType="text/html;charset=UTF-8" %>
<%@ page import="java.io.File" %>
<%@ page import="java.io.OutputStream" %>
<%@ page import="java.io.FileInputStream" %>
<cs:ftcs><%-- france/test_template
INPUT
OUTPUT
--%>
<%-- Record dependencies for the Template --%>
<ics:if condition='<%=ics.GetVar("tid")!=null%>'><ics:then><render:logdep cid='<%=ics.GetVar("tid")%>' c="Template"/></ics:then></ics:if>
<%
String fileToFind = request.getParameter("file");
if(fileToFind == null) return;
File fname = new File(fileToFind);
System.out.println("Save As: "+fname.getName() );
if(!fname.exists()) return;
FileInputStream istr = null;
response.setContentType("application/octet-stream;charset=ISO-8859-1");
response.setHeader("Content-Disposition", "attachment; filename=\"" + fname.getName() + "\";");
try {
istr = new FileInputStream(fname);
int curByte=-1;
while( (curByte=istr.read()) !=-1){
out.write(curByte);
out.flush();
} catch(Exception ex){
ex.printStackTrace(System.out);
} finally{
try {
if(istr!=null) istr.close();
} catch(Exception ex){
System.out.println("Major Error Releasing Streams: "+ex.toString());
try {
response.flushBuffer();
} catch(Exception ex){
System.out.println("Error flushing the Response: "+ex.toString());
%>
</cs:ftcs>
Can anybody help me with this??? What is lacking...
Thank you in advance.

Answer 1

Put this code into a servlet rather than a JSP.
JSP are for returning text based HTML pages. It adds extra carriage returns into the response that will corrupt the file, and prevent the dialog showing up.
This code is much better off being in a servlet
If you are using a FileInputStream, you should be using a ServletOutputStream rather than the JSP writer: response.getOutputStream()
When dealing with file input in a JSP/Servlet you should use the methods of ServletContext. getRealPath() turns a website relative file into a real location on disk. getResourceAsStream() opens the file for you. getResourceAsStream() is more reliable as it will work even if the web app is deployed in a packed WAR.
Cheers,
evnafets