Trigger is firing multiple times

Question

Hi
  we have a table in database , which has multiple triggers defined by Vendor. I have created our own custom trigger on this table also , which fires last. Goal of this custom trigger is to send an email, when ever update happens on table. But somehow
trigger is firing multiple times for same update, so it is sending multiple email for same update also
   Any advice?
thanks
Drew

Answer 1

ALTER trigger [dbo].[AB_TABLEXXX_IUD_TR]
on [dbo].[TABLEXXX]
after insert,update,delete
as
begin
    set nocount on
    declare @sub varchar(1024)
    declare @tmpstr nvarchar(max)
 DECLARE @action as char(1);
 declare @id as int
 declare @send as int
    SET @action = 'I'; -- Set Action to Insert by default.
    declare @insCount int
 declare @delCount int
 DECLARE @newLineChar AS CHAR(2) = CHAR(13) + CHAR(10)
 DECLARE @tab as CHAR(1)=char(9)
    declare @vendorId char(30)  
 declare @detailmsg varchar(500)
 declare @ovname varchar(30),@nvname varchar(100)
 declare @ovchkname varchar(100),@nvchkname varchar(100)
 declare @oaddress1 varchar(100),@naddress1 varchar(100)
 declare @oaddress2 varchar(100),@naddress2 varchar(100)
 declare @oaddress3 varchar(100),@naddress3 varchar(100)
 declare @ouserdef1 varchar(100),@nuserdef1 varchar(100)
 declare @ovndclsid varchar(11),@nvndclsid varchar(11)
 select @tmpstr=''
 select @insCount = count(*) from INSERTED
 select @delCount = count(*) from DELETED
    if(@insCount > 0 or @delCount > 0)--if something was actually affected, otherwise do nothing
    Begin
        if(@insCount = @delCount)
            set @action = 'U'--is update
        else if(@insCount > 0)
            set @action = 'I' --is insert
        else
            set @action = 'D' --is delete
    End
 else
  select @action='X'
 if(@action='X') RETURN
 select @sub='Not Found'
 set @send=0
    if (@action='I')
 begin
  select top 1 @vendorId=rtrim(VENDORID),@nvname=rtrim(VENDNAME),@nvchkname=rtrim(VNDCHKNM), @naddress1=rtrim(ADDRESS1) ,
    @naddress2=rtrim(ADDRESS2),@naddress3=rtrim(ADDRESS3),@nuserdef1=rtrim(USERDEF1),@nvndclsid=rtrim(VNDCLSID) from inserted 
  select @sub=ORIGINAL_LOGIN()+' : '+'Data inserted in table ''TABLEXXX'''
  select @send=1
  select @sub=ORIGINAL_LOGIN()+' : '+'New Vendor
'''+@nvname+''' is added'
  select @tmpstr=@sub
  select @tmpstr =@tmpstr+@newLineChar +'Inserted On: '+ Convert(varchar(50),sysdatetime())+@newLineChar
  select @tmpstr=@tmpstr+@newLineChar+'Vendor ID:
'+@vendorId
  select @tmpstr=@tmpstr+@newLineChar+'Vendor Name:
'+@nvname
  select @tmpstr=@tmpstr+@newLineChar+'Check Name:
'+@nvchkname
  select @tmpstr=@tmpstr+@newLineChar+'Address1:
'+@naddress1
  select @tmpstr=@tmpstr+@newLineChar+'Address2:
'+@naddress2
  select @tmpstr=@tmpstr+@newLineChar+'Address3:
'+@naddress3
  select @tmpstr=@tmpstr+@newLineChar+'User Def:
'+@nuserdef1
  select @tmpstr=@tmpstr+@newLineChar+'Class ID:
'+@nvndclsid
 end
 if (@action='U')
 begin
  select @sub=ORIGINAL_LOGIN()+':''Data Updated in table ''TABLEXXX'''  
  declare @iTotal int
  select @iTotal =0
  select @detailmsg=''
  create table #new_values(
   VENDORID varchar(100) NULL,
   processed char(1) NULL
  insert into #new_values
     select distinct VENDORID,NULL from inserted  
  while ((select count(*) from #new_values where processed is null)>0 and @iTotal<=50)
  begin
     --PRINT 'UPDATE Entered ' +@action
   select @iTotal=@iTotal+1
   select top 1 @vendorId=VENDORID from #new_values where processed is null
   update #new_values set processed='Y' where
VENDORID=@vendorId and processed is null
   select @detailmsg=''
   select
     top 1       
       @ovname=o.VENDNAME, @nvname=n.VENDNAME,
    @ovchkname=o.VNDCHKNM,@nvchkname=n.VNDCHKNM,
    @oaddress1=o.ADDRESS1,@naddress1=n.ADDRESS1,
    @oaddress2=o.ADDRESS2,@naddress2=n.ADDRESS2,
    @oaddress3=o.ADDRESS3,@naddress3=n.ADDRESS3,
    @ouserdef1=o.USERDEF1,@nuserdef1=n.USERDEF1,
    @ovndclsid=o.VNDCLSID,@nvndclsid=n.VNDCLSID
   from  inserted n,deleted o
   where n.VENDORID=o.VENDORID and n.VENDORID
=@vendorId
   if (update(VENDNAME) and @ovname<>@nvname) select @detailmsg
=@detailmsg+ @newLineChar
+@tab+'Vendor Name: '+rtrim(@ovname)+' => '+rtrim(@nvname)
   if (update(VNDCHKNM) and @ovchkname<>@nvchkname) select @detailmsg
=@detailmsg+ @newLineChar
+@tab+'Check Name: '+rtrim(@ovchkname)+' => '+rtrim(@nvchkname)
   if (update(ADDRESS1) and @oaddress1<>@naddress1) select @detailmsg
=@detailmsg+ @newLineChar
+@tab+'Address1: '+rtrim(@oaddress1)+' => '+rtrim(@naddress1)
   if (update(ADDRESS2) and @oaddress2<>@naddress2) select @detailmsg
=@detailmsg+ @newLineChar
+@tab+'Address2: '+rtrim(@oaddress2)+' => '+rtrim(@naddress2)
   if (update(ADDRESS3) and @oaddress3<>@naddress3) select @detailmsg
=@detailmsg+ @newLineChar
+@tab+'Address3: '+rtrim(@oaddress3)+' => '+rtrim(@naddress3)
   if (update(USERDEF1) and @ouserdef1<>@nuserdef1) select @detailmsg
=@detailmsg+ @newLineChar
+@tab+'User Def: '+rtrim(@ouserdef1)+' => '+rtrim(@nuserdef1)
   if (update(VNDCLSID) and @ovndclsid<>@nvndclsid) select @detailmsg
=@detailmsg+ @newLineChar
+@tab+'Class ID: '+rtrim(@ovndclsid)+' => '+rtrim(@nvndclsid)
   if(len(@detailmsg)>0)
   begin
       select @send=1
    if (len(@tmpstr)<=0)
    begin
      select @sub=ORIGINAL_LOGIN()+' : '+'Vendor '''+rtrim(@ovname)+''' Updated in table TABLEXXX'
      select @tmpstr='Vendor '''+rtrim(@ovname)+''' Updated'
      select @tmpstr
=@tmpstr+@newLineChar +@tab+'Updated On: '+ Convert(varchar(50),sysdatetime())+@newLineChar
      select @tmpstr
=@tmpstr+@newLineChar +@tab+'Vendor ID: '+rtrim(@vendorId)
    end
    select @tmpstr=@tmpstr +@detailmsg
   end
  end
 end
 if (@action='D')
 begin
  select top 1 @vendorId=rtrim(VENDORID),@nvname=rtrim(VENDNAME),@nvchkname=rtrim(VNDCHKNM), @naddress1=rtrim(ADDRESS1) ,
    @naddress2=rtrim(ADDRESS2),@naddress3=rtrim(ADDRESS3),@nuserdef1=rtrim(USERDEF1),@nvndclsid=rtrim(VNDCLSID) from deleted 
  select @send=1
  select @sub=ORIGINAL_LOGIN()+' : '+'Vendor
'''+@nvname+''' is DELETED'
  select @tmpstr=@sub
  select @tmpstr =@tmpstr+@newLineChar +'Deleted On: '+ Convert(varchar(50),sysdatetime())+@newLineChar
  select @tmpstr=@tmpstr+@newLineChar+'Vendor ID:
'+@vendorId
  select @tmpstr=@tmpstr+@newLineChar+'Vendor Name:
'+@nvname
  select @tmpstr=@tmpstr+@newLineChar+'Check Name:
'+@nvchkname
  select @tmpstr=@tmpstr+@newLineChar+'Address1:
'+@naddress1
  select @tmpstr=@tmpstr+@newLineChar+'Address2:
'+@naddress2
  select @tmpstr=@tmpstr+@newLineChar+'Address3:
'+@naddress3
  select @tmpstr=@tmpstr+@newLineChar+'User Def:
'+@nuserdef1
  select @tmpstr=@tmpstr+@newLineChar+'Class ID:
'+@nvndclsid
 end
 if (@action<>'X' and @send=1)
 begin
  Exec msdb.dbo.sp_send_dbmail
   @profile_name='default',   
   @recipients='[email protected]',
   @subject= @sub,
   @body=@tmpstr
 end
end
Drew