Troubles using Javascript popoup inside a PHP file

Question

I am trying something simple: to open a popup window trough a
javascript code inside my PHP file and nothing happens: here is the
code:
$openwindow =
"MM_openBrWindow('view.html','','width=300,height=300')";
echo "<td><a href='#'><img
src='images/button_blue.jpg' alt='Map' width='97' height='13'
border='0' onclick=" . $openwindow . "/></a></td>";
Also I am declaring such Javascript function at the beginning
of the file... Please help me as soon as you can... it is driving
me crazy... thanx in advance !

Answer 1

.oO(David Powers)
>Michael Fesser wrote:
>> print "<a
href='foo?id=$something'>bar</a>";
>>
>> Not a single escape character and very readable in
an editor with proper
>> syntax highlighting.
>
>I agree with Steve that this is a trivial example that
doesn't really
>prove anything.
OK. At least it shows that escaping is not always necessary
In a more complex example with more variables I would've used
printf().
>If $something is the only variable in a long section of
>HTML, it's much more efficient to do this:
>
><a href="foo?id=<?php echo $something;
?>">bar</a>
I don't think efficieny is really an issue here.
>Every time that the PHP engine encounters double quotes
inside a PHP
>block, the engine has to parse the content to find if any
variables are
>interpolated. In your example, there is a variable, so
the effort isn't
>wasted, but many developers use double quotes all the
time, even if no
>variable are included in strings. Although the difference
in processing
>time is only microseconds, it's an inefficient way of
writing PHP.
Did you ever encounter any performance issues just because of
using
"unneccesary" double quotes? Or by using string concatenation
instead of
the slightly faster
echo $foo, $bar, $somethingElse ?
I didn't, and I doubt I ever will. It may be not the best
style and
usually I use single quotes where possible, but I don't care
too much,
because other things are much more important.
In fact I consider that all rather esoterical. If someone
tries to
"optimize" his code by avoiding double quoted strings where
possible
then IMHO he doesn't really have understood optimization at
all. The
real bottlenecks are not some syntactical sugar provided by
PHP, but the
algorithms and I/O operations. That's where optimization has
to start.
>However, I've seen a lot of inexperienced people post
questions about
>PHP problems, usually caused by the incorrect mixture of
single and
>double quotes.
Agreed, me too. But often it's not just some lack of
knowledge, but also
the usage of the wrong tool. Many errors I've seen in
beginner's code
(especially the mentioned quoting problems) could've been
easily spotted
with proper syntax highlighting.
>When you ask why they have coded it in such a convoluted
>way, the answer is invariably "because it's a PHP page".
Hmm, quite possible.
>PHP is designed
>to be embedded in HTML.
True, but just because PHP is designed for this and that,
doesn't mean
that I always have to use it in that way. Remember
register_globals and
magic quotes - they were a fundamental part of PHP's design a
while ago.
>You can also include HTML in PHP functions.
Now it gets really nasty. That's even more ugly than heredoc
syntax. ;)
With HTML embedded in PHP functions I always had the problem
how to
indent the code - either the source code looked bad or the
final HTML.
I never did it again.
>If the HTML block contains a lot of variables or other
dynamic code, I
>agree that using print or echo is probably more efficient
and easier to
>read. However, when HTML is predominant, embed the
dynamic stuff.
As said - I consider it just personal preference. There are
valid
reasons for both ways.
Micha