Trying to catch all exceptions...

Question

Hi, developers!
I am trying to develop the best code, that can catch all the exceptions, in the best possible way, and whenever as possible it must register in a log with informations about the exception occurred.
I need your suggestions. See the code below:
MyClass()
  throws IOException, MyException {
  Throwable objThrowable1 = null;
  try {
    doSomething();
  } catch(MyException e) {
    objThrowable1 = e;
    throw e;
  } catch(IOException e) {
    objThrowable1 = e;
    throw e;
  } catch(RuntimeException e) {
    objThrowable1 = e;
    throw e;
  } catch(Exception e) {
    objThrowable1 = e;
    throw new Exception("Some Exception occurred.", e);
  } catch(Error e) {
    objThrowable1 = e;
    throw e;
  } finally {
    if (objThrowable1 != null) {
      Throwable objThrowable2 = null;
      try {
        log.fatal(objThrowable1);
        objThrowable1.printStackTrace();
      } catch(RuntimeException e) {
        objThrowable2 = e;
        throw e;
      } catch(Exception e) {
        objThrowable2 = e;
        throw new Exception("Some Exception occurred while logging.", e);
      } catch(Error e) {
        objThrowable2 = e;
        throw e;
      } finally {
        if (objThrowable2 != null) {
          objThrowable2.printStackTrace();
}It is the constructor of MyClass, and it might throw IOException or MyException.
Now some questions:
1) Do you think I exaggerated and wrote a lot of code, more than sufficient?
2) I wrote all this code because I think it�s a good idea throwing exceptions, especially RuntimeException and Error. The Virtual Machine must know how to handle the situation when some exception occurs. But I want to register a log of the exception, too, whenever as possible. In my opinion, the only way to advise the Virtual Machine that some exception occurred is throwing this exception. Do you agree? Do I really need to worry about it?
Thanks in advance!

Answer 1

Hi, developers!
I am trying to develop the best code, that can catch
all the exceptions, in the best possible way,Define "best possible way". I don't think what you're proposing is even close, by any measure.
You should only catch exceptions that you intend to handle. If there's no way for your class to handle the exception, it should bubble it up to the class that will. Catching and rethrowing like that seems a total waste to me.
I need your suggestions. See the code below:I'd suggest that this is an ugly mess. I would not go this way.
I have no idea whatsoever about that finally block. That should be for cleanup. What are you doing there?
MyClass()
throws IOException, MyException {
Throwable objThrowable1 = null;
try {
doSomething();
} catch(MyException e) {
objThrowable1 = e;
throw e;
} catch(IOException e) {
objThrowable1 = e;
throw e;
} catch(RuntimeException e) {
objThrowable1 = e;
throw e;
} catch(Exception e) {
objThrowable1 = e;
throw new Exception("Some Exception occurred.",
d.", e);
} catch(Error e) {
objThrowable1 = e;
throw e;
} finally {
if (objThrowable1 != null) {
Throwable objThrowable2 = null;
try {
log.fatal(objThrowable1);
objThrowable1.printStackTrace();
} catch(RuntimeException e) {
objThrowable2 = e;
throw e;
} catch(Exception e) {
objThrowable2 = e;
throw new Exception("Some Exception occurred
occurred while logging.", e);
} catch(Error e) {
objThrowable2 = e;
throw e;
} finally {
if (objThrowable2 != null) {
objThrowable2.printStackTrace();
}It is the constructor of MyClass, and it might
throw IOException or MyException.
Now some questions:
1) Do you think I exaggerated and wrote a lot of
code, more than sufficient?
2) I wrote all this code because I think it�s a good
idea throwing exceptions, especially
RuntimeException and Error. The Virtual
Machine must know how to handle the situation when
some exception occurs. But I want to register a log
of the exception, too, whenever as possible. In my
opinion, the only way to advise the Virtual Machine
that some exception occurred is throwing this
exception. Do you agree? Do I really need to worry
about it?
Thanks in advance!Cath t