Union select as cursor in procedure

Question

Hi!
With ref. to an earlier post from Sept. 11, 2009, I am facing the following problem:
In my procedure I have this statement as a cursor:
SELECT a.carrier_code, a.flight_no, a.from_city, a.origin, a.dept_time, a.to_city, a.destination, a.arr_time, a.flight_date,
a.aircraft_type, a.booking_class, a.service_class, a.num_of_seats, a.checked_bag, a.fare_basis, a.fare_type, a.currency, a.rt_net_fare, a.tax, a.surcharges, a.fare_total
FROM favailability a, main_related_flight b
WHERE a.flight_leg_id = b.flight_leg_id_1
AND a.from_city = 'London'
AND a.service_class = 'Business'
AND a.fare_type = 'Business Saver'
AND a.flight_date = '27.09.09'
UNION
SELECT d.carrier_code, d.flight_no, d.from_city, d.origin, d.dept_time, d.to_city, d.destination, d.arr_time, d.flight_date,
d.aircraft_type, d.booking_class, d.service_class, d.num_of_seats, d.checked_bag, d.fare_basis, d.fare_type, d.currency, d.rt_net_fare, d.tax, d.surcharges, d.fare_total
FROM favailability d, main_related_flight e
WHERE d.flight_leg_id = e.flight_leg_id_2
AND d.from_city = 'Zurich'
AND d.service_class = 'Business'
AND d.fare_type = 'Business Flex'
AND d.flight_date = '03.10.09'
ORDER BY flight_date;
ARRIER_CODE FLIGHT_NO              FROM_CITY                                                              ORIGIN DEPT_TIME TO_CITY                                                                DESTINATION ARR_TIME FLIGHT_DATE               AIRCRAFT_TYPE                            BOOKING_CLASS SERVICE_CLASS                  NUM_OF_SEATS           CHECKED_BAG          FARE_BASIS FARE_TYPE                      CURRENCY RT_NET_FARE            TAX                    SURCHARGES             FARE_TOTAL            
LX           345                    London                                                                 LHR    06:00     Zurich                                                                 ZRH         08:40    27.09.09                  Airbus A320                              J             Business                       64                     30 kg                LXJ        Business Saver                 EUR      337                    30,01                  35,24                  402,25                
LX           450                    Zurich                                                                 ZRH    07:00     London                                                                 LCY         07:35    03.10.09                  AVRO RJ100                               Z             Business                       37                     30 kg                LXZ        Business Flex                  EUR      740                    30,01                  21,24                  791,25                
2 rows selectedworks fine when running the statement alone. However, when running the procedure, my exception appears:
ORA-20022: Fare not found for flight from London to Zurich on 27-Sep-2009
Please note that the fare type can be different for inbound and outbound flights.
PROCEDURE  FLIGHT (p_ptc_adult IN NUMBER,
                  p_ptc_adult_rt       IN NUMBER,
                  p_ptc_adult_add      IN NUMBER,
                  p_ptc_adult_add_rt   IN NUMBER,
                  p_city_o             IN favailability.from_city%TYPE,
                  p_city_d             IN favailability.to_city%TYPE,
                  p_service_class      IN favailability.service_class%TYPE,
                  p_fare_type          IN favailability.fare_type%TYPE,
                  p_fare_type_rt       IN favailability.fare_type%TYPE,
                  p_flightdate         IN favailability.flight_date%TYPE,
                  p_flightdate_rt      IN favailability.flight_date%TYPE,
                  p_username           IN users.username%TYPE,
                  p_password           IN users.password%TYPE,
                  p_card_type          IN users_cc.card_type%TYPE,
                  p_creditcardnumber   IN VARCHAR2,
                  p_expiry_date        IN DATE,
                  p_first_name_add     IN VARCHAR2,
                  p_last_name_add      IN VARCHAR2) IS
CURSOR c1 IS
SELECT a.carrier_code, a.flight_no, a.from_city, a.origin, a.dept_time, a.to_city, a.destination, a.arr_time, a.flight_date,
a.aircraft_type, a.booking_class, a.service_class, a.num_of_seats, a.checked_bag, a.fare_basis, a.fare_type, a.currency, a.rt_net_fare, a.tax, a.surcharges, a.fare_total
FROM favailability a, main_related_flight b
WHERE a.flight_leg_id = b.flight_leg_id_1
AND a.from_city = p_city_o
AND a.service_class = p_service_class
AND a.fare_type = p_fare_type
AND a.flight_date = p_flightdate
UNION
SELECT d.carrier_code, d.flight_no, d.from_city, d.origin, d.dept_time, d.to_city, d.destination, d.arr_time, d.flight_date,
d.aircraft_type, d.booking_class, d.service_class, d.num_of_seats, d.checked_bag, d.fare_basis, d.fare_type, d.currency, d.rt_net_fare, d.tax, d.surcharges, d.fare_total
FROM favailability d, main_related_flight e
WHERE d.flight_leg_id = e.flight_leg_id_2
AND d.from_city = p_city_d
AND d.service_class = p_service_class
AND d.fare_type = p_fare_type_rt
AND d.flight_date = p_flightdate_rt
ORDER BY flight_date;
f_rec                 c1%ROWTYPE;
v_num_of_seats        favailability.num_of_seats%TYPE;
v_fare_type           favailability.fare_type%TYPE;
v_fare_type_rt        favailability.fare_type%TYPE;
v_net_fare            favailability.rt_net_fare%TYPE;
v_currency            fl_itinerary_t.currency_t%TYPE;
v_rid                 fl_itinerary_t.rid%TYPE;
v_status              fl_itinerary_t.status%TYPE;
v_ptc_adult           NUMBER;
v_ptc_adult_rt        NUMBER;
v_ptc_adult_add       NUMBER;
v_ptc_adult_add_rt    NUMBER;
e_no_passenger        EXCEPTION;
e_no_available_fares  EXCEPTION;
e_no_user             EXCEPTION;
e_credit_card_expired EXCEPTION;
v_error_code          error_log.err_code%TYPE;
v_error_message       error_log.err_message%TYPE;
v_error_date          error_log.err_date%TYPE;
v_user_name           users.username%TYPE;
v_password            users.password%TYPE;
v_user_id             users.user_id%TYPE;
v_first_name          users.first_name%TYPE;
v_last_name           users.last_name%TYPE;
v_dob                 users.dob%TYPE;
v_country_code        users.country_code%TYPE;
v_prefix              users.prefix%TYPE;
v_mobile_phone        users.mobile_phone%TYPE;
v_card_type           users_cc.card_type%TYPE;
v_creditcardnumber    users_cc.card_number%TYPE;
v_expiry_date         DATE;
v_grand_total         NUMBER(10,2);
v_first_name_add      VARCHAR2(40);
v_last_name_add       VARCHAR2(40);
v_booking_code        VARCHAR2(6);
v_result              VARCHAR2(32);
BEGIN
v_ptc_adult        := p_ptc_adult;
v_ptc_adult_rt     := p_ptc_adult_rt;
v_ptc_adult_add    := p_ptc_adult_add;
v_ptc_adult_add_rt := p_ptc_adult_add_rt;
-- Check user input
    IF p_city_o = p_city_d THEN
     dbms_output.put_line ('Departure city cannot be arrival city!');
    ELSIF p_flightdate = p_flightdate_rt THEN
     dbms_output.put_line ('Departure date cannot be arrival date!');
    ELSIF p_flightdate > p_flightdate_rt THEN
     dbms_output.put_line ('Departure date cannot be after arrival date!');
    ELSIF p_flightdate < sysdate OR p_flightdate_rt < sysdate THEN
     dbms_output.put_line ('Departure and arrival date cannot be in the past!');
    ELSE
    IF nvl(trunc(p_ptc_adult), 0) = 0
    OR nvl(trunc(p_ptc_adult_rt), 0) = 0
    THEN
        RAISE e_no_passenger;
    END IF;
-- Check outbound availability
    SELECT num_of_seats INTO v_num_of_seats
    FROM favailability
    WHERE v_ptc_adult = p_ptc_adult
    AND v_ptc_adult_add = p_ptc_adult_add
    AND from_city = p_city_o
    AND to_city = p_city_d
    AND service_class = p_service_class
    AND fare_type = p_fare_type
    AND fare_type = p_fare_type_rt
    AND flight_date = p_flightdate;
    IF p_ptc_adult > v_num_of_seats
     OR v_num_of_seats < 2 THEN
      dbms_output.put_line ('No seats available!');
    ELSE
     UPDATE favailability SET num_of_seats = num_of_seats - p_ptc_adult
     WHERE v_ptc_adult = p_ptc_adult
     AND from_city = p_city_o
     AND to_city = p_city_d
     AND service_class = p_service_class
     AND fare_type = p_fare_type
     AND fare_type = p_fare_type_rt
     AND flight_date = p_flightdate;
    END IF;
    IF p_ptc_adult_add > v_num_of_seats
     OR v_num_of_seats < 2 THEN
      dbms_output.put_line ('No seats available!');
    ELSE
     UPDATE favailability SET num_of_seats = num_of_seats - p_ptc_adult_add
     WHERE v_ptc_adult_add = p_ptc_adult_add
     AND from_city = p_city_o
     AND to_city = p_city_d
     AND service_class = p_service_class
     AND fare_type = p_fare_type
     AND fare_type = p_fare_type_rt
     AND flight_date = p_flightdate;
    END IF;
-- Check inbound availability
    SELECT num_of_seats INTO v_num_of_seats
    FROM favailability
    WHERE v_ptc_adult_rt = p_ptc_adult_rt
    AND v_ptc_adult_add_rt = p_ptc_adult_add_rt
    AND from_city = p_city_d
    AND to_city = p_city_o
    AND service_class = p_service_class
    AND fare_type = p_fare_type_rt
    AND fare_type = p_fare_type
    AND flight_date = p_flightdate_rt;
    IF p_ptc_adult_rt > v_num_of_seats
     OR v_num_of_seats < 2 THEN
     dbms_output.put_line ('No seats available!');
    ELSE
     UPDATE favailability SET num_of_seats = num_of_seats - p_ptc_adult_rt
     WHERE v_ptc_adult_rt = p_ptc_adult_rt
     AND from_city = p_city_d
     AND to_city = p_city_o
     AND service_class = p_service_class
     AND fare_type = p_fare_type_rt
     AND fare_type = p_fare_type
     AND flight_date = p_flightdate_rt;
    END IF;
    IF p_ptc_adult_add_rt > v_num_of_seats
     OR v_num_of_seats < 2 THEN
     dbms_output.put_line ('No seats available!');
    ELSE
     UPDATE favailability SET num_of_seats = num_of_seats - p_ptc_adult_add_rt
     WHERE v_ptc_adult_add_rt = p_ptc_adult_add_rt
     AND from_city = p_city_d
     AND to_city = p_city_o
     AND service_class = p_service_class
     AND fare_type = p_fare_type_rt
     AND fare_type = p_fare_type
     AND flight_date = p_flightdate_rt;
    END IF;
  -- get credit info
    SELECT u.user_id, u.first_name, u.last_name, u.dob, u.country_code, u.prefix, u.mobile_phone, p_card_type, p_creditcardnumber, p_expiry_date
       INTO   v_user_id, v_first_name, v_last_name, v_dob, v_country_code, v_prefix, v_mobile_phone, v_card_type, v_creditcardnumber, v_expiry_date
       FROM   dual, users u, users_cc c
       WHERE  u.user_id = c.user_id
       AND u.username = p_username
       AND u.password = p_password
       AND c.card_type = p_card_type
       AND c.card_number = p_creditcardnumber
       AND c.expiry_date = p_expiry_date;
       IF SQL%ROWCOUNT = 0 THEN
                          RAISE e_no_user;
       END IF;
       IF p_expiry_date < sysdate THEN
              RAISE e_credit_card_expired;
       END IF;
    v_result := booking_pkg.validatecreditcard(p_creditcardnumber);
-- open cursor
OPEN c1;
LOOP
    FETCH c1 INTO f_rec;
    EXIT WHEN c1%notfound;
-- insert records    
     INSERT INTO fl_itinerary_t (rid, carrier_t, fno_t, from_city_t, origin_t, dept_t, to_city_t, destination_t, arr_t, fdate_t, aircraft_type_t, booking_class_t, service_class_t,
                                 num_of_seats_t, checked_bag_t, fare_basis_t, fare_type_t, currency_t, fare_t, tax_t, surcharges_t, fare_total_t, grand_total_t, trans_date,
                                 status, user_id, first_name, last_name, dob, country_code, prefix, mobile_phone)
     VALUES (new_res_seq.nextval, f_rec.carrier_code, f_rec.flight_no, f_rec.from_city, f_rec.origin, f_rec.dept_time, f_rec.to_city, f_rec.destination, f_rec.arr_time, f_rec.flight_date, f_rec.aircraft_type, f_rec.booking_class,
             f_rec.service_class, p_ptc_adult + p_ptc_adult_add, f_rec.checked_bag, f_rec.fare_basis, f_rec.fare_type, f_rec.currency, f_rec.rt_net_fare, f_rec.tax, f_rec.surcharges, f_rec.fare_total, f_rec.fare_total * (p_ptc_adult + p_ptc_adult_add), sysdate,
             'Confirmed', v_user_id, v_first_name, v_last_name, v_dob, v_country_code, v_prefix, v_mobile_phone);
  -- additional traveller
     SELECT p_first_name_add, p_last_name_add
     INTO v_first_name_add, v_last_name_add
     FROM dual;
     IF v_ptc_adult_add = p_ptc_adult_add
     AND v_ptc_adult_add_rt = p_ptc_adult_add_rt
     AND v_first_name_add = p_first_name_add
     AND v_last_name_add = p_last_name_add
     THEN
       INSERT INTO fl_itinerary_add (trans_id, carrier, fno, from_city, to_city, fdate, first_name_2, last_name_2, dob_2, main_user_id, trans_date, status)
       VALUES (new_trans_seq.nextval, f_rec.carrier_code, f_rec.flight_no, f_rec.from_city, f_rec.to_city, f_rec.flight_date, v_first_name_add, v_last_name_add, null, v_user_id, sysdate, 'Confirmed');
     END IF;
  COMMIT;  
END LOOP;
CLOSE c1;
     -- show itinerary for main traveller
       dbms_output.put_line ('Itinerary completed!');
       dbms_output.put_line (v_ptc_adult || ' seat(s) reserved for ' || v_first_name ||', ' || v_last_name);
       dbms_output.put_line (v_ptc_adult_rt || ' seat(s) reserved for ' || v_first_name ||', ' || v_last_name);
     -- show itinerary for 2.traveller
       dbms_output.put_line (v_ptc_adult_add || ' seat(s) reserved for ' || v_first_name_add ||', ' || v_last_name_add);
       dbms_output.put_line (v_ptc_adult_add_rt || ' seat(s) reserved for ' || v_first_name_add ||', ' || v_last_name_add); 
END IF;
       -- Create new booking
       INSERT INTO booking (booking_id,
                            rid,
                            e_ticket_no,
                            booking_code,
                            user_id,
                            first_name,
                            last_name,
                            dob,
                            credit_card_type,
                            credit_card_number,
                            currency, 
                            booking_date,
                            status)
       VALUES (new_booking_seq.nextval,
               new_res_seq.currval,
               dbms_random.value(1000000000000, 9999999999999),
               dbms_random.string('X', 6), 
               v_user_id,
               v_first_name,
               v_last_name,
               v_dob,
               v_card_type,
               'xxxx-xxxx-xxxx-'||substr(v_creditcardnumber,-4),
               f_rec.currency,
               SYSDATE, 'Confirmed');
        SELECT booking_code
        INTO v_booking_code
        FROM booking;
         dbms_output.put_line ('Booking code: ' || v_booking_code);
EXCEPTION
    WHEN e_no_available_fares THEN
      RAISE_APPLICATION_ERROR (-20021, 'There are no fares available for flight'||
                                       ' from '|| p_city_o||' to '|| p_city_d||' on '||TO_CHAR(p_flightdate, 'dd-Mon-yyyy'));
    WHEN no_data_found THEN
      RAISE_APPLICATION_ERROR (-20022, 'Fare not found for flight from '|| p_city_o||
                                       ' to '|| p_city_d||' on '||TO_CHAR(p_flightdate, 'dd-Mon-yyyy'));
    WHEN too_many_rows THEN
      RAISE_APPLICATION_ERROR (-20023, 'More than one fare found for flight from '||
                                        p_city_o||' to '|| p_city_d||' on '||
                                        TO_CHAR(p_flightdate, 'dd-Mon-yyyy'));
    WHEN e_no_passenger THEN
      RAISE_APPLICATION_ERROR(-20001, 'Please enter a valid number of travelers!');
    WHEN e_no_user THEN
      RAISE_APPLICATION_ERROR(-20002, 'User not found!');
    WHEN e_credit_card_expired THEN
      RAISE_APPLICATION_ERROR(-20003, 'Credit card has expired!');
    --WHEN OTHERS THEN
    --  v_error_code := SQLCODE;
    --  v_error_message := SUBSTR(SQLERRM, 1, 200);
     -- INSERT INTO error_log (err_code, err_message, err_date) VALUES
      --  (v_error_code, v_error_message, sysdate);
END FLIGHT;Furthermore, only 1 booking can be inserted into the booking table.

Answer 1

Hi!
Thanks for the tip! Now inserting into the booking table works! Sorry for bothering again. In my package I have this function that should check the
credit card number. Works alone, but not within the package (procedure). Please see above procedure too.
FUNCTION VALIDATECREDITCARD (p_creditcardnumber IN VARCHAR2)
   RETURN VARCHAR2
IS
   creditcardnumber    VARCHAR2 (32);
            --:= nosymbols (p_CreditCardNumber, LENGTH (p_CreditCardNumber));
   creditcardlength    NUMBER         := LENGTH (p_creditcardnumber);
   subtotal            NUMBER         := 0;
   t_value             NUMBER         := 0;
   c1                  NUMBER;
   c2                  NUMBER;
   c3                  NUMBER;
   c4                  NUMBER;
   cardtype            VARCHAR2 (160) := 'CARD';
   calculationmethod   VARCHAR2 (160) := 'UNKNOWN';
   RESULT              VARCHAR2 (160);
   v_expiry_date       DATE;
BEGIN
   creditcardnumber := LTRIM(RTRIM(p_creditcardnumber));
   creditcardnumber := REPLACE(creditcardnumber, '-');
   creditcardnumber := REPLACE(creditcardnumber, '.');
-- IF isnumber (CreditCardNumber) = 0 THEN
   c1 := TO_NUMBER (SUBSTR (creditcardnumber, 1, 1));
   c2 := TO_NUMBER (SUBSTR (creditcardnumber, 1, 2));
   c3 := TO_NUMBER (SUBSTR (creditcardnumber, 1, 3));
   c4 := TO_NUMBER (SUBSTR (creditcardnumber, 1, 4));
   IF creditcardlength = 13
   THEN
      IF c1 IN (4)
      THEN
         cardtype := 'VISA';
         calculationmethod := 'MOD10';
      END IF;
   ELSIF creditcardlength = 14
   THEN
      IF c2 IN (36, 38)
      THEN
         cardtype := 'DINERS CLUB';
         calculationmethod := 'MOD10';
      ELSIF c3 IN (300, 301, 302, 303, 304, 305)
      THEN
         cardtype := 'DINERS CLUB';
         calculationmethod := 'MOD10';
      END IF;
   ELSIF creditcardlength = 15
   THEN
      IF c2 IN (34, 37)
      THEN
         cardtype := 'AMEX';
         calculationmethod := 'MOD10';
      ELSIF c4 IN (2014, 2149)
      THEN
         cardtype := 'enROUTE';
         calculationmethod := 'ANY';
      ELSIF c4 IN (2131, 1800)
      THEN
         cardtype := 'JBC';
         calculationmethod := 'MOD10';
      END IF;
   ELSIF creditcardlength = 16
   THEN
      IF c1 IN (4)
      THEN
         cardtype := 'VISA';
         calculationmethod := 'MOD10';
      ELSIF c1 IN (3)
      THEN
         cardtype := 'JBC';
         calculationmethod := 'MOD10';
      ELSIF c2 IN (51, 52, 53, 54, 55)
      THEN
         cardtype := 'MASTERCARD';
         calculationmethod := 'MOD10';
      ELSIF c4 IN (6011)
      THEN
         cardtype := 'DISCOVER';
         calculationmethod := 'MOD10';
      END IF;
   END IF;
   IF calculationmethod = 'MOD10'
   THEN
      FOR i IN REVERSE 1 .. LENGTH (creditcardnumber)
      LOOP
             IF cardtype = 'AMEX'
         THEN
            IF (TO_NUMBER (SUBSTR (TO_CHAR (i), LENGTH (i), 1)) NOT IN  (1, 3, 5, 7, 9))
            THEN
               t_value := SUBSTR (creditcardnumber, i, 1) * 2;
               subtotal := subtotal + SUBSTR (t_value, 1, 1);
               subtotal := subtotal + NVL (SUBSTR (t_value, 2, 1), 0);
            ELSE
               subtotal := subtotal + SUBSTR (creditcardnumber, i, 1);
            END IF;                       
         ELSE          
            IF (TO_NUMBER (SUBSTR (TO_CHAR (i), LENGTH (i), 1)) IN  (1, 3, 5, 7, 9))
            THEN
               t_value := SUBSTR (creditcardnumber, i, 1) * 2;
               subtotal := subtotal + SUBSTR (t_value, 1, 1);
               subtotal := subtotal + NVL (SUBSTR (t_value, 2, 1), 0);
            ELSE
               subtotal := subtotal + SUBSTR (creditcardnumber, i, 1);
            END IF;                       
         END IF;
      END LOOP;
      IF MOD (subtotal, 10) = 0
      THEN
         RESULT := 'VALID';
      ELSE
         RESULT := 'INVALID';
      END IF;
   ELSIF calculationmethod = 'ANY'
   THEN
      RESULT := 'VALID';
   ELSE
      RESULT := 'UNKNOWN';
   END IF;
   RESULT := RESULT || ', ' || cardtype;
   RETURN (RESULT);
END VALIDATECREDITCARD;
create or replace PACKAGE        "BOOKING_PKG"
AS
  PROCEDURE  FLIGHT (p_ptc_adult IN NUMBER,
                  p_ptc_adult_rt       IN NUMBER,
                  p_ptc_adult_add      IN NUMBER,
                  p_ptc_adult_add_rt   IN NUMBER,
                  p_city_o             IN favailability.from_city%TYPE,
                  p_city_d             IN favailability.to_city%TYPE,
                  p_service_class      IN favailability.service_class%TYPE,
                  p_fare_type          IN favailability.fare_type%TYPE,
                  p_fare_type_rt       IN favailability.fare_type%TYPE,
                  p_flightdate         IN favailability.flight_date%TYPE,
                  p_flightdate_rt      IN favailability.flight_date%TYPE,
                  p_username           IN users.username%TYPE,
                  p_password           IN users.password%TYPE,
                  p_card_type          IN users_cc.card_type%TYPE,
                  p_creditcardnumber   IN VARCHAR2,
                  p_expiry_date        IN DATE,
                  p_first_name_add     IN VARCHAR2,
                  p_last_name_add      IN VARCHAR2);
  PROCEDURE  NEW_USER (p_username      IN users.username%TYPE,
                       p_password      IN users.password%TYPE,
                       p_salutation       users.salutation%TYPE,
                       p_academic_title   users.academic_title%TYPE,
                       p_first_name       users.first_name%TYPE,
                       p_last_name        users.last_name%TYPE,
                       p_dob              users.dob%TYPE,
                       p_street_address   users.street_address%TYPE,
                       p_company_name     users.company_name%TYPE,
                       p_street_address_2 users.street_address_2%TYPE,
                       p_country          users.country%TYPE,
                       p_postal_code      users.postal_code%TYPE,
                       p_city             users.city%TYPE,
                       p_e_mail_address   users.e_mail_address%TYPE,
                       p_country_code     users.country_code%TYPE,
                       p_prefix           users.prefix%TYPE,
                       p_mobile_phone     users.mobile_phone%TYPE,
                       p_home_phone       users.home_phone%TYPE,
                       p_language         users.language%TYPE,
                       p_newsletter       users.newsletter%TYPE,
                       p_specials         users.specials%TYPE,
                       p_membership       users.membership%TYPE,
                       p_remarks          users.remarks%TYPE);
  FUNCTION  VALIDATECREDITCARD (p_creditcardnumber IN VARCHAR2) RETURN VARCHAR2;
END BOOKING_PKG;Thanks for your help!