Update to ansi 99 sql join syntax

Question

Hello All
I'm updating some code to ansi 99 compliant sql.
I have
SELECT
  CL_ASSIGNED_NUMBERS2.TITLE,
  CL_ASSIGNED_NUMBERS2.FIRST_NAME,
  CL_ASSIGNED_NUMBERS2.SURNAME,
  CL_ASSIGNED_NUMBERS2.NUM,
  CL_NUMBERS2.OTHER_NUM,
  CL_ASSIGNED_NUMBERS2.LOCATION,
  CL_AS_DEPTS.DEPT_NAME,
  CL_FURTHER_CONTACTS.TITLE,
  CL_FURTHER_CONTACTS.FIRST_NAME,
  CL_FURTHER_CONTACTS.SURNAME,
  EMAIL.LSE_EMAIL,
  CL_ASSIGNED_NUMBERS2.NUMBER_DESC,
  CL_FURTHER_CONTACTS.NUM,
  CL_FURTHER_CONTACTS.LOCATION,
  CL_ASSIGNED_NUMBERS2.AREA,
  CL_ASSIGNED_NUMBERS2.DESC_DIR_ENTRY,
  CL_ASSIGNED_NUMBERS2.AREA_DIR_ENTRY,
  CL_NUMBERS3.OTHER_NUM,
  CL_ASSIGNED_NUMBERS2.PREF_EMAIL
FROM
  CALL_LOG.CL_ASSIGNED_NUMBERS  CL_ASSIGNED_NUMBERS2,
  CALL_LOG.CL_NUMBERS  CL_NUMBERS2,
  CALL_LOG.CL_DEPARTMENTS  CL_AS_DEPTS,
  CALL_LOG.CL_ASSIGNED_NUMBERS  CL_FURTHER_CONTACTS,
  CALL_LOG.CURRENT_PERSONAL_EMAILS  EMAIL,
  CALL_LOG.CL_NUMBERS  CL_NUMBERS3
WHERE
  ( CL_ASSIGNED_NUMBERS2.FURTHER_CONTACT_CAN_ID=CL_FURTHER_CONTACTS.CAN_ID(+)  )
  AND  ( CL_ASSIGNED_NUMBERS2.DEPT_CODE=CL_AS_DEPTS.DEPT_CODE(+)  )
  AND  ( CL_NUMBERS2.NUM=CL_ASSIGNED_NUMBERS2.NUM(+)  )
  AND  ( CL_ASSIGNED_NUMBERS2.PLAY_REF=EMAIL.PLAY_REF(+)  )
  AND  ( CL_FURTHER_CONTACTS.NUM=CL_NUMBERS3.NUM(+)  )which i have rewritten as
SELECT
  AS_NO.TITLE,
  AS_NO.FIRST_NAME,
  AS_NO.SURNAME,
  AS_NO.NUM,
  NO.OTHER_NUM,
  AS_NO.LOCATION,
  DEPT.DEPT_NAME,
  AS_NO.TITLE,
  CONS.FIRST_NAME,
  CONS.SURNAME,
  EMAIL.LSE_EMAIL,
  AS_NO.NUMBER_DESC,
  CONS.NUM,
  CONS.LOCATION,
  AS_NO.AREA,
  AS_NO.DESC_DIR_ENTRY,
  AS_NO.AREA_DIR_ENTRY,
  NOS.OTHER_NUM,
  AS_NO.PREF_EMAIL
FROM CL_ASSIGNED_NUMBERS AS_NO
LEFT OUTER JOIN CL_ASSIGNED_NUMBERS CONS ON (AS_NO.FURTHER_CONTACT_CAN_ID=CONS.FURTHER_CONTACT_CAN_ID)
LEFT OUTER JOIN CL_DEPARTMENTS DEPT ON (AS_NO.DEPT_CODE=DEPT.DEPT_CODE)
LEFT OUTER JOIN CL_NUMBERS NO ON (AS_NO.NUM=NO.NUM)
LEFT OUTER JOIN CURRENT_PERSONAL_EMAILS EMAIL ON (AS_NO.PLAY_REF=EMAIL.PLAY_REF)
LEFT OUTER JOIN CL_NUMBERS NOS ON (CONS.NUM=NOS.NUM)with the first query i get 8130 rows, with the second I get 9676.
Yet to me the seem like the same query. Can anyone give me an idea as to where I've gone wrong?
Thanks and Regards
Ali

Answer 1

select count (*)
FROM
CALL_LOG.CL_ASSIGNED_NUMBERS  CL_ASSIGNED_NUMBERS2,
CALL_LOG.CL_NUMBERS  CL_NUMBERS2,
CALL_LOG.CL_ASSIGNED_NUMBERS  CL_FURTHER_CONTACTS
WHERE
( CL_ASSIGNED_NUMBERS2.FURTHER_CONTACT_CAN_ID=CL_FURTHER_CONTACTS.CAN_ID(+)  )
AND ( CL_NUMBERS2.NUM=CL_ASSIGNED_NUMBERS2.NUM(+) )
  COUNT(*)
      8130
select count (*) from
CL_NUMBERS NO
LEFT OUTER JOIN CL_ASSIGNED_NUMBERS AS_NO ON (AS_NO.NUM = NO.NUM)
  4  LEFT OUTER JOIN CL_ASSIGNED_NUMBERS CONS ON (AS_NO.FURTHER_CONTACT_CAN_ID = CONS.FURTHER_CONTACT_CAN_ID)
  5  .
SQL> /
  COUNT(*)
     10268Can this be reduced to two tables (aliases) only? Or, which single table/alias produces the discrepancy?
Can either or both of NUM and FURTHER_CONTACT_CAN_ID in CL_NUMBERS be NULL, or FURTHER_CONTACT_CAN_ID in CL_ASSIGNED_NUMBERS be NULL?
If any of those columns on the LEFT side the OUTER JOIN can be NULL, can you wrap it/them with NVL(,0), and try both counts again, i.e.,
select count (*)
FROM
CALL_LOG.CL_ASSIGNED_NUMBERS  CL_ASSIGNED_NUMBERS2,
CALL_LOG.CL_NUMBERS  CL_NUMBERS2,
CALL_LOG.CL_ASSIGNED_NUMBERS  CL_FURTHER_CONTACTS
WHERE
( NVL(CL_ASSIGNED_NUMBERS2.FURTHER_CONTACT_CAN_ID,-9)=CL_FURTHER_CONTACTS.CAN_ID(+))
AND (NVL(CL_NUMBERS2.NUM,-9)=CL_ASSIGNED_NUMBERS2.NUM(+) )
select count (*) from
CL_NUMBERS NO
LEFT OUTER JOIN CL_ASSIGNED_NUMBERS AS_NO ON (NVL(AS_NO.NUM,-9) = NO.NUM)
LEFT OUTER JOIN CL_ASSIGNED_NUMBERS CONS ON (NVL(AS_NO.FURTHER_CONTACT_CAN_ID,-9) = CONS.FURTHER_CONTACT_CAN_ID)Assuming that both those columns are numeric, and that '-9' is not a valid value for those columns.
Edited by: SeanMacGC on Apr 8, 2009 12:34 PM