Updated records using Dynamic FORMS_DDL

Question

Hello everybody:
I need help for you guys. I'm working with Form9i and created a push button that when I press it, it should be updated some record depending of some conditions. I read that with dynamics FORMS_DDL, I can able to perform it, but when I put the below code in the “WHEN-BUTTON-PRESSED” trigger I get an “Error” that meaning that the forms was not success. Please, somebody tell me where is the error. Thanks.
if (:CONTROL_BTN.CHK_FINAL = 'N') then
     forms_ddl('update aapt_checklists
                                        set achk_reviewed_date = ' || :CONTROL_BTN.DATE_LETTER ||
' where achk_item in (select achk_item
                                        from aapt_checklists, aapt_reviews
                         where ' || :global.where_updated ||
' and achk_reviewed_date is null
and achk_1st_notification_date is null
and arev_seq = achk_arev_seq)     
and achk_1st_notification_date is null
and achk_reviewed_date is null');
end if;
if (form_success) then
     message('OK');
else     
message('Error');
end if;

Answer 1

You don't need dynamic SQL for that. Here is what you can do (Note the new v_fmt variable, and the update SQL below):
DECLARE
  def_where varchar2(500) := NULL;
  v_month varchar2(2)   := :CONTROL_BLOCK.Q_MONTH;
  v_day   varchar2(2)   := :CONTROL_BLOCK.Q_DAY;
  v_year  varchar2(4)   := :CONTROL_BLOCK.Q_YEAR;
  v_fmt   varchar2(10);
  v_date varchar2(20) := NULL;
PROCEDURE check_date (in_date IN varchar2) IS
  al_id     Alert;
  al_button Number;
  temp_date date := NULL;
BEGIN
  temp_date := to_date(in_date, 'MM/DD/YYYY');
EXCEPTION
  when others then
    al_id := Find_Alert('CFG_ERROR');
    Set_Alert_Property(al_id, alert_message_text, 'You have selected an Invalid Date');
    al_button := Show_Alert( al_id );
    raise FORM_TRIGGER_FAILURE;
END;
BEGIN
  -- Criteria entered as MM/DD/YYYY
  if (v_month <> '00') and (v_day <> '00') and (v_year <> '0000') then
    v_date := v_month||'/'||v_day||'/'||v_year;
    v_fmt  := 'MM/DD/YYYY';
    check_date (v_date);
  -- Criteria entered as MM/DD
  elsif (v_month <> '00') and (v_day <> '00') and (v_year = '0000') then
    v_date := v_month||'/'||v_day;
    v_fmt  := 'MM/DD';
    check_date (v_date||'/'||'2000'); -- Hardcoded 2000 to check all possible MM/DD combos including Leap Year
    def_where := ' to_char(arev_appl_received_date, ''MM/DD'') = ''' || v_date || '''';
  -- Criteria entered as MM/YYYY
  elsif (v_month <> '00') and (v_day = '00') and (v_year <> '0000') then
    v_date := v_month||'/'||v_year;
    v_fmt  := 'MM/YYYY';
    def_where := ' to_char(arev_appl_received_date, ''MM/YYYY'') = ''' || v_date || '''';
  -- Criteria entered as MM
  elsif (v_month <> '00') and (v_day = '00') and (v_year = '0000') then
    v_date := v_month;
    v_fmt  := 'MM';
    def_where := ' to_char(arev_appl_received_date, ''MM'') = ''' || v_date || '''';
  -- Criteria entered as DD/YYYY
  elsif (v_month = '00') and (v_day <> '00') and (v_year <> '0000') then
    v_date := v_day||'/'||v_year;
    v_fmt  := 'DD/YYYY';
    def_where := ' to_char(arev_appl_received_date, ''DD/YYYY'') = ''' || v_date || '''';
  -- Criteria entered as DD
  elsif (v_month = '00') and (v_day <> '00') and (v_year = '0000') then
    v_date := v_day;
    v_fmt  := 'DD';
    def_where := ' to_char(arev_appl_received_date, ''DD'') = ''' || v_date || '''';
  -- Criteria entered as YYYY
  elsif (v_month = '00') and (v_day = '00') and (v_year <> '0000') then
    v_date := v_year;
    v_fmt  := 'YYYY';
    def_where := ' to_char(arev_appl_received_date, ''YYYY'') = ''' || v_date || '''';
  end if;
  update aapt_checklists
    set achk_reviewed_date = :CONTROL_BTN.DATE_LETTER
    where achk_item in
    in (select achk_item
            from aapt_checklists, aapt_reviews
            where to_char(arev_appl_received_date,v_fmt) = v_date
                and achk_reviewed_date is null
                and achk_1st_notification_date is null
                and arev_seq = achk_arev_seq)
        and achk_1st_notification_date is null
        and achk_reviewed_date is null;
  --Condition for updated records in aapt.checklists table
  :global.where_updated := def_where;
  --Only when "INCOMPLETE - NEED ADD'L INFO" Status is selected
  def_where := def_where || ' and arev_status = 1427';
END;