Use of Semaphore in addition to db connection pool

Question

Hi,
I have a multi-threaded app, about 4 threads, reading from a local DB then pushing to a web service,
then writing a response back to the local DB. I'm using Commons DBCP with a size of 20.
Do you think there is any added benefit to using semaphore to safe-guard access to the DB pool?
Will this prevent any deadlocks in a more thorough manner?

Answer 1

iketurner wrote:
Yes,
after I am done with the connection I explicitly close it:
conn.closeThis should handle things for me.
I will add in the use of finally
Will this make a difference you think, even though I am using conn.close()?whenever you use a "resource" you should close it in a finally block. otherwise you can leak resources if you encounter problems (i.e. throw exception):
Connection c = null;
try {
  c = ...;
  // do something with c
} finally {
  if(c != null) {
    c.close();
}this is a must if you are using db connections, otherwise an exception thrown during the "do something with c" part will cause your connection to not be closed. then you would encounter problems later as all you run out of connections in your connection pool and your application hangs.