Using procedures

Question

I've got a problem. I have to make a procedure that will take a name as an input and then output the quaterly average sales for that customer. The customer name is in a seperate file to the sales details but these are linked by the customer_id. My code so far is below, its pretty simple but the problem is it never executes right and i don't get mush of an error response from the system.
create or replace procedure ORDER_AVG( aname IN VARCHAR2 )
as
begin
SELECT c.name CUSTOMER,
AVG(DECODE(TO_CHAR(order_date, 'Q'), 1, s.total, NULL)) qtr_1,
AVG(DECODE(TO_CHAR(order_date, 'Q'), 2, s.total, NULL)) qtr_2,
AVG(DECODE(TO_CHAR(order_date, 'Q'), 3, s.total, NULL)) qtr_3,
AVG(DECODE(TO_CHAR(order_date, 'Q'), 4, s.total, NULL)) qtr_4
from sales_order s, customer c
where c.name = 'aname' AND c.customer_id = s.customer_id
group by c.name;
end;

Answer 1

create or replace procedure ORDER_AVG( aname IN
VARCHAR2 )
as
begin
SELECT c.name CUSTOMER,
AVG(DECODE(TO_CHAR(order_date, 'Q'), 1,
'), 1, s.total, NULL)) qtr_1,
AVG(DECODE(TO_CHAR(order_date, 'Q'), 2,
'), 2, s.total, NULL)) qtr_2,
AVG(DECODE(TO_CHAR(order_date, 'Q'), 3,
'), 3, s.total, NULL)) qtr_3,
AVG(DECODE(TO_CHAR(order_date, 'Q'), 4,
'), 4, s.total, NULL)) qtr_4
from sales_order s, customer c
where c.name = 'aname' AND c.customer_id =
r_id = s.customer_id
group by c.name;
end;First of all, in a Procedure or Function body, you can not use the Select Statement like above. You shold have Select...INTO..FROM..WHERE(optional) instead.
Now let me try the following using your Code:
create or replace procedure ORDER_AVG( aname IN OUT VARCHAR2,
p_qtr1 OUT NUMBER, p_qtr2 OUT NUMBER, p_qtr3 OUT NUMBER, p_qtr4 OUT NUMBER )
as
begin
  SELECT c.name CUSTOMER,
  AVG(DECODE(TO_CHAR(order_date, 'Q'), 1,
'), 1, s.total, NULL)) qtr_1,
AVG(DECODE(TO_CHAR(order_date, 'Q'), 2,
'), 2, s.total, NULL)) qtr_2,
AVG(DECODE(TO_CHAR(order_date, 'Q'), 3,
'), 3, s.total, NULL)) qtr_3,
AVG(DECODE(TO_CHAR(order_date, 'Q'), 4,
'), 4, s.total, NULL)) qtr_4
INTO aname, p_qtr1, p_qtr2, p_qtr3, p_qtr4
       from sales_order s, customer c
where c.name = 'aname' AND c.customer_id =
r_id = s.customer_id
group by c.name;
end;Now use these OUT parameter values outside the procedure. Also don't use where cname = 'ename', use rather where cname = ename
Thanks
Message was edited by:
biswabijay
null