Using Xmlpath in query

Question

Version : 2008 R2
Hi,
Below is the test data and my query. Basically i am trying to get the File records along with if any error messages occurred. I am getting the output as expected but the message column has "," at the front and sometime at the end of the column. How
do i avoid that.
Also is there any better way to write this query? Any suggestion or correction please
declare @Files table (ID int identity(1,1) primary key,Filename varchar(50),Date_Created datetime)
insert into @Files (Filename,Date_Created)
select 'File1',GETDATE()-1 union all
select 'File2',GETDATE()-1 union all
select 'File3',GETDATE()-1 union all
select 'File4',GETDATE()-1 union all
select 'File5',GETDATE()-4 union all
select 'File6',getdate()-4;
declare @FilesLog table (IDLog int identity(1,1) primary key,
ID int,Message varchar(4000), Date_Created datetime);
insert into @FilesLog (ID,Message,Date_Created)
select 1,'',GETDATE()-1 union all
select 1,'Error:InvalidFile',GETDATE()-1 union all
select 1,'Error: Email is not valid',GETDATE()-1 union all
select 2,'Error:InvalidFile',GETDATE()-1 union all
select 2,'Error: Age is not valid',GETDATE()-1 union all
select 2,'Error: Salary is not valid',getdate()-1 union all
select 3,'',getdate()-3 union all
select 3,'',getdate()-4 ;
With CTE as (
SELECT id, message = STUFF((SELECT N', ' + message
FROM @FilesLog AS p2
WHERE p2.ID = p.id
FOR XML PATH(N'')), 1, 2, N'')
FROM @FilesLog AS p
where DATEDIFF(DD,GETDATE(),p.Date_Created) = -1 and Message is not null
GROUP BY id)
select F.ID,F.Filename,F.Date_Created,
case when message >'' then message
else 'no Issues' end as [Message] from
@Files F left join CTE C
on(F.ID = C.ID) where DATEDIFF(DD,GETDATE(),F.Date_Created) = -1 ;
loving dotnet

Answer 1

Version : 2008 R2
Hi,
Below is the test data and my query. Basically i am trying to get the File records along with if any error messages occurred. I am getting the output as expected but the message column has "," at the front and sometime at the end of the column. How
do i avoid that.
Also is there any better way to write this query? Any suggestion or correction please
declare @Files table (ID int identity(1,1) primary key,Filename varchar(50),Date_Created datetime)
insert into @Files (Filename,Date_Created)
select 'File1',GETDATE()-1 union all
select 'File2',GETDATE()-1 union all
select 'File3',GETDATE()-1 union all
select 'File4',GETDATE()-1 union all
select 'File5',GETDATE()-4 union all
select 'File6',getdate()-4;
declare @FilesLog table (IDLog int identity(1,1) primary key,
ID int,Message varchar(4000), Date_Created datetime);
insert into @FilesLog (ID,Message,Date_Created)
select 1,'',GETDATE()-1 union all
select 1,'Error:InvalidFile',GETDATE()-1 union all
select 1,'Error: Email is not valid',GETDATE()-1 union all
select 2,'Error:InvalidFile',GETDATE()-1 union all
select 2,'Error: Age is not valid',GETDATE()-1 union all
select 2,'Error: Salary is not valid',getdate()-1 union all
select 3,'',getdate()-3 union all
select 3,'',getdate()-4 ;
With CTE as (
SELECT id, message = STUFF((SELECT N', ' + message
FROM @FilesLog AS p2
WHERE p2.ID = p.id
FOR XML PATH(N'')), 1, 2, N'')
FROM @FilesLog AS p
where DATEDIFF(DD,GETDATE(),p.Date_Created) = -1 and Message is not null
GROUP BY id)
select F.ID,F.Filename,F.Date_Created,
case when message >'' then message
else 'no Issues' end as [Message] from
@Files F left join CTE C
on(F.ID = C.ID) where DATEDIFF(DD,GETDATE(),F.Date_Created) = -1 ;
loving dotnet
If you want to omit empty string messages, exclude those in the CTE subquery:
message = STUFF((SELECT N', ' + message
FROM @FilesLog AS p2
WHERE p2.ID = p.id
AND Message <> ''
FOR XML PATH(N'')), 1, 2, N'')
Dan Guzman, SQL Server MVP, http://www.dbdelta.com