What's the prob?

Question

hi all!..
i need ur help to solve this matter :)
i used to build a program:
1. create two arrays that can save data about 'name' dan 'salary' of lecturer.
2. user need to input data (name and salary).
3. create ascending sorting of the two arrays.
4. user also need to input which data they want to sort (by name or by salary).
the source code: (contains error)
import java.io.*;
class Array
     InputStreamReader a = new InputStreamReader(System.in);
     BufferedReader b = new BufferedReader(a);
     int i,j,choice;
     String name[]=new String[10];
     double salary[]=new double[10];
     void input()
          for (i=0;i<10;i++)
                    System.out.print("name[i] : ");
                    name=b.readLine() ;
                    for (i=i+1;i<10;i++)
                              System.out.println("salary : ");
                              salary[i]=Integer.parseInt(b.readLine());
                         System.out.println("salary ");
          System.out.print(name[i]);
          System.out.println("1: Sorting by name");
          System.out.println("2: Sorting by salary");
          System.out.println("Your choice:");
          pilihan=Integer.parseInt(b.readLine());
     void sorting()
          if(choice==1)
               for(i=0;i<10;i++)
                    for(j=i+1;j<10;j++)
                         if(name[i].compareTo(name[j])<=0)
                              String temp=name[i];
                              name[i]=name[j];
                              name[j]=temp;
               System.out.println(name[i]);
          else if(choice==2)
               for(i=0;i<10;i++)
                    for(j=i+1;j<10;j++)
                         if(salary[j].compareTo(salary[i])<=0)
                         double temp=salary[i];
                              salary[i]=salary[j];
                              salary[j]=temp;
               System.out.println(salary[i]);
          else
               System.out.println("Wrong choice!");
     void output()
          System.out.println(" "+name);
          System.out.println(" "+salary);
     public static void main(String arg[])
          Array z=new Array();
          z.input();
          z.sorting();
          z.output();

Answer 1

Hi ,
I have compiled and run the program for you. But it has got design flaws. I can assume that you might be looking for sorting the name and salray for empolyees. But the current design takes name and salary array in two different arrays.
import java.io.*;
import java.util.Arrays;
public class EmpArray
     InputStreamReader a = new InputStreamReader(System.in);
     BufferedReader b = new BufferedReader(a);
     int i,j,choice;
     String name[]=new String[10];
     double salary[]=new double[10];
     private void input()
          try
               for (i=0;i<10;i++)
                    System.out.print("name : ");
                    name=b.readLine() ;
                    System.out.println("salary : ");
                    salary[i]=Double.parseDouble(b.readLine());
               System.out.println("1: Sorting by name");
               System.out.println("2: Sorting by salary");
               System.out.println("Your choice:");
               choice=Integer.parseInt(b.readLine());
          }catch(Exception e)
               System.out.println(" error"+ e.getMessage());
     private void sorting()
               if(choice==1)
                    Arrays.sort(name);
                    System.out.println("Sorted names are ");
                    for (i=0;i<10;i++)
                         System.out.println(name[i]);
               else if(choice==2)
                    Arrays.sort(salary);
                    System.out.println("Sorted salaries are ");
                    for (i=0;i<10;i++)
                         System.out.println(salary[i]);
               else
               System.out.println("Wrong choice!");
     private void output()
                    for (i=0;i<10;i++)
                         System.out.println(name[i]);
                         System.out.println(salary[i]);
     public static void main(String arg[])
               EmpArray z=new EmpArray();
               z.input();
               z.sorting();
               z.output();