Error in the proc which has dynamic query in it.

Question

I have a proc as below
create or replace procedure dynamic_Sql
(id in number,
obj_id in number,
id2);
is
xxxx varchar2(30);
sql_stmt1 VARCHAR2(10000);
cusor c is select distinct dep from department where dept_id = 10;
Beign
select table_name into xxxx from tableq;
for cur in c loop
sql_stmt1:= 'insert into node(NODE_ID,pID,dep,tnode,PNODE)
select id,pid2,cur.dep,null,null)
from tablex h
where h.hid = id2
and h.dep = cur.dep)';
end loop;
execute immediate sql_stmt1;
end;
Here when i execute it is giving the error in 'id2' which is paased as the parameter in this proc and "cur.dep" which is comming from the cursor. It giving n error 'id2' and "cur.dep" is an invalid identifier
Edited by: user10285699 on May 1, 2009 1:09 AM

Answer 1

Your code is faulty.
First of all you set up multiple statements in a cursor for loop, and you execute that statement outside the cursor for loop. So only 1 statement is executed.
Secondly, you can't refer to pl/sql variables in a dynamic sql statement or you must use them as bind variables (preferred) or concatenate them.
1 bind variables.
sql_stmt1:= 'insert into node(NODE_ID,pID,dep,tnode,PNODE)
select id,pid2,cur.dep,null,null)
from tablex h
where h.hid = :id2
and h.dep = :dep';
execute immediate sql_stmt1 using id2, cur.dep;
end loop;
2 concatenation.
sql_stmt1:= 'insert into node(NODE_ID,pID,dep,tnode,PNODE)
select id,pid2,cur.dep,null,null)
from tablex h
where h.hid = '||id2
and h.dep = '||cur.dep||')';
execute immediate sql_stmt1 using id2, cur.dep;
end loop;
Sybrand Bakker
Senior Oracle DBA