Any comments about this code regaarding naming conventions and flow and e

Question

CREATE OR REPLACE PACKAGE SEODS02.ODS_APPEND_REPLACE
AS
/* Description : This procedure will start the process step for moving
data from staging to live table for Append and Replace paradigms
/**************** Change History ***********************************/
/* Date Version Author Description */
-- Global Specifications.
package_name_in VARCHAR2(50) :='ODS_APPEND_REPLACE';
v_location INTEGER := 10;
v_cntl_schema VARCHAR2(20):= 'SCNTL02';
-- Procedure Specifications.
PROCEDURE APPEND_REPLACE_INSERT (job_name_in IN VARCHAR2,
schema_name_in IN VARCHAR2,
proc_cd_in IN VARCHAR2,
proc_step_cd_in IN VARCHAR2,
bch_dte_in IN DATE,
fl_nbr_in IN VARCHAR2,
verbose_log_flag_in IN INTEGER,
pred_check_req_in IN INTEGER,
error_code_1_in IN VARCHAR2,
ibd_id_in IN INTEGER,
proc_step_status_out OUT INTEGER,
sp_hier_inout IN OUT VARCHAR2);
PROCEDURE APPEND_EXPOSE (job_name_in IN VARCHAR2,
schema_name_in IN VARCHAR2,
proc_cd_in IN VARCHAR2,
proc_step_cd_in IN VARCHAR2,
bch_dte_in IN DATE,
data_grp_cde_in IN VARCHAR2,
verbose_log_flag_in IN INTEGER,
pred_check_req_in IN INTEGER,
ibd_id_in IN INTEGER,
proc_step_status_out OUT INTEGER,
sp_hier_inout IN OUT VARCHAR2);
END ODS_APPEND_REPLACE;
CREATE OR REPLACE
PACKAGE BODY SEODS02.ODS_APPEND_REPLACE
AS
PROCEDURE APPEND_REPLACE_INSERT (job_name_in IN VARCHAR2,
schema_name_in IN VARCHAR2,
proc_cd_in IN VARCHAR2,
proc_step_cd_in IN VARCHAR2,
bch_dte_in IN DATE,
fl_nbr_in IN VARCHAR2,
verbose_log_flag_in IN INTEGER,
pred_check_req_in IN INTEGER,
error_code_1_in IN VARCHAR2,
ibd_id_in IN INTEGER,
proc_step_status_out OUT INTEGER,
sp_hier_inout IN OUT VARCHAR2)
AS
/* Local Variables Declaration*/
v_curr_date DATE := CURRENT_DATE;
v_procedure_name VARCHAR2(100):= 'APPEND_REPLACE_INSERT';
v_stg_tbl VARCHAR2(100);
v_act_tbl VARCHAR2(100);
v_whr_clause_out VARCHAR2(1000);
option_in VARCHAR2(30);
v_common_col_list VARCHAR2(10000);
v_stg_col_list VARCHAR2(10000);
v_act_col_list VARCHAR2(10000);
v_query VARCHAR2(10000);
v_thrshld_query VARCHAR2(10000);
v_actl_inpt_query VARCHAR2(10000);
v_proc_step_stat_query VARCHAR2(10000);
v_error_msg_in VARCHAR2(10000);
v_part_val_out INTEGER;
v_row_cnt NUMBER(10);
v_cmit_nbr NUMBER(10);
v_actl_inpt_cnt NUMBER(10);
v_rec_inserted_cnt NUMBER(10);
v_rec_errored_cnt NUMBER(10);
v_thrshld_nbr NUMBER(10);
v_data_grp_query VARCHAR2(10000);
v_data_grp_cde VARCHAR2(30);
v_proc_step_upd_out NUMBER(1);
proc_step_start_out NUMBER(1);
proc_step_status VARCHAR2(30);
handled_exception EXCEPTION;
BEGIN
/* Enable the logging if verbose log flag is 0*/
IF verbose_log_flag_in = 0 THEN
DBMS_OUTPUT.ENABLE();
ELSE
DBMS_OUTPUT.DISABLE();
END IF;
/* Start the Append/Replace Update process step after all the predecessor process steps are complete */
ODS_CONTROL_UTILITY.PROC_STEP_START( proc_cd_in => proc_cd_in,
proc_step_cd_in => proc_step_cd_in,
ibd_id_in => ibd_id_in,
bch_dte_in => bch_dte_in,
job_name_in => job_name_in,
verbose_log_flag_in => verbose_log_flag_in,
pred_chk_reqd_in => pred_check_req_in,
proc_step_stat_out => proc_step_start_out,
sp_hier_inout => sp_hier_inout);
IF proc_step_start_out = 0 THEN
dbms_output.put_line('Process Step '|| proc_step_cd_in ||' started for Process '||proc_cd_in);
/*If process step is successfully started then get the active and stage table names */
ODS_CONTROL_UTILITY.GET_TABLE_NAME( proc_cd_in => proc_cd_in,
proc_step_in => proc_step_cd_in,
ibd_id_in => ibd_id_in,
actv_tbl_out => v_act_tbl,
stg_tbl_out => v_stg_tbl,
sp_hier_inout => sp_hier_inout);
IF v_act_tbl IS NULL THEN
v_error_msg_in := 'Active table name is null. Please check the parameters passed';
option_in := 'others';
RAISE handled_exception;
/* If Active table is not null then get the active partition of the table*/
ELSE
dbms_output.put_line('Active table name is : '||v_act_tbl);
v_data_grp_query := 'SELECT data_grp_cde
FROM '||v_cntl_schema ||'.proc
WHERE proc_id = '||chr(39)||proc_cd_in ||chr(39)||
' AND ibd_id = '||ibd_id_in;
EXECUTE IMMEDIATE v_data_grp_query INTO v_data_grp_cde;
ODS_CONTROL_UTILITY.GET_ACT_PART(tbl_name_in => v_act_tbl,
data_grp_cde_in => v_data_grp_cde,
meta_data_in => 'VIEW DYN METADATA',
part_val_out => v_part_val_out,
sp_hier_inout => sp_hier_inout);
IF v_part_val_out IS NULL THEN
v_error_msg_in := 'Incorrect table name ' || v_act_tbl;
option_in := 'others';
v_location := 20;
RAISE handled_exception;
END IF;
dbms_output.put_line('Active partition for the table '|| v_act_tbl ||' is : '||v_part_val_out);
/*Get the list of active table columns*/
ODS_APPLICATION_UTILITY.GET_TAB_COLS (schema_name_in => schema_name_in,
table_name_in => v_act_tbl,
col_name_out => v_act_col_list,
sp_hier_inout => sp_hier_inout);
v_act_col_list := SUBSTR(v_act_col_list,1,LENGTH(v_act_col_list)-1);
IF v_act_col_list IS NULL THEN
v_error_msg_in := 'Failed fetching columns for ' || v_act_tbl || '. Check for the columns in table name';
option_in := 'others';
v_location := 30;
RAISE handled_exception;
/*Get the list of active table columns and concatenate the columns with 'stg_array(i)' */
ELSE
dbms_output.put_line('Active Table Columns List: '||v_act_col_list);
ODS_APPLICATION_UTILITY.GET_TAB_COLS (schema_name_in => schema_name_in,
table_name_in => v_act_tbl,
identifier_name_in => 'stg_array(i)',
col_name_out => v_common_col_list,
sp_hier_inout => sp_hier_inout);
v_common_col_list := SUBSTR(v_common_col_list,1,LENGTH(v_common_col_list)-1);
IF v_common_col_list IS NULL THEN
v_error_msg_in := 'Failed fetching columns for ' || v_act_tbl || ' and get concatenated with ' || 'STTG_ARRAY' ||'. Check for the columns in table name';
option_in := 'others';
v_location := 40;
RAISE handled_exception;
ELSE
ODS_APPLICATION_UTILITY.GET_TAB_COLS (schema_name_in => schema_name_in,
table_name_in => v_stg_tbl,
col_name_out => v_stg_col_list,
sp_hier_inout => sp_hier_inout);
v_stg_col_list := SUBSTR(v_stg_col_list,1,LENGTH(v_stg_col_list)-1);
IF v_stg_col_list IS NULL THEN
v_error_msg_in := 'Failed fetching columns for ' || v_stg_tbl || '. Check for the columns in table name';
option_in := 'others';
v_location := 50;
RAISE handled_exception;
ELSE
/* Form the WHERE clause on the primary key columns to update the proc_flag
column of appropriate record in stage table */
ODS_APPLICATION_UTILITY.GET_WHERE_CLAUSE( schema_nme_in => schema_name_in,
tbl_nme_in => v_stg_tbl,
trg_id => 'stg_array(i)',
whr_clause_out => v_whr_clause_out,
sp_hier_inout => sp_hier_inout);
IF v_whr_clause_out IS NULL THEN
v_error_msg_in := 'No columns fetched for ' || v_stg_tbl || '. Check for the columns in table name';
option_in := 'others';
v_location := 60;
RAISE handled_exception;
ELSE
dbms_output.put_line('Where Clause is : ' || v_whr_clause_out );
v_thrshld_query := 'SELECT proc_step_thrshld_nbr FROM '|| v_cntl_schema ||'.proc_step
WHERE proc_id = '|| chr(39) ||proc_cd_in|| chr(39) ||
' AND proc_step_cde = '|| chr(39) ||proc_step_cd_in|| chr(39) ||
' AND ibd_id = ' || ibd_id_in;
EXECUTE IMMEDIATE v_thrshld_query INTO v_thrshld_nbr;
dbms_output.put_line('Threshold number for the process step '||proc_step_cd_in||' is '||v_thrshld_nbr||' for the process '||proc_cd_in);
END IF;
END IF;
END IF;
END IF;
END IF;
v_query := 'SELECT proc_cmit_nbr FROM '||v_cntl_schema||'.proc
WHERE proc_id = '|| chr(39) || proc_cd_in || chr(39) ||
' AND ibd_id = '|| ibd_id_in;
EXECUTE IMMEDIATE v_query INTO v_cmit_nbr;
IF v_part_val_out = 999 THEN
/* Execute the dynamic pl/sql block to append the data to the active table*/
dbms_output.put_line('Executing Dynamic Insert Block for Append Paradigm');
dbms_output.put_line('--------------------------------------------------');
v_location := 80;
EXECUTE IMMEDIATE q'{
DECLARE
v_rec_inserted_cnt_in NUMBER(10):=0;
error_msg_in VARCHAR2(1000);
v_dyn_proc_step_upd_out NUMBER(1);
v_rec_updt_cnt_in NUMBER(10):=0;
v_actl_inpt_cnt NUMBER(10):=0;
v_rec_errored_cnt_in NUMBER(10):=0;
v_dyn_option_in VARCHAR2(30);
v_dyn_sp_hier VARCHAR2(30);
v_dyn_handled_exception EXCEPTION;
v_dyn_verbose_flag NUMBER(1):=0;
CURSOR c IS
SELECT }' || v_stg_col_list ||
' FROM ' || v_stg_tbl ||
' WHERE fl_nbr = ' || fl_nbr_in ||
' AND proc_flag = ' || chr(39) || 'N' || chr(39) ||
' AND to_date(bch_dte,'||CHR(39)||'DD-MON-YY'||CHR(39)||') <= '||CHR(39)|| bch_dte_in || CHR(39)||q'{;
TYPE array IS TABLE OF c%ROWTYPE;
stg_array array;
BEGIN
/* Enable the logging if verbose log flag is 0*/
IF v_dyn_verbose_flag = }' || verbose_log_flag_in || q'{ THEN
DBMS_OUTPUT.ENABLE();
END IF;
OPEN c;
LOOP
FETCH c BULK COLLECT INTO stg_array LIMIT }'|| v_cmit_nbr ||q'{;
FOR i IN 1..stg_array.COUNT LOOP
BEGIN
INSERT INTO }' || schema_name_in || q'{.}'|| v_act_tbl || q'{( }'|| v_act_col_list ||q'{,crte_pgm, updt_pgm, crte_tstp, updt_tstp, expsd_rec_ind) VALUES }' || q'{ ( }' || v_common_col_list || q'{,'}' || job_name_in || q'{','}' || job_name_in ||q'{','}' || v_curr_date ||q'{','}' || v_curr_date||q'{','N' );}' ||
q'{
v_rec_inserted_cnt_in := v_rec_inserted_cnt_in + 1 ;
v_actl_inpt_cnt := v_actl_inpt_cnt + 1 ;
error_msg_in := 'Error in updating PROC_STAT as inserted';
UPDATE }' || schema_name_in || q'{.}' || v_stg_tbl || q'{
SET proc_flag = 'I' ,
updt_pgm = '}' || job_name_in || q'{',
updt_tstp = '}' || v_curr_date || q'{'
WHERE }'|| v_whr_clause_out ||q'{;
EXCEPTION
WHEN DUP_VAL_ON_INDEX THEN
error_msg_in := 'Record duplicated';
v_actl_inpt_cnt := v_actl_inpt_cnt + 1 ;
v_rec_errored_cnt_in := v_rec_errored_cnt_in + 1;
IF v_rec_errored_cnt_in >}' || v_thrshld_nbr || q'{ THEN
error_msg_in := 'Threshold limit }' || v_thrshld_nbr || q'{ Reached';
v_dyn_option_in := 'proc_step';
RAISE v_dyn_handled_exception;
ELSE
error_msg_in := 'Error in updating PROC_STAT as error';
UPDATE }' || schema_name_in || q'{.}' || v_stg_tbl || q'{
SET proc_flag = 'E',
-- err_code = }' || error_code_1_in || q'{, --need to uncomment once the err_code column is created in stage table
updt_pgm = '}' || job_name_in || q'{',
updt_tstp = '}' || v_curr_date || q'{'
WHERE }'|| v_whr_clause_out ||q'{;
END IF;
END;
END LOOP;
EXIT WHEN c%NOTFOUND;
END LOOP;
CLOSE c;
ND ODS_APPEND_REPLACE;
/

Answer 1

DUPLICATE
Any suggestions about this program to improve performance and effective cod