Applescript for creating job folders

Question

having trouble with an applescript. I'm trying to create an applescript that will create a job folder for me with job number and job name in which I can include folders and subfolders.
I found this script by searching google and it's pretty much what I need (thank you to who ever might have created it). I altered the folder names to what I need, and it seems to work for the most part but throws an error at the end that says : Finder got an error: Can't make "drive:path" into type item
however it still makes everything i need. I would just like to get rid of the error.
the script editor highlights the line of text that's having issues for me, but since i barely knew what I was doing in the first place I don't know how or what to change.
if someone could help me that would be great. here is the code.
set thepath to {"drive:path"}
set JobName to text returned of (display dialog "Please enter Job Name:" default answer "Job Name")
set incomingDate to (current date)
set numYear to year of incomingDate as number
set textYear to text -2 through -1 of (numYear as string)
set JobNum to text returned of (display dialog "Please enter Job Number:" default answer {textYear & "xxx"})
set JobNumName to JobNum & "_" & JobName
set newsublist to {{"Builds", {"versions"}}, {"Links"}, {"Fonts"}, {"Proofs"}}
tell application "Finder"
set baseFolder to make new folder with properties {name:JobNumName}
repeat with i from 1 to count newsublist
try
set {tier2, t2Subs} to {item 1, item 2's items} of item i of newsublist
set tier2Folder to make new folder at baseFolder with properties {name:(tier2)}
repeat with tier3 in t2Subs
make new folder at tier2Folder with properties {name:(tier3)}
end repeat
on error
make new folder at baseFolder with properties {name:(item 1 of item i of newsublist)}
end try
end repeat
activate
open thepath
end tell

Answer 1

There are a few differences with Leopard that still get me from time to time. Tiger's AppleScript doesn't like path to desktop, so instead use the statement:
set ThePath to (get path to desktop folder)
The other thing I hadn't noticed before is if there is an error, the script just stops instead of throwing up a dialog. If you are doing something like using an illegal file name or trying to create a folder in a location that you don't have permissions, then unless the MakeFolderStructure statement is in a try statement it will fail silently. Adding an error display will at least tell you if there is an error, so a script that works in Tiger (as well as Leopard) is:
<pre style="
font-family: Monaco, 'Courier New', Courier, monospace;
font-size: 10px;
margin: 0px;
padding: 5px;
border: 1px solid #000000;
width: 720px; height: 340px;
color: #000000;
background-color: #FFDDFF;
overflow: auto;"
title="this text can be pasted into the Script Editor">
-- make a folder structure at the currently selected Finder item
tell application "Finder" to try -- get the current selection
set ThePath to the first item of (get selection)
if the last character of (ThePath as text) is not ":" then -- a file
set ThePath to the container of ThePath
end if
on error -- default to the desktop
set ThePath to (get path to desktop folder)
end try
set JobName to text returned of (display dialog "Please enter Job Name:" default answer "Job Name")
set textYear to text -2 through -1 of ((current date)'s year as text)
set JobNum to text returned of (display dialog "Please enter Job Number:" default answer {textYear & "xxx"})
set JobNumName to JobNum & "_" & JobName
try
MakeFolderStructure out of {JobNumName, {"Builds", {"versions"}, "Links", "Fonts", "Proofs"}} at ThePath
on error ErrorMessage number ErrorNumber -- oops
activate me
display alert "Error " & ErrorNumber message ErrorMessage
end try
to MakeFolderStructure out of SomeItem at SomeFolder
make the folder structure defined in SomeItem at SomeFolder
SomeList defines the structure:
nested list items create folders in the previous text item - {"A", {"B", {"C"}}} = /A/B/C
empty text items will create untitled folders
parameters - SomeItem [mixed]: the folder structure
SomeFolder [alias]: the destination folder
returns nothing
set ParentFolder to SomeFolder
if class of SomeItem is list then
repeat with AnItem in SomeItem
if class of AnItem is list then -- add subfolder(s)
MakeFolderStructure out of AnItem at SomeFolder
else -- add a new child folder at the current parent
tell application "Finder" to make new folder at ParentFolder with properties {name:AnItem}
set SomeFolder to the result as alias
end if
end repeat
else -- add a new (potential) parent folder
tell application "Finder" to make new folder at SomeFolder with properties {name:AnItem}
set ParentFolder to the result as alias
end if
end MakeFolderStructure</pre>