ArrayIndexOutOfBoundsException, Response.parseString

Question

java.lang.ArrayIndexOutOfBoundsException
     at com.sun.mail.iap.Response.parseString(Response.java:391)
     at com.sun.mail.iap.Response.readString(Response.java:320)
     at com.sun.mail.imap.protocol.ENVELOPE.<init>(ENVELOPE.java:96)
     at com.sun.mail.imap.protocol.FetchResponse.parse(FetchResponse.java:127)
     at com.sun.mail.imap.protocol.FetchResponse.<init>(FetchResponse.java:63)
     ...Take a look at Response.java
     b = buffer[index];
     if (b == '"') { // QuotedString
          index++; // skip the quote
          int start = index;
          int copyto = index;
          while ((b = buffer[index]) != '"') {     *** LINE 391
     }               We iincrement index, and try to read from buffer without any size checks.
    index++; // skip the quote
    while ((b = buffer[index]) != '"') {
{code}
So if the quoted string was bad formed, e.g. it terminated right after '"', then we would get ArrayIndexOutOfBoundsException error. While comments state that in case of any error it should return 'null' value instead./**
* Generic parsing routine that can parse out a Quoted-String,
* Literal or Atom and return the parsed token as a String
* or a ByteArray. Errors or NIL data will return null.
private Object parseString(boolean parseAtoms, boolean returnString) {
Notice, that the same issues can be seen in other places. E.g. in following code we can easy go out of bounds if string has no '}'.while (buffer[index] != '}')
index++;
Whould be great it this code can be reviewed and fixed :-)
Regards,
  - Alex                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           

Answer 1

Hello you who are still alive here,
2 years have passed and I tried playing with javax.mail 1.4.6-rc1 (along with gimap 1.4.6-rc1).
The issue appeared for my GMail account while I was trying to test the library.
bshannon wrote:
If anyone is still seeing this exception, I'd love to get the details so I can pass them on to
Google so they can fix this bug in Gmail.
Thanks.buffer seems to contain:
* * 6606 FETCH (X-GM-LABELS ("\Importantt" Notifications "\\Starred"))
(the rest of buffer is filled with \0, the HTMLiser of the forum seems to break the string quoted here, the actual buffer is:
[42, 32, 54, 54, 48, 54, 32, 70, 69, 84, 67, 72, 32, 40, 88, 45, 71, 77, 45, 76, 65, 66, 69, 76, 83, 32, 40, 34, 92, 73, 109, 112, 111, 114, 116, 97, 110, 116, 116, 34, 32, 78, 111, 116, 105, 102, 105, 99, 97, 116, 105, 111, 110, 115, 32, 34, 92, 92, 83, 116, 97, 114, 114, 101, 100, 34, 41, 41, 13, 10, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]
After some tests, it appears this is related to the fact that I attempt to fetch:
fp.add(GmailFolder.FetchProfileItem.LABELS);From my INBOX.
Let me know if I can be of some help.
Cheers,
Pierre.