BAdI code review - for perfomance improvements

Hi,
I've a BAdI implementation to enhance a BW datasource which will extract additional fields for the datasource. The pseudo code for the extractor is as below. Can some one please review and let me know the opportunities (which I'm sure there will be) to improve the performance of the BAdI?
Thanks a lot.
Regards,
Sri.
Pseudo Code:
loop at ct_data assigning <ls_data>.
case <on_a_field>.
    when <value_1>.
       if <condition1>.
       elseif<condition2>.
       elseif<condition3>.
       endif.
    when <value_2>.
       <execute a function module by exporting value_2>
       if <condition1>.
       elseif<condition2>.
       elseif<condition3>.
       endif.
endcase.
<extraction logic for other fields continue>
endloop.

Hi
Two suggestions:
First, use tcode ST05 to do traces and diagnose the bottleneck.
Second, tcode ABAP_TRACE, go to tips and tricks, and in internal tables / using the assigning command see samples and run them to evaluate the times. But in my opinion you are doing well.
I hope this helps you
Regards
Eduardo

Similar Messages

Code Reviewer for OAF Code

Hi All,
Do we have a code review tool specially for OAF code something like JSTYLE is for java.
Is there something specific to OAF or JSTYLE is ok to sue for OAF Code.
Thanks,
Arati

Is there any tool for security review too for OAF

Code review for new coldfusion developer

Hello all, my name's Oscar, and I've just created a little coldfusion framework for work to help us with some of our "legacy" systems (which all use a cms that bakes it's output.) And as I'm fairly new to coldfusion I wanted to see if you would mind quickly casting your eyes over what I've got and helping me improve my work with some of your hard earned experience.
Everything I've got I've open sourced, and I've written an example application / readme with details about how to install it incase you want to try it out on your own system. I've a background in ruby, python, and php; so I've borrowed some conventions from frameworks like django and rails as I was building this, as well as dipping heavily into coldbox to get a better understanding of how to structure my cfml code.
Here's the main repository for the project: https://github.com/binaryvision/pistachio.

Hello all, my name's Oscar, and I've just created a little coldfusion framework for work to help us with some of our "legacy" systems (which all use a cms that bakes it's output.) And as I'm fairly new to coldfusion I wanted to see if you would mind quickly casting your eyes over what I've got and helping me improve my work with some of your hard earned experience.
Everything I've got I've open sourced, and I've written an example application / readme with details about how to install it incase you want to try it out on your own system. I've a background in ruby, python, and php; so I've borrowed some conventions from frameworks like django and rails as I was building this, as well as dipping heavily into coldbox to get a better understanding of how to structure my cfml code.
Here's the main repository for the project: https://github.com/binaryvision/pistachio.

A new dilema, code review for newbie

OK, now my dilema is taking input values from an applet and working them into my methods. I have read several tutorials, but I'm not finding any help. So far, I have written this code which does not complie (as expected). My methods seem solid, but my integration of the methods into an applet is far from decent. I have a feeling that I'm just going in circles here.
package membership;
import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import java.lang.String;
public class MemberFee extends JApplet
String typeMem;
char memType;
int numKids,
numYears;
double memFee,
kFee,
iFee,
fFee,
totalFee;
boolean endProgram = false;
//DecimalFormat twoDigit = new DecimalFormat("0.00"); //page 171-172 in New Dietel Book
public void init ()
while (!typeMem == 'Q')
memType = JOptionPane.showInputDialog("Enter Type of Member: ");
typeMem = memType.charAt (0);
typeMem = Character.toUpperCase(typeMem);
if (typeMem == 'F')
numYears = JOptionPane.showInputDialog("Enter number of years:");
if(numYears<0)
JOptionPane.showMessageDialog(null,"Enter a positive value", "You have made an error", JOptionPane.ERROR_MESSAGE);
numKids = JOptionPane.showInputDialog("Enter number of kids:");
if(numKids<0)
JOptionPane.showMessageDialog(null,"Enter a positive value", "You have made an error", JOptionPane.ERROR_MESSAGE);
else
memFee = fFee;
JOptionPane.showMessageDialog (null, "Type of Member: " + "Years" +
"\nnumKids: " + (numKids) +
"\nnumYears: " + (numYears),
"Total", JOptionPane.PLAIN_MESSAGE);
else if (typeMem =='I')
numYears = JOptionPane.showInputDialog("Enter number of years:");
if(numYears<0)
JOptionPane.showMessageDialog(null,"Enter a positive value", "You have made an error", JOptionPane.ERROR_MESSAGE);
else
memFee = iFee;
JOptionPane.showMessageDialog (null, "Type of Member: " + "Years" +
"\nnumYears: " + (numYears),
"Total", JOptionPane.PLAIN_MESSAGE);
JOptionPane.showMessageDialog(null,JOptionPane.showMessageDialog (null, "Type of Member: " + "Years" +
"\nnumKids: " + (numKids) +
"\nnumYears: " + (numYears),
"Total", JOptionPane.PLAIN_MESSAGE));
}//end if
}//end while
//begin methods
//fee for individual method
public static double iFee(int numYears)
double memFee;
if (numYears >= 2)
memFee = 1500.00;
else
memFee = 1900.00;
return memFee;
// end individual method
//fees for family method
public static double fFee (int numYears, int numKids)
double memFee;
double kFee;
if (numKids <= 2)
kFee = 0.00 ;
else
kFee = (numKids * 250.00);
//end kids calculation
if (numYears >= 2)
memFee =2500.00;
else
memFee= 3000.00 + kFee;
return memFee;
//end family method
This is what I think my problems are:
1. I am confusing java application commands with java applet commands (shouldn't they be similar?)
2. Can applets even allow for pop up dialog boxes?
This problem keeps me up at night. Any help would be great.
THanks,

Hi,
probably you need learn more Java and start with small examples. I kind of fixed the compilation errors, but I don't know what the output might be. good luck.
import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import java.lang.String;
public class MemberFee extends JApplet
     String typeMem;
     String memType;
     int numKids,
     numYears;
     double memFee,
     kFee,
     iFee,
     fFee,
     totalFee;
     boolean endProgram = false;
     //DecimalFormat twoDigit = new DecimalFormat("0.00"); //page 171-172 in New Dietel Book
     public void init ()
     while (!typeMem.equals("Q"))
     memType = JOptionPane.showInputDialog("Enter Type of Member: ");
     typeMem = memType.substring(0,0);
     typeMem = typeMem.toUpperCase();
     if (typeMem.equals("F"))
     numYears = Integer.parseInt(JOptionPane.showInputDialog("Enter number of years:"));
     if(numYears<0)
     JOptionPane.showMessageDialog(null,"Enter a positive value", "You have made an error", JOptionPane.ERROR_MESSAGE);
     numKids = Integer.parseInt(JOptionPane.showInputDialog("Enter number of kids:"));
     if(numKids<0)
     JOptionPane.showMessageDialog(null,"Enter a positive value", "You have made an error", JOptionPane.ERROR_MESSAGE);
     else
     memFee = fFee;
     JOptionPane.showMessageDialog (null, "Type of Member: " + "Years" +
     "\nnumKids: " + (numKids) +
     "\nnumYears: " + (numYears),
     "Total", JOptionPane.PLAIN_MESSAGE);
     else if (typeMem.equals("I"))
     numYears = Integer.parseInt(JOptionPane.showInputDialog("Enter number of years:"));
     if(numYears<0)
     JOptionPane.showMessageDialog(null,"Enter a positive value", "You have made an error", JOptionPane.ERROR_MESSAGE);
     else
     memFee = iFee;
     JOptionPane.showMessageDialog (null, "Type of Member: " + "Years" +
     "\nnumYears: " + (numYears),
     "Total", JOptionPane.PLAIN_MESSAGE);
     JOptionPane.showMessageDialog (null, "Type of Member: " + "Years" +
     "\nnumKids: " + (numKids) +
     "\nnumYears: " + (numYears),
     "Total", JOptionPane.PLAIN_MESSAGE);
     }//end if
     }//end while
     //begin methods
     //fee for individual method
     public static double iFee(int numYears)
     double memFee;
     if (numYears >= 2)
     memFee = 1500.00;
     else
     memFee = 1900.00;
     return memFee;
     // end individual method
     //fees for family method
     public static double fFee (int numYears, int numKids)
     double memFee;
     double kFee;
     if (numKids <= 2)
     kFee = 0.00 ;
     else
     kFee = (numKids * 250.00);
     //end kids calculation
     if (numYears >= 2)
     memFee =2500.00;
     else
     memFee= 3000.00 + kFee;
     return memFee;
//end family method

Code Review Tools for Enhancements

Friends,
I have to perform code review for enhancement objects. I am aware of tools like Code Inspector (SCI Tcode) and SE30. These tools can be used for reports, function modules.
I would like to know if these tools can be used for enhancements or are there some other tools available?
Thanks and Regards.

Hi
can you work on :
1) ST05 Performance Trace
2) ST03G Global Statistical Records
STAD Statistical Records
3) ST30 Global Performance Analysis
thnak you
srinu

Oracle Apps secure code review

Is any documentation available (either Oracle or third party based) to guide secure code reviews for Oracle Apps (or more specifically, Oracle Application Framework)?
I'm aware of the usual sql injection bad practices (as related to JDBC and PLSQL). I'm curious about API abuse, as related to:
- cross-site scripting concerns
- client-side trust issues (e.g., hidden field values)
- improper or inconsistent input validation
- improper error handling
- improper session management
- inappropriate access control
Thanks.

Thanks... I looked at that and didn't think it was all in there, but I looked again after I got your reply and it appears to be what we are looking for (at least a starting point).

Code Review:: ADF BC applications

Hi,
We would like to know if there's any open source software available for code reviews of ADF applications and how to effectively use to for ADF BC applications?
1) Am I moving in right direction while exploring PMD and Checkstyle? Are these the right candidates for setting automated code reviews for ADF applications?
Is there a specific software recommendation by the forum members which can help me achieve this goal.
2) Can CodeCoach and Audit features available in JDeveloper help me in this?
3) Will I have to necessary create 'Custom Rules' for tasks like validating EO classes are not directly referred in the Controller? Are there some pre-built rule-sets available on this front?
4) Any other suggestions for ensuring better/faster code reviews not necessarily replacing the manual peer review process but reducing the unnecessary headaches that can be fixed by freely available software
Sid

I started using ADFLogger and added some log statements. When I ran my application in JDeveloper in Embeded OC4J server, these log statements are appearing in JDeveloper server log window. After I deployed this application to Oracle Application Server, these statements are not appearing in the application.log file and also not in any file. Am I missing any configuration setting? The log current level is INFO and I do have few INFO statements, SEVERE statements in my code. Thanks in advance.

Code Review tool of Angular Js ??

Hi All,
I need to do code review for all of my Angular JS files
Please let me know if any tool is available for doing review of my JS files
I am aware of ReSharper tool and planning to use the same for my requirement.
Thanks in Advance
-Jiniv Thakkar

Hi Zpittman,
What is you said ‘Code Review Tool’?
I assume that you meant the Code Review feature in TFS. I tried it in Visual Studio 2013 with update 4 and TFS 2013 with Update 4, the whitespace was detected and the code review see it as a difference.
If you don’t get the same result with me using VS and TFS, please upgrade your VS and TFS to the latest update.
If the issue still exists, please
reset your VS settings through Tools->Import and Export settings->Reset all
settings->…. and repair your VS.
If code review tool is a third-party tool or a third-party VS/TFS add-in, the official support of this tool can be a better place to resolve your issue.
If I misunderstood anything, please feel free to come back.
Thanks,
We are trying to better understand customer views on social support experience, so your participation in this interview project would be greatly appreciated if you have time. Thanks for helping make community forums a great place.
Click
HERE to participate the survey.

Are there any good tool for checking security risks, Code review, memory leakages for SharePoint projects?

Are there any good tool for checking security risks, Code review, memory leakages for SharePoint projects?
I found one such tool "Fortify" in the below link. Are there any such kind of tools available which supports SharePoint?
Reference: http://www.securityresearch.at/en/development/fortify/
Amalaraja Fernando,
SharePoint Architect
Please Mark As Answer if my post solves your problem or Vote As Helpful if a post has been helpful for you. This post is provided "AS IS" with no warrenties and confers no rights.

Hi Amalaraja Fernando,
I'm not sure that there is one more tool that combines all these features. But you may take a look at these solutions:
SharePoint diagnostic manager
SharePoint enterprise manager
What is SPCop SharePoint Code Analysis?
Dmitry
Lightning Tools Check
out our SharePoint tools and web parts |
Lightning Tools Blog | Мой Блог

Looking for Code Review Resources

We have completed a complex project using jakarta struts and are in beta testing at the moment.
Would like to have someone review our code but we have not been able to find expierienced developers in our (physical) area.
Does anyone have suggestions on where I could look to find a qualified individual for independent code review.
Thank you in advance for your suggestions.

Just post it here. Some of our fine reviewers will be happy to serve you.
P.S. Be sure to say that it's homework.

Jupiter Plug-in for JDeveloper for doing effective code reviews?

Hi all,
Can some body comment on the availability of an effective code review tool that can be used with -
a) JDeveloper as a IDE and
b) Can work with ADE as a version control tool?
My team is currently trying to understand if Jupiter, which is an Eclipse based plug-in, can serve as a possible solution for the same.
Request you all to answer a) and b) w.r.t Jupiter and also suggest alternatives, if any.
Regards,
Prasad.

What type of review are you looking for?
JDeveloper has built in code review see (Run->audit project).
There is also a PMD extension to JDeveloper.
If you are looking for a tool that will let you track things to fix in your code among team members have a look at Oracle's Team Productivity Center:
http://www.oracle.com/technology/products/tpc/index.html

Code Review tool for XPRESS

Does anybody have any idea about Code review tool for XPRESS Language??Please let me know

We did something like it only using xsl.
Using the console we do an export of all sources, then the xsl processes the huge xml file and writes 'inconsistencies'
message for calls to rules/subprocesses/forms that are incorrect...

Code review Approval Workflow for Eclipse

Hi
Currently Team is using Eclipse for their project and we used TFS Plug-in. We are using for both Source control and Build process.
Is there any plug-in to have Code Review Approval Workflow for the Check-in's happens in this project?
regards,
Vinay

Any Help please ?

Code Review Tool for Weblogic 8.1

I am working with WLS 8.1. Can anyone suggest plugin or code review tool for reviewing from workshop?
I have used PMD open source plugin with eclipse for reviewing java files. I couldnt use it for .ejb files generated from workshop. Pls suggest some procedure for this.
Thanks in advance!
Regards,
Poorani

Red Samurai is not avaiable for 11.1.2 at the moment as Oracle changes the way extensions plug into jdev :-(.
Have you tried out the jdev internal audit tools (under Build->'Audit projectname' and follow the dialogs)?
Timo

Code Review functionality in TFS plugin for Eclipse

Hi
We are using Team Foundation Server plug-in for Eclipse Version 11.0.0 to connect to TFS SCM. We are interested in the code review feature that is offered in the Visual Studio 2012 TFS, Being able to request code review from the My Work tab.
Is this feature available in the Eclipse plugin for TFS. If not, Is it possible to have this feature integrated in the eclipse plugin?
Thanks

I can't give you an exact (or, frankly, even an approximate) date. There is a long list of priorities - code review support in TEE being one of them. In April, we will start planning for our next update and will see where this lands.
Believe me, we like this feature (and could use it ourselves).
Any other opinions/thoughts from the community are also useful to have --- so, feel free to respond on this thread or reach out to me directly (wismythe AT microsoft.com).
Will Smythe
Program Manager, Team Explorer Everywhere

BAdI code review - for perfomance improvements

Similar Messages

Maybe you are looking for