BADI in ECC 6.0

Question

Hi Experts,
I had implemented a BADI in ECC 6.0. It is having some warnings. <b>But i am not able to activate the implementaion.</b>
This badi is basically to copy the PO reference for Repair, Rework & Refurb to vendors to all documents.
For this i found the BADi <b>LE_SHP_GOODSMOVEMENT</b>
In that i have the method <b>CHANGE_INPUT_HEADER_AND_ITEMS</b>
when i write the below logic here
method IF_EX_LE_SHP_GOODSMOVEMENT~CHANGE_INPUT_HEADER_AND_ITEMS.
**->Data declaration
  CONSTANTS:  C_LB TYPE LIKP-LFART VALUE 'LB',
              C_X  TYPE C VALUE 'X',
              C_O  TYPE MSEG-SOBKZ VALUE 'O',
              C_E TYPE SHP_BADI_ERROR_LOG-MSGTY VALUE 'E',
              C_ZM TYPE SHP_BADI_ERROR_LOG-MSGID VALUE 'ZM',
              C_999 TYPE SHP_BADI_ERROR_LOG-MSGNO VALUE '999',
              C_541 TYPE MSEG-BWART VALUE '541',
              C_542 TYPE MSEG-BWART VALUE '542'.
  DATA: WA_CTLOG TYPE SHP_BADI_ERROR_LOG,
        WA_XIMSEG TYPE IMSEGVB,
        WA_XLIPS  TYPE LIPSVB.
  DATA: L_EBELN  TYPE EKPO-EBELN,
        L_EBELP  TYPE EKPO-EBELP,
        L_LIFEX  TYPE LIKP-LIFEX,
        L_LIFNR  TYPE LIKP-LIFNR,
        L_CHECK   TYPE C,
        L_BDMNG  TYPE RESB-BDMNG,
        L_MENGE1 TYPE MSEG-MENGE.
  TYPES: BEGIN OF TY_RESB,
           BDMNG TYPE BDMNG,
         END   OF TY_RESB,
         BEGIN OF  TY_MSEG,
           BWART TYPE BWART,
           MENGE TYPE MENGE_D,
         END   OF TY_MSEG.
  DATA: IT_RESB TYPE STANDARD TABLE OF TY_RESB INITIAL SIZE 0,
        IT_MSEG TYPE STANDARD TABLE OF TY_MSEG INITIAL SIZE 0.
  DATA: WA_RESB TYPE TY_RESB,
        WA_MSEG TYPE TY_MSEG.
*-->Check for delivery type LB.
  CHECK IS_LIKP-LFART EQ C_LB.
*-->Check for Purchase doc Number.
  IF IS_LIKP-LIFEX IS INITIAL.
    WA_CTLOG-MSGV1 = 'PO Number is Blank in Delivery'(001).
    L_CHECK = C_X.
  ENDIF.
  IF L_CHECK NE C_X.
    MOVE IS_LIKP-LIFEX TO L_LIFEX.
    CONDENSE L_LIFEX.
    L_EBELN = L_LIFEX+0(10).
    L_EBELP = L_LIFEX+11(5).
*-->Get the PO Vendor
    SELECT SINGLE LIFNR INTO L_LIFNR FROM EKKO
                             WHERE EBELN EQ L_EBELN.
    IF SY-SUBRC EQ 0.
*-->Compare PO Vendor with the Delivery in Vendor
      IF IS_LIKP-LIFNR NE L_LIFNR.
        WA_CTLOG-MSGV1 =
        'PO Vendor does not match with Delivery Vendor'(002).
        L_CHECK = C_X.
      ELSE.
        READ TABLE IT_XLIPS INTO WA_XLIPS INDEX 1.
        IF SY-SUBRC EQ 0.
          SELECT BWART MENGE
                 INTO TABLE IT_MSEG FROM MSEG
                                 WHERE BWART IN (C_541,C_542) AND
                                       MATNR EQ WA_XLIPS-MATNR AND
                                       WERKS EQ WA_XLIPS-WERKS AND
                                       SOBKZ EQ C_O AND
                                       LIFNR EQ L_LIFNR AND
                                       EBELN EQ L_EBELN.
**Subrc Check not required.
          SELECT BDMNG INTO TABLE IT_RESB FROM RESB WHERE
                        KZEAR EQ SPACE AND
                        MATNR EQ WA_XLIPS-MATNR AND
                        EBELN EQ L_EBELN
                        AND LIFNR EQ L_LIFNR.
          IF SY-SUBRC EQ 0.
            CLEAR L_BDMNG.
            LOOP AT IT_MSEG INTO WA_MSEG.
              IF WA_MSEG-BWART EQ C_541.
                L_MENGE1 = L_MENGE1 + WA_MSEG-MENGE.
              ELSE.
                L_MENGE1 = L_MENGE1 - WA_MSEG-MENGE.
              ENDIF.
            ENDLOOP.
            LOOP AT IT_RESB INTO WA_RESB.
              L_BDMNG = L_BDMNG + WA_RESB-BDMNG.
            ENDLOOP.
            L_BDMNG = L_BDMNG - L_MENGE1.
            IF NOT WA_XLIPS-LFIMG LE L_BDMNG.
              MESSAGE I999(ZX) WITH
              'Delivery Quantity Greater than Components'(004)
                                    'Required for Purchase order'(005).
            ENDIF.
          ELSE.
            MESSAGE I999(ZX) WITH
            'Delivery Quantity Greater than Components'(004)
                                  'Required for Purchase order'(005).
          ENDIF.
          IF L_CHECK NE C_X.
*-->Populate PO Number in MSEG table
            LOOP AT CT_XIMSEG INTO WA_XIMSEG.
              WA_XIMSEG-EBELN = L_EBELN.
              WA_XIMSEG-EBELP = L_EBELP.
              MODIFY CT_XIMSEG FROM WA_XIMSEG.
            ENDLOOP.
          ENDIF.
        ENDIF.
      ENDIF.
    ELSE.
*-->Issue an error message if the PO entered in Delivery is Wrong
      WA_CTLOG-MSGV1 = 'Enter a Valid PO Number in the Delivery'(003).
      L_CHECK = C_X.
    ENDIF.
  ENDIF.
*-->Populate the error table
  IF L_CHECK EQ C_X.
    WA_CTLOG-VBELN = IS_LIKP-VBELN.
    WA_CTLOG-POSNR = WA_XLIPS-POSNR.
    WA_CTLOG-MSGTY = C_E.
    WA_CTLOG-MSGID = C_ZM.
    WA_CTLOG-MSGNO = C_999.
    APPEND WA_CTLOG TO CT_LOG.
    CLEAR WA_CTLOG.
  ENDIF.
endmethod.
it is giving an<b> warning</b>
<b>The feild LIFNR used in the where condition may contain Null values</b>
<b>and i am not able to activate the implementation.</b>

Answer 1

Hello Raghavendra
For some reasons (that I do not fully understand) the field LIFNR of the tables can contain NULL values. However, with the following modifications of your coding it is possible to get rid of the warnings and activate the BAdI implementation.
[code]  TYPES: BEGIN OF ty_resb,
  bdmng TYPE bdmng,
  lifnr TYPE lifnr,  " $field added
  END OF ty_resb,
  BEGIN OF ty_mseg,
  bwart TYPE bwart,
  menge TYPE menge_d,
  lifnr TYPE lifnr,  " $field added
  END OF ty_mseg.[/code]
[code]...
*-->Get the PO Vendor
    SELECT SINGLE lifnr INTO l_lifnr FROM ekko
    WHERE ebeln EQ l_ebeln.
    IF sy-subrc EQ 0.
   IF ( syst-subrc = 0 ) AND ( l_lifnr IS NOT INITIAL ).
*-->Compare PO Vendor with the Delivery in Vendor
      IF is_likp-lifnr NE l_lifnr.
        wa_ctlog-msgv1 =
        'PO Vendor does not match with Delivery Vendor'(002).
        l_check = c_x.
      ELSE.
        READ TABLE it_xlips INTO wa_xlips INDEX 1.
        IF sy-subrc EQ 0.
          SELECT bwart menge lifnr  " $ field LIFNR added
          INTO TABLE it_mseg FROM mseg
          WHERE bwart IN (c_541,c_542) AND
          matnr EQ wa_xlips-matnr AND
          werks EQ wa_xlips-werks AND
          sobkz EQ c_o AND
          lifnr EQ l_lifnr AND  " Here it works but Why???
          ebeln EQ l_ebeln.
**Subrc Check not required.
          SELECT bdmng lifnr  " $ field LIFNR added
          INTO TABLE it_resb FROM resb
          WHERE
          kzear EQ space AND
          matnr EQ wa_xlips-matnr AND
         lifnr EQ l_lifnr    AND  " Here it does not work but Why???
          ebeln EQ l_ebeln.
          DELETE it_resb WHERE ( lifnr NE l_lifnr ).
          DESCRIBE TABLE it_resb.  " fills sy-tfill.
         IF sy-subrc EQ 0.
          IF ( syst-tfill > 0 ).
            CLEAR l_bdmng.
...[/code]
Regards
  Uwe