Calculations from report data

Question

Hi,
I have been using the below SQL in one of my reports to show Sales data. It has recently come to my attention that calculating the likes of Fin Year and Fin Period are best done at the presentation section of the report rather than in the SQL. Is this correct?
If so how would I script the function to calculate these?
Cheers
Paul

Answer 1

Sorry, I forgot to add it. Here you go:
--DECLARE @FINANCIALYEAR VARCHAR(4)
--DECLARE @FINPERIOD VARCHAR(4)
--SET @FINANCIALYEAR = '2013'
--SET @FINPERIOD = '10'
SELECT
CASE
WHEN MONTH(dbo.SALESTABLE.CREATEDDATE) <= 2
THEN YEAR(dbo.SALESTABLE.CREATEDDATE) - 1
WHEN MONTH(dbo.SALESTABLE.CREATEDDATE) >= 4
THEN YEAR(dbo.SALESTABLE.CREATEDDATE)
WHEN MONTH(dbo.SALESTABLE.CREATEDDATE) = 3 AND YEAR(dbo.SALESTABLE.CREATEDDATE) <= 2011
THEN YEAR(dbo.SALESTABLE.CREATEDDATE)
ELSE YEAR(dbo.SALESTABLE.CREATEDDATE) - 1
END AS [Fin Year],
CASE
WHEN YEAR(dbo.SALESTABLE.CREATEDDATE) <= 2012 AND MONTH(dbo.SALESTABLE.CREATEDDATE) <= 2
THEN MONTH(dbo.SALESTABLE.CREATEDDATE) + 10
WHEN YEAR(dbo.SALESTABLE.CREATEDDATE) <= 2011 AND MONTH(dbo.SALESTABLE.CREATEDDATE) >= 3
THEN MONTH(dbo.SALESTABLE.CREATEDDATE) - 2
WHEN YEAR(dbo.SALESTABLE.CREATEDDATE) = 2012 AND MONTH(dbo.SALESTABLE.CREATEDDATE) = 3
THEN 13
WHEN YEAR(dbo.SALESTABLE.CREATEDDATE) >= 2013 AND MONTH(dbo.SALESTABLE.CREATEDDATE) <= 3
THEN MONTH(dbo.SALESTABLE.CREATEDDATE) + 9
WHEN YEAR(dbo.SALESTABLE.CREATEDDATE) >= 2012 AND MONTH(dbo.SALESTABLE.CREATEDDATE) >= 4
THEN MONTH(dbo.SALESTABLE.CREATEDDATE) - 3
END AS [Period],
dbo.SALESTABLE.SALESID AS [Sales ID],
CONVERT(DECIMAL(12, 2), SUM(dbo.SALESLINE.LINEAMOUNT)) AS [Value],
dbo.SALESTABLE.SALESNAME AS [Name]
FROM dbo.SALESTABLE
INNER JOIN dbo.SALESLINE ON dbo.SALESTABLE.SALESID = dbo.SALESLINE.SALESID
WHERE (
CASE
WHEN MONTH(dbo.SALESTABLE.CREATEDDATE) <= 2
THEN YEAR(dbo.SALESTABLE.CREATEDDATE) - 1
WHEN MONTH(dbo.SALESTABLE.CREATEDDATE) >= 4
THEN YEAR(dbo.SALESTABLE.CREATEDDATE)
WHEN MONTH(dbo.SALESTABLE.CREATEDDATE) = 3 AND YEAR(dbo.SALESTABLE.CREATEDDATE) <= 2011
THEN YEAR(dbo.SALESTABLE.CREATEDDATE)
ELSE YEAR(dbo.SALESTABLE.CREATEDDATE) - 1 END) IN (@FINANCIALYEAR)
AND
(CASE
WHEN YEAR(dbo.SALESTABLE.CREATEDDATE) <= 2012 AND MONTH(dbo.SALESTABLE.CREATEDDATE) <= 2
THEN MONTH(dbo.SALESTABLE.CREATEDDATE) + 10
WHEN YEAR(dbo.SALESTABLE.CREATEDDATE) <= 2011 AND MONTH(dbo.SALESTABLE.CREATEDDATE) >= 3
THEN MONTH(dbo.SALESTABLE.CREATEDDATE) - 2
WHEN YEAR(dbo.SALESTABLE.CREATEDDATE) = 2012 AND MONTH(dbo.SALESTABLE.CREATEDDATE) = 3
THEN 13
WHEN YEAR(dbo.SALESTABLE.CREATEDDATE) >= 2013 AND MONTH(dbo.SALESTABLE.CREATEDDATE) <= 3
THEN MONTH(dbo.SALESTABLE.CREATEDDATE) + 9
WHEN YEAR(dbo.SALESTABLE.CREATEDDATE) >= 2012 AND MONTH(dbo.SALESTABLE.CREATEDDATE) >= 4
THEN MONTH(dbo.SALESTABLE.CREATEDDATE) - 3
END) IN (@FINPERIOD)
AND GBORDER = '1'
AND SALESTABLE.SALESTYPE = '3'
GROUP BY MONTH(dbo.SALESTABLE.CREATEDDATE), YEAR(dbo.SALESTABLE.CREATEDDATE), dbo.SALESTABLE.SALESID, dbo.SALESTABLE.SALESNAME
ORDER BY 1, 2 ASC
So I'd be better working it out this way anyway?