Can't decrypt binary file with PBE

Question

Hi,
I'm writing an simple file transfer application using UDP that encrypts the data
before sending it with PBEWithMD5AndDES. Text files are encrypted and
decrypted fine, but binary files such as a JPG/EXE/DOC... are messed up
and an application can't open them on the other side. Has anyone experienced
such a problem?
Thanks

Answer 1

Below are my encrypt and decrypt functions.
Thanks in advance.
        public  byte[] encrypt(byte[] data)
             PBEKeySpec pbeKeySpec;
             PBEParameterSpec pbeParamSpec;
             SecretKeyFactory keyFac;
             ByteArrayOutputStream b=null;
             DataOutputStream d =null;
             //      Salt
             byte[] salt = {
                       (byte)0xc7, (byte)0x73, (byte)0x21, (byte)0x8c,
                    (byte)0x7e, (byte)0xc8, (byte)0xee, (byte)0x99
             //      Iteration count
             int count = 1000;
             // Create PBE parameter set
             pbeParamSpec = new PBEParameterSpec(salt, count);
             try{
                  pbeKeySpec = new PBEKeySpec(sessionPassword.toCharArray());
                  keyFac = SecretKeyFactory.getInstance("PBEWithMD5AndDES","SunJCE");
                  SecretKey pbeKey = keyFac.generateSecret(pbeKeySpec);
                  // Create PBE Cipher
                  Cipher pbeCipher = Cipher.getInstance("PBEWithMD5AndDES","SunJCE");
                  // Initialize PBE Cipher with key and parameters
                  pbeCipher.init(Cipher.ENCRYPT_MODE, pbeKey, pbeParamSpec);
                  b = new ByteArrayOutputStream();
                  d = new DataOutputStream(b);
                  // create CipherOutputStream
                  CipherOutputStream out = new CipherOutputStream( b, pbeCipher );
                  // write contents to file and close
                  try {
                       for ( int i = 0; i < data.length; i++ )
                            out.write(data);
                         out.flush();
                    out.close();
               // handle IOException
               catch ( IOException exception ) {
                    exception.printStackTrace();
          catch(Exception e){}
          return(b.toByteArray());
     public byte[] decrypt(byte[] data)
          PBEKeySpec pbeKeySpec;
          PBEParameterSpec pbeParamSpec;
          SecretKeyFactory keyFac;
          byte[] decryptedData=null;
          //      Salt
          byte[] salt = {
                    (byte)0xc7, (byte)0x73, (byte)0x21, (byte)0x8c,
                    (byte)0x7e, (byte)0xc8, (byte)0xee, (byte)0x99
          //      Iteration count
          int count = 1000;
          // Create PBE parameter set
          pbeParamSpec = new PBEParameterSpec(salt, count);
          try{
               pbeKeySpec = new PBEKeySpec(sessionPassword.toCharArray());
               keyFac = SecretKeyFactory.getInstance("PBEWithMD5AndDES","SunJCE");
               SecretKey pbeKey = keyFac.generateSecret(pbeKeySpec);
               // Create PBE Cipher
               Cipher pbeCipher = Cipher.getInstance("PBEWithMD5AndDES","SunJCE");
               // Initialize PBE Cipher with key and parameters
               pbeCipher.init(Cipher.DECRYPT_MODE, pbeKey, pbeParamSpec);
               Vector fileBytes = new Vector();
               ByteArrayInputStream b = new ByteArrayInputStream(data);
               CipherInputStream in = new CipherInputStream( b, pbeCipher );
               byte contents = ( byte ) in.read();
               while ( contents != -1 )
                    fileBytes.add( new Byte( contents ) );
                    contents = ( byte ) in.read();
               in.close();
               decryptedData = new byte[ fileBytes.size() ];
               for ( int i = 0; i < fileBytes.size(); i++ )
                    decryptedData[ i ] = (( Byte )fileBytes.elementAt( i )).byteValue();
          catch(Exception e){Gui.chatArea.append("exception:"+e+"\n");}
          return(decryptedData);