Can't understand how TableCellRenderer is meant to work

Question

I've not done much Swing work and I'm trying to understand how a customer TableCellRenderer is meant to work. I know I've made a stupid mistake here somewhere but I can't find any specific docs on what I'm try to do.
Basically I have a column in my JTable which holds my own Counter object. I want to render the cell so that the current value of the counter is displayed, along with 2 little buttons that allow the user to increment/decrement the counter value.
The code is below, I seem to have 3 problems:
1) One click on the button seems to increment the counter several times (inserting some log statements it seems that the MouseListener is being added several times?)
2) The value on the counter doesn't seem to get refreshed/repainted once the button is clicked, only some time later (e.g. when I click on a different cell in the JTable)
3) The +/- buttons dont "depress" when they are clicked.
Any help much appreciated!
public Component getTableCellRendererComponent(
JTable table, Object lagInput,
boolean isSelected, boolean hasFocus,
int row, int column) {
removeAll();
final Counter counter = (Counter)counter;
final JButton increment = new JButton("+");
increment.setMargin(new Insets(1,1,1,1));
increment.setPreferredSize(new Dimension(15,15));
final JButton decrement = new JButton("-");
decrement.setMargin(new Insets(1,1,1,1));
decrement.setPreferredSize(new Dimension(15,15));
final JTable finalTable = table;
final int finalColumn = column;
table.addMouseListener(new MouseAdapter(){
public void mousePressed(MouseEvent e) {
Rectangle panelBounds = finalTable.getTableHeader().getHeaderRect(finalColumn);
Rectangle buttonBounds = increment.getBounds();
buttonBounds.translate(panelBounds.x, panelBounds.y);
if (buttonBounds.contains(e.getX(), e.getY())){
counter.increment();
Rectangle buttonBoundsDec = decrement.getBounds();
buttonBoundsDec.translate(panelBounds.x, panelBounds.y);
if (buttonBoundsDec.contains(e.getX(), e.getY())){
counter.decrement();
setLayout(new GridBagLayout());
GridBagConstraints c = new GridBagConstraints();
c.fill = GridBagConstraints.HORIZONTAL;
c.gridheight = 2;
c.gridx = 0;
c.gridy = 0;
add(counter);
c.fill = GridBagConstraints.HORIZONTAL;
c.gridheight = 1;
c.gridx = 0;
c.gridy = 1;
add(increment);
c.fill = GridBagConstraints.HORIZONTAL;
c.gridheight = 1;
c.gridx = 1;
c.gridy = 1;
add(decrement);
return this;
}

Answer 1

If that's all there is to the Counter class, it seems to me that what you really want is a JTable of JSpinners.import java.awt.Component;
import javax.swing.*;
import javax.swing.table.TableCellEditor;
import javax.swing.table.TableCellRenderer;
public class SpinnerTable {
   void makeUI() {
      Integer[][] data = new Integer[10][5];
      String[] colNames = new String[data[0].length];
      for (int i = 0; i < data[0].length; i++) {
         colNames[i] = "Column " + i;
         for (int j = 0; j < data.length; j++) {
            data[j] = 0;
JTable table = new JTable(data, colNames) {
@Override
public Class getColumnClass(int column) {
return Integer.class;
table.setDefaultEditor(Integer.class, new TableCellSpinner(table));
table.setDefaultRenderer(Integer.class, new TableCellSpinner(table));
table.setRowHeight(new JSpinner().getPreferredSize().height + table.
getIntercellSpacing().height);
JScrollPane scrollPane = new JScrollPane(table);
JFrame frame = new JFrame("SpinnerRendererTable");
frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
frame.setSize(400, 400);
frame.setLocationRelativeTo(null);
frame.add(scrollPane);
frame.setVisible(true);
public static void main(String[] args) {
SwingUtilities.invokeLater(new Runnable() {
public void run() {
new SpinnerTable().makeUI();
class TableCellSpinner extends AbstractCellEditor
implements TableCellRenderer, TableCellEditor {
JTable table;
JSpinner spinner = new JSpinner();
JTextField editor = ((JSpinner.DefaultEditor) spinner.getEditor()).
getTextField();
TableCellSpinner(JTable table) {
this.table = table;
public Component getTableCellRendererComponent(JTable table, Object value,
boolean isSelected, boolean hasFocus, int row, int column) {
spinner.setValue((Integer) value);
if (isSelected) {
editor.setBackground(table.getSelectionBackground());
} else {
editor.setBackground(table.getBackground());
if (hasFocus) {
spinner.setBorder(BorderFactory.createLineBorder(table.getGridColor()));
} else {
spinner.setBorder(null);
return spinner;
public Component getTableCellEditorComponent(JTable table, Object value,
boolean isSelected, int row, int column) {
spinner.setValue((Integer) value);
spinner.setBorder(BorderFactory.createLineBorder(table.getGridColor()));
return spinner;
public Object getCellEditorValue() {
return spinner.getValue();
}Check that out carefully in case I've missed anything.
db
edit Added the code for the isSelected border
Edited by: Darryl.Burke