Cancel button doesn't cancel

Question

Hello.
I have the following code:-
public void actionPerformed(ActionEvent e) {
          if (e.getSource() == ok)
               theType = type.getSelection().getActionCommand();
              // use the entered data
              theBid = Integer.parseInt(bid.getText());
            theName = name.getText();
          else if (e.getSource() == cancel) {
              // data entry cancelled
          dispose();
     }my problem is the cancel button doesn't actually cancel although does close the window it still submits the data.
how can i get it to destroy all data and then close the window?
many thanks in advance.
dave.

Answer 1

Hello,
those bits of code still don't seem to work. it ends up setting 'null' for strings and 0 for ints still when i press cancel.
here is more code to show where the data is actually used:-
GUINew.java (part of previous code):-
import javax.swing.*;
import java.awt.*;
import java.awt.event.*;
public class GUINew extends JDialog implements ActionListener
     private JButton ok;
     private JButton cancel;
     private ButtonGroup type;
     private JTextField bid;
     private JTextField name;
     int theBid;
     String theName;
     String theType;
     public GUINew(String sTitle, JFrame owner) {
          super (owner, sTitle, true);
          setLooknFeel();
          bid = new JTextField(4);
          name = new JTextField(14);
          ok = new JButton("Hire Boat!");
          ok.addActionListener(this);
          cancel = new JButton("Cancel");
          cancel.addActionListener(this);
          type = new ButtonGroup();
          // create each radio button, specifying its label
          JRadioButton pedal = new JRadioButton("Pedal boat");
          JRadioButton rowing = new JRadioButton("Rowing boat");
          // set a String to associate with each button
          // will use this when the radio button is selected
          pedal.setActionCommand("Pedal boat");
          rowing.setActionCommand("Rowing boat");
          type.add(pedal);
          type.add(rowing);
          JPanel top = new JPanel();
          top.add(pedal);
          top.add(rowing);
         getContentPane().add("North", top);
          JPanel center = new JPanel();
          center.add(new JLabel("Enter Boat ID:"));
          center.add(bid);
          center.add(new JLabel("Enter Name/Colour:"));
          center.add(name);
          getContentPane().add("Center", center);
          JPanel bottom = new JPanel();
          bottom.add(ok);
          bottom.add(cancel);
          getContentPane().add("South", bottom);
          pack();
     public int getBid() { return theBid; }
     public String getName() { return theName; }
     public String getType() { return theType; }
     public void actionPerformed(ActionEvent e) {
          if (e.getSource() == ok)
               theType = type.getSelection().getActionCommand();
              // use the entered data
              theBid = Integer.parseInt(bid.getText());
            theName = name.getText();
          else if (e.getSource() == cancel) {
              this.dispose();//will release memory
               this.setVisible(false);//will hide the window
          dispose();
     // windows look and feel settings
     private void setLooknFeel() {
        String lookAndFeel = "com.sun.java.swing.plaf.windows.WindowsLookAndFeel";
        try {
            UIManager.setLookAndFeel(lookAndFeel);
        catch (Exception e) {
            e.printStackTrace();
}Main.java - where the data is used:-
else if (e.getSource() == mtOne) { // add new boat
               GUINew newb = new GUINew("Add a new boat", this);
               newb.setVisible(true);
               if(newb.getType() == "Rowing Boat") {
                    octagon.addBoat(new RowingBoat(newb.getName(), newb.getBid()), newb.getBid(), textarea, title);
               else {
                    octagon.addBoat(new PedalBoat(newb.getName(), newb.getBid()), newb.getBid(), textarea, title);
          }at the moment when i click cancel it submits getName as Null and getBid and 0.
Thanks
Dave.