"Cannot evaluate parameter 'NewName' because its argument input did not produce any output." error received

Question

I need to rename a set of files with a subset of the files' original name. I wrote this script:
dir | rename-item -newname {if ($_.name -match '\d{4,5}\-\d{5}\s\-\s(.+)\s\-\s.+\s\-\s.+'){$name=$matches[1]; -replace '.+', "$name";}}
This works in that the file and/or directory names are changed, but it also gives me the error:
Rename-Item : Cannot evaluate parameter 'NewName' because its argument input did not produce any output.
At C:\...\FileStrip.ps1:1 char:28
+ dir | rename-item -newname {if ($_.name -match '\d{4,5}\-\d{5}\s\-\s(.+)\s\-\s.+ ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument: (Vivek Shyam:PSObject) [Rename-Item], ParameterBindingException
    + FullyQualifiedErrorId : ScriptBlockArgumentNoOutput,Microsoft.PowerShell.Commands.RenameItemCommand
I'm not sure how to fix this. Any assistance would be appreciated.

Answer 1

ok, thanks.
You've avoided the whole 'use the piped data implicitly' thing by the explicit ForEach. I'm ok with that, but I'm still curious how to get the non-ForEach version to not error.
Anyway, what you provided almost worked. I modified to be this:
dir -file |
   Where{$_.name -match '\d{4,5}\-\d{5}\s\-\s(.+)\s\-\s.+\s\-\s.+'} |
   ForEach-Object{
        $match=$matches[1]
        $newname=$_.Name -replace '.+', "$match"
        Rename-item $_ $newname
to get it working properly.
But it looks like the simplest form is:
dir -file |
   Where{$_.name -match '\d{4,5}\-\d{5}\s\-\s(.+)\s\-\s.+\s\-\s.+'} |
   ForEach-Object{
        Rename-item $_ $matches[1]