Case statement assistance

Question

I am using a case statement in the following script, so that I can return two seperate columns in my item master query, one for Frozen Cost and one for Actual Cost. I am having trouble with the else close. If the records for frozen are other then frozen, I do not want to have them returned as part of the records and same thing for Actual, if they are not actual I do not want them returned. Any help is appreciated. I am running on 10.2.0.4.0 for the database and for the app layer we are at 11.5.10.2.
SELECT MSI.INVENTORY_ITEM_ID INVENTORY_ITEM_ID
, msi.segment1 ITEM
, MSI.DESCRIPTION DESCRIPTION
, msi.inventory_item_status_code INVENTORY_ITEM_STATUS_CODE
, msi.item_type ITEM_TYPE
, max (mirb.revision) REVISION
, MSI.PRIMARY_UOM_CODE PRIMARY_UOM_CODE
, msi.shippable_item_flag SHIPPABLE_ITEM_FLAG
, NVL (CIC.ORGANIZATION_ID, '0') ORGANIZATION_ID
,CASE when cct.cost_type in 'Frozen' then cic.item_cost else 0 end as FROZEN_COST
,CASE when cct.cost_type in 'ACTUAL' then cic.item_cost else 0 end as ACTUAL
, cct.cost_type COST_TYPE
FROM CST_ITEM_COSTS CIC
, CST_COST_TYPES CCT
, MTL_SYSTEM_ITEMS MSI
, MTL_DEFAULT_CATEGORY_SETS MDC
, MFG_LOOKUPS LU1
, mtl_item_revisions_b mirb
WHERE CCT.COST_TYPE_ID(+) = CIC.COST_TYPE_ID
AND CIC.INVENTORY_ITEM_ID(+) = MSI.INVENTORY_ITEM_ID
AND CIC.ORGANIZATION_ID (+) = MSI.ORGANIZATION_ID
AND MSI.COSTING_ENABLED_FLAG = 'Y'
AND msi.inventory_item_id = mirb.inventory_item_id
AND msi.organization_id = mirb.organization_id
AND LU1.LOOKUP_CODE(+) = MSI.PLANNING_MAKE_BUY_CODE
/* the outside join below, speeds up query, not sure why */
AND LU1.LOOKUP_TYPE(+) = 'MTL_PLANNING_MAKE_BUY'
and cct.cost_type = 'Frozen'
AND msi.organization_id = 4
group by CIC.ROWID, MSI.INVENTORY_ITEM_ID, MSI.SEGMENT1, MSI.DESCRIPTION, MSI.INVENTORY_ITEM_STATUS_CODE,
MSI.PRIMARY_UOM_CODE, MSI.SHIPPABLE_ITEM_FLAG, CIC.ORGANIZATION_ID, MSI.ITEM_TYPE, CIC.ITEM_COST, CIC.MATERIAL_COST, cct.cost_type

Answer 1

Hi,
The CASE expressions look good to me, except that you need parentheses after the keyword IN. (See 'Frozen' below.)
If you're only comparing to one item, as you are here, you can use = instead of IN. (See 'ACTUAL' below.)
,      CASE
             WHEN  cct.cost_type IN ('Frozen' )
          THEN  cic.item_cost
          ELSE  0
       END     AS frozen_cost
,      CASE
             WHEN  cct.cost_type = 'ACTUAL'
          THEN  cic.item_cos
          ELSE  0
       END       AS actualRemember to capitalize things inside quotes carefully. The code above is looking for 'Frozen' with only one capital letter, the 'F', but 'ACTUAL' with all capital letters. Is that what you want?
It looks like you're doing a GROUP BY in this query. If so, you'll have to copy these CASE expresssions into the GROUP BY clause, or use them only inside an aggregate function. For example:
,      SUM ( CASE
                    WHEN  cct.cost_type IN ('Frozen' )
                 THEN  cic.item_cost
                 ELSE  0
             END
           )         AS frozen_cost
,      SUM ( CASE
                    WHEN  cct.cost_type = 'ACTUAL'
                 THEN  cic.item_cos
                 ELSE  0
             END
           )           AS actualSince your WHERE clause includes the condition
cct.cost_type = 'Frozen'I would expect the 1st CASE expression to include all rows, and the 2nd to include no rows. If that's the situation, why have CASE expressions at all?
I hope that answers your question.
If not, post a simplified query, involviong only these CASE exoressions and the GROUP BY.
Post CREATE TABLE and INSERT statements for a little sample data (include only the columns and tables in the simplified query). Also post the results you want from that sample data.
Edited by: Frank Kulash on Aug 12, 2010 5:10 PM
Corrected bad nesting: "END" should be before ")".