CASE statement falls straight through to end

Question

Hello,
I want the following code to execute a case statement when it hits todays day name. I know from the out put at the end that it is picking the name up but it wont act on the name in the case statement.
This is my code,
SQL> DECLARE num NUMBER;
  2  insert_rec VARCHAR2(150);
  3  party_id NUMBER;
  4  day_rec VARCHAR2(150);
  5  loop_max NUMBER;
  6  today VARCHAR2(20);
  7  yesterday VARCHAR2(20);
  8
  9  -- For debugging
10  rec_count VARCHAR2(150);
11
12  BEGIN
13    party_id := 3;
14    loop_max := 7;
15
16    FOR loop_index IN 1 .. loop_max
17    LOOP
18
19      EXECUTE IMMEDIATE 'SELECT MAX(SCH_ID) FROM FBT_SCHEDULE WHERE PAR_ID = ' || party_id || ''
20      INTO num;
21      -- For debugging
22      -- rec_count := '... The last records party_id is ' || num;
23      -- DBMS_OUTPUT.PUT_LINE(rec_count);
24
25      IF num IS NULL THEN
26
27        -- day_rec := sysdate;
28        -- Find the start of the week for this period if the week starts on Sunday.
29        -- For debugging
30        -- DBMS_OUTPUT.PUT_LINE( 'select to_char(sysdate,'||''''||'DAY'||''''||') from dual');
31        EXECUTE IMMEDIATE 'select to_char(sysdate,' || '''' || 'DAY' || '''' || ') from dual'
32        INTO today;
33        -- For debugging
34        DBMS_OUTPUT.PUT_LINE(today);
35
36        day_rec :=
37        CASE
38        WHEN today = 'SUNDAY' THEN
39          sysdate
40        WHEN today = 'MONDAY' THEN
41          sysdate -1
42        WHEN today = 'TUESDAY' THEN
43          sysdate -2
44        WHEN today = 'WEDNESDAY' THEN
45          sysdate -3
46        WHEN today = 'THURSDAY' THEN
47          sysdate -4
48        WHEN today = 'FRIDAY' THEN
49          sysdate -5
50        WHEN today = 'SATURDAY' THEN
51          sysdate -6
52        END;
53
54        DBMS_OUTPUT.PUT_LINE('...The adjusted day is '||day_rec);
55
56        -- For debugging
57        -- day_rec := '... The date is ' || day_rec;
58        -- DBMS_OUTPUT.PUT_LINE(day_rec);
59
60        -- insert_rec := 'INSERT INTO FBT_SCHEDULE (PAR_ID, SCHEDULE_DATE) VALUES (''' || party_id || ''', TO_DATE(''' || day_rec || ''', ''' || 'dd / mon / rr' || '''' || '))';
61        -- EXECUTE IMMEDIATE insert_rec;
62
63        ELSIF num > 0 THEN
64
65          EXECUTE IMMEDIATE 'SELECT SCHEDULE_DATE FROM FBT_SCHEDULE WHERE SCH_ID = ' || num || ''
66          INTO day_rec;
67
68          day_rec := to_date(day_rec) + 1;
69
70          -- For debugging
71          DBMS_OUTPUT.PUT_LINE(day_rec);
72
73          -- insert_rec := 'INSERT INTO FBT_SCHEDULE (PAR_ID, SCHEDULE_DATE) VALUES (''' || party_id || ''', TO_DATE(''' || day_rec || ''', ''' || 'dd / mon / rr' || '''' || '))';
74          -- EXECUTE IMMEDIATE insert_rec;
75
76        END IF;
77
78      END LOOP;
79    END;
80  /
THURSDAY
...The adjusted day is
THURSDAY
...The adjusted day is
THURSDAY
...The adjusted day is
THURSDAY
...The adjusted day is
THURSDAY
...The adjusted day is
THURSDAY
...The adjusted day is
THURSDAY
...The adjusted day is
PL/SQL procedure successfully completed.
SQL>Thank You for any help
Ben

Answer 1

Ok, i looked at this a little harder and have some advice for you.
1) lose the dynamic SQL or use binds if you NEED to be dynamic.
    EXECUTE IMMEDIATE 'SELECT MAX(SCH_ID) FROM FBT_SCHEDULE WHERE PAR_ID = ' || party_id || ''
    INTO num;
should just be
SELECT MAX(SCH_ID) INTO num FROM FBT_SCHEDULE WHERE PAR_ID = party_id;
      EXECUTE IMMEDIATE 'select to_char(sysdate,' || '''' || 'DAY' || '''' || ') from dual'
      INTO today;
should just be
today := to_char(sysdate, 'DAY');I'm also having a hard time following the logic, you have a party_id that doesn't change, yet you query based on that repeatedly inside your loop. It should be outside the loop.
In all likelyhood, you could do this in no procedural code, something to strive for if you have spare cycles.
Oh yeah, if you absolutely MUST use dynamic sql (you posted example code and my non-dynamic approach doesn't apply) then you MUST use bind variables.
        EXECUTE IMMEDIATE 'SELECT SCHEDULE_DATE FROM FBT_SCHEDULE WHERE SCH_ID = ' || num || ''
        INTO day_rec;
would be
EXECUTE IMMEDIATE 'SELECT SCHEDULE_DATE FROM FBT_SCHEDULE WHERE SCH_ID = :my_bind_variable' INTO day_rec USING num;