Computer not blocking my attempt

Question

Select computer mode and press 0 until the computer stacks one on top of the 0 column.. Then try to get 4 in a row as scuh
BLANK
X
X
X
O
X
Look at my computerMove() method. I basically copied my win() methods beginning part and it should be blocking. Why isn't it!?!?!?!?!
Edit-Code too long. I'll post half here half in the next
     import java.util.Scanner;//Input for user
     import java.util.Random;//Computer Generator turn
     public class connect4
   //These 2 variables are set to false, if it is set to true then they win.
      public static int rows=6;//Used to make the board
      public static int columns=7;
      public static boolean firstTime=true;//For the printBoard() method. If it's the first time it writes the board.
      public static String[][] gameBoard=new String[rows][columns];//2D array for the board.
      public static String userSwitch="";
          public static int firstCompMove=0;//For the compMove() method. Makes a random move the first time
          public static void main(String args[])
               Scanner input=new Scanner(System.in);
               Use a for loop to have the player input stuff via the play method
               send that data once it is transfered to the move method and then
               keep doing it until all spaces are filled or a winner is decided
               which is decided via the win method
               //Welcoming user, etc.
         System.out.println("   Welcome to Connect Four");
         printBoard(true);
               String computerOrPlayer="";
               //Whether the player1 wants to face player2 or a computer
               while(!computerOrPlayer.equalsIgnoreCase("c") && !computerOrPlayer.equalsIgnoreCase("p"))
                    System.out.println("Would you like to have player 2 or a computer? Type 'C' for computer or 'P' for player 2");
                  //Gets the user input, uppercased, and the first character     
                    computerOrPlayer=input.nextLine().toUpperCase().substring(0,1);
               String switching="_X_";
               //While the program isn't exited
               while(play(input, switching, computerOrPlayer).equals(""))
                    //Keep switching turns
                    if(switching.equals("_X_"))
                         switching="_O_";
                    else if(switching.equals("_O_"))
                         switching="_X_";
          //Method to print the board
          public static void printBoard(boolean firstTime)
         System.out.println("  0   1   2   3   4   5   6");
         for(int i=0;i<rows;i++)
            for(int j=0;j<columns;j++)
               if(firstTime)
                  gameBoard[i][j]="___";
               if(j==rows)
                  System.out.println("|"+gameBoard[i][j]+"|");
               else
                  System.out.print("|"+gameBoard[i][j]);
               //This way it won't write it again later.
         firstTime=false;
          

Answer 1

I have a number of suggestions.
1) When posting questions to forums do post your code here and if it's a too long that's a sign you should be posting less of it. You should have started by posting the computerMove method here. Make it easy for us to help you.
2) There are a few suggestions I have about the code in general and improvements you should look to make. Many of the things you are doing are fine for beginners but as code grows in length and programs in complexity it's time to learn better styles. And you're at that point here (the use of recursion for example is a sign). The program could use a serious OO overhaul, you will learn to be a better programmer and it will make your code easier to follow and understand for you. On that note for example there is too much static here. A properly written version of this program will have exactly one static method (main) and none of the static variables. That would be a good place to start improving. If you're not sure what this means see [http://java.sun.com/docs/books/tutorial/java/javaOO/classvars.html]
3) In the same line as above, think about using a class (or enum) to represent each "square" rather than the Strings. Strings are fine for display but you don't want to abuse them by using them to hold game (object) state as well. The code would really be helped by using an enum like
public enum Square{X,O,EMPTY}See [http://java.sun.com/docs/books/tutorial/java/javaOO/enum.html]
4) And also as above don't declare and initialize variables you may or may not need in areas removed from where you may or may not need them. Aka that random should be created the line before you need it, when you need it. Putting it at the start of the method just makes for needless confusion in reading your code and also has a negative performance impact (probably very small but it's there). You should strive to always create and use variables in the smallest scope that they need, tis good practice.
5) I suspect your actual problem is here (inside computerMove)
else if(vert==2 && horz==6)
  computerMove(0, 5, 1);
else if(vert==2 && horz<=6)
  computerMove(horz+1, 5, 0);
}It took me a bit to understand that you are looping with recursion here (and a bunch of these if/else statements) but that ending zero (aka computerMove(horz+1, 5, 0); ) looks wrong to me. Shouldn't that also be 1 there?