Crash whilst looping through Excel rows

Question

Hi Folks.
I have a program unit in forms which opens an XL spreadsheet and then reads the rows into the DB.
It loops though about 4800 rows and then the whole app dies and forms closes. No error is given.
The code is shown below. If anyone has any suggestions I'd love to hear them.
I have increased the size of the table.
Cheers
Simon
** Module Name :
** Package name :
** Author : Simon Gadd
** Creation Date: 01-NOV-2002
** Called By :     
** Calls :
** Description :
** Dev Location :
** Test Location:
** Modification     History:
** =====================
** Date      Author Description
** =============      =============== ======================================================
PROCEDURE XLSR_CLIENT_NORTM_DATA IS
     appID                    PLS_INTEGER;
     convID               PLS_INTEGER;
     docID                    PLS_INTEGER;
     buffer_1                         NUMBER(10);
     buffer_2                         VARCHAR2(100);               
     p_pmn                                   CHAR(5);     
     tap_sequence_no          NUMBER(5);
     sdr_gross                         NUMBER(12,3);
     next_row                              NUMBER(4);
     next_column                         NUMBER(4);
     last_row                              NUMBER(4) := 7560;
     last_column                         NUMBER(4);
     cell_reference               VARCHAR2(10);
     app_dir                                   VARCHAR2(100)     := 'C:\Program Files\Microsoft Office\Office\Excel.exe';
     data_source_dir               VARCHAR2(13)      := 'C:\FCSS\TEMP';
     data_source_file          VARCHAR2(21)      := 'NIUNORTM0209.xls';
     data_source                         VARCHAR2(50);
     dde_commmand                    VARCHAR2(200);
     r                                              VARCHAR2(100);
     txt                                             VARCHAR2(20);
     err_txt                                   VARCHAR2(100);
     a_pmn                                        CHAR(5) := 'NORTM';
valid_nmt                              BOOLEAN;          
BEGIN
     -- Clean out any existing data from XLS_C32
     DELETE FROM TAP_FILE_DELTA_AP WHERE PMN LIKE '%';
     DELETE FROM TAP_FILE_DELTA_AP_ERR WHERE PMN LIKE '%';
     COMMIT;
     SHOW_STATUS ('Attempting to open Excel');
     -- Start exel, load the source file
     data_source          := data_source_dir||'\'||data_source_file;
     dde_commmand     := app_dir||' '||data_source;
appID := DDE.App_Begin ( dde_commmand, DDE.APP_MODE_MINIMIZED);
UPDATE_STATUS ('Started Excel ');
-- Initiate a conversation with the source
docID := DDE.INITIATE ('EXCEL',data_source);
UPDATE_STATUS ('Opened source file ');
     -- Get the last row to read
     --last_row := get_last_cell(docID);
     FOR i IN 5 .. last_row LOOP
     -- Read the next row
               -- IF THE VALUE OF THIS CELL IS A VALID PMN CODE THEN
               -- READ THE REST OF THE LINE
               -- IF IT IS NOT, RECORD THE LINE NUMBER INTO THE CORRESPONDING ERROR
               -- TABLE. USERS NEEDS TO ANALYSE THE ERROR TABLES AND IF REQUIRED
               -- UPDATE THE VALID PMN CODES (OPERATORS TABLE)
          BEGIN
               next_row     := i;
               err_txt := 'Unable to get data from '||'R'||i||'C3';
               DDE.REQUEST(docID, 'R'||i||'C3', buffer_2,DDE.CF_TEXT,10000);
               err_txt := 'Unable to translate data';
               p_pmn := SUBSTR(buffer_2,1,5);
               SHOW_STATUS('Processing ' ||i||' '||p_pmn);
               err_txt := 'Unregistered PMN code ?';
          valid_nmt := is_the_pmn_valid (p_pmn);     
          IF (valid_nmt = TRUE) THEN          
                    DDE.REQUEST(docID, 'R'||i||'C3', buffer_2,DDE.CF_TEXT,1000);
                    p_pmn := SUBSTR(buffer_2,1,5);
                    err_txt := 'Reading TAP sequence no';
                    cell_reference := 'R'||i||'C5';                                    
                    tap_sequence_no := GET_CELL_NUMBER (docID, cell_reference);
                    err_txt := 'Reading GROSS SDR';
                    cell_reference := 'R'||i||'C6';                                    
                    sdr_gross := GET_CELL_NUMBER (docID, cell_reference);
                    -- ADD DATA TO TABLE TAP_FILE_DELTA_AP
               INSERT INTO TAP_FILE_DELTA_AP
                    VALUES
                         a_pmn, -- VC2(5)
                         p_pmn, -- VC2(5)
                         tap_sequence_no,-- NUM(10)
                         sdr_gross, --NUM(12,3)
                         NULL,
                         NULL
                    COMMIT;
                    -- let the user know what is going on
               r :=      'Row '||i||' > '||p_pmn;
                    SHOW_STATUS (r);               
          ELSE
               INSERT INTO TAP_FILE_DELTA_AP_ERR
                    VALUES
                              a_pmn,
                              p_pmn,
                              err_txt                         
               COMMIT;     
          END IF;
          EXCEPTION
               WHEN OTHERS THEN                    
                    INSERT INTO TAP_FILE_DELTA_AP_ERR
                         VALUES
                                   a_pmn,
                                   p_pmn,
                                   err_txt
               COMMIT;          
     END;
     END LOOP;
-- Terminate a conversation with the source               
     DDE.TERMINATE (docID);
DDE.App_End (appID);
SHOW_STATUS ('Done - Reading');     
SHOW_STATUS ('Calculating Differences - Please Wait');
XLSR_CLIENT_NORTM_DATA_PROCESS (a_pmn);
SHOW_STATUS ('Done - Calculating Differences');     
END;

Answer 1

Another way is to specify the range in select statement which can be done in two ways
http://getsetsql.blogspot.in/2012/01/using-ssis-load-data-to-excel-sheet-at.html
http://sqlserversolutions.blogspot.in/2009/02/selecting-excel-range-in-ssis.html
Please Mark This As Answer if it solved your issue
Please Vote This As Helpful if it helps to solve your issue
Visakh
My Wiki User Page
My MSDN Page
My Personal Blog
My Facebook Page