Cursor only updates every second row

Question

Hello Helpful Peoples
I have a table with a set of delivery dates, and am wanting to add a date on which a reminder flag should be raised by the system. The delivery dates are already populated and I'm wanting to add functionality where the end user can set how many days prior they are reminded.
I've opened a cursor to retrieve all the current due dates from my source table. When I loop through this cursor and update the reminder date and reminder text, my code is only updating every second row.
I can't work out why this code seems to skip a row every time it updates a record. Is anyone able to assist?
declare
v_date rep_delivery.reminderdate%type;
v_rownum number;
CURSOR reminder_cur
IS
SELECT DEL.DUEDATE
FROM REP_DELIVERY DEL
WHERE DEL.REP_ID = :P212_REP_ID:
FOR UPDATE OF DEL.REMINDERDATE;
begin
FOR x IN reminder_cur LOOP
FETCH reminder_cur INTO v_date;
EXIT WHEN reminder_cur%NOTFOUND;
v_date := v_date - to_number(:P212_REMDAYS);
UPDATE REP_DELIVERY DEL2
SET DEL2.REMINDERDATE = v_date
WHERE CURRENT OF reminder_cur;
UPDATE REP_DELIVERY DEL3
SET DEL3.REMINDERTEXT = :P212_DESCRIPTION
WHERE CURRENT OF reminder_cur;
END LOOP;
commit;
end;

Answer 1

Oolite,
Use this code:
DECLARE
   v_date   rep_delivery.reminderdate%TYPE;
   CURSOR reminder_cur
   IS
      SELECT        ROWID, duedate
               FROM rep_delivery
              WHERE rep_id = :p212_rep_id
      FOR UPDATE OF reminderdate;
BEGIN
   FOR x IN reminder_cur
   LOOP
      v_date := x.duedate;
      v_date := v_date - TO_NUMBER (:p212_remdays);
      UPDATE rep_delivery del2
         SET del2.reminderdate = v_date,
             del2.remindertext = :p212_description
       WHERE ROWID = x.ROWID;
   END LOOP;
   COMMIT;
END;and it will work for you.
Denes Kubicek
http://deneskubicek.blogspot.com/
http://htmldb.oracle.com/pls/otn/f?p=31517:1
-------------------------------------------------------------------