Declaring Arraylist

Question

in my application i want to manage just 1 arraylist i have 2 objects CD DVD i want to put all the values from those objects into 1 arraylist
here my arraylist declared in my itemcontroller class
private ArrayList<Item> items = new ArrayList<Item>();
each time i call my addItemCD and addItemDVD methods in my itemcontroller class
the arraylist size items.size()
seems to be stuck printin 1 every time, why aint it incrementin up every time i add a item..
even when i take away new key word from arraylist() eclipse throws error stops runing application...
any help much appreciated
cheers
package stage03;
import java.util.ArrayList;
import javax.swing.JOptionPane;
import stage02.CD;
import stage02.DVD;
import stage02.Item;
public class ItemController {
     private ArrayList<Item> items = new ArrayList<Item>();  // has a item collection
     public String title;
     public int time;
     public double price;
     public String comment;
     public String artist;
     public int track;
     public String dvdTitle;
     public int dvdTime;
     public String dvdComent;
     public Double dvdPrice;
     public String director;
     public String rate;
     public void addItemCD(String title, int time,double price, String comment,String artist,int track ){
          this.title = title;
          this.time = time;
          this.price = price;
          this.comment = comment;
          this.artist = artist;
          this.track = track;
          CD cd01 = new CD(null,0,0,null,null,0);
          cd01.setItemTitle(title);
          cd01.setItemPlayTime(time);
          cd01.setItemPrice(price);
          cd01.setItemComments(comment);
          cd01.setArtist(artist);
          cd01.setTrack(track);
          this.items.add(cd01);
          for (int i = 0; i < items.size(); i++){
          System.out.println(items.get(i));
          System.out.println(items.size());
}

Answer 1

georgemc wrote:
Yucca wrote:
@ the op...
Declaring an arraylist as type <item> is not gonna score you good points in future maintenance of your code. Java should be strongly typed and if you are giving
classes/objects the name of Item then you are headed for trouble. Some more meaningful names like PhoneBookEntry, PrivateContractor, LibraryBook etc. are what you should be aiming at.
In case you want to know why... a simple explanation is that it makes it easier for you to work with your own code and maintain code when the compiler starts throwing errors that point your to your class.
>@ the op...
Declaring an arraylist as type <item> is not gonna score you good points in future maintenance of your code. Java should be strongly typed and if you are giving
classes/objects the name of Item then you are headed for trouble. Some more meaningful names like PhoneBookEntry, PrivateContractor, LibraryBook etc. are what you should be aiming at.
In case you want to know why... a simple explanation is that it makes it easier for you to work with your own code and maintain code when the compiler starts throwing errors that point your to your class.Depends entirely on context. In the context of, say, a shopping cart, Item is a very obvious abstraction for both CD and DVD
Then my statement still stands. Surely ShoppingCartItem is more descriptive than Item. Are we talking about a office item of a shopping cart item or a household item? I am just saying that the earlier one decides to give classes meaningful names the better. And whats they point of a type-safe list if I can go stuff my items that are not for sale in your list of shopping cart items?