About ArrayList....

Question

Hi
Hope you are fine.
I have been stuck in a problem, can u plz help?
Hoping for a quick response, thanks alot.
Kind Regards,
fastian
code is here along with comments and problem descriptions.
public boolean getProductList(ArrayList prodList)
/* Caller has declared it as
ArrayList tempList=new ArrayList();
Assume we have 3 rows in DB as follows:
ID     name     category     purchasePrice     salePrice     quantity     threshold     expiry
1     milk     category 1     20     25     100     10     1/1/2007
2     cream     cat2     0     0     0     0 10     1/1/2007
3     sugar     cat3     0     0     0     0 10     1/1/2007
Also Assume that the "Product" class has declared as follows:
public String id;
public String name;
public String catagory;
public int purchasePrice;
public int salePrice;
public int quantity;
public int threshold;
String sql = "SELECT * FROM product";
        cm = new connectionMngr();
        Product prod=new Product();
        Product prod1=new Product();
        System.out.println(sql);
        try
            rs = cm.executeQuery(sql);
            int i=0;
            while(rs.next())
                prod.id= rs.getString("id");
                prod.name= rs.getString("name");
                prod.catagory= rs.getString("category");
                prod.purchasePrice= rs.getInt("purchasePrice");
                prod.salePrice= rs.getInt("salePrice");
                prod.quantity= rs.getInt("quantity");
                prod.threshold= rs.getInt("threshold");
                if(prodList.add((Object)prod))
                    //System.out.println(prod.id + " in DL");
                }/*Till this line the prodList contains valid rows*/
System.out.println(((Product)prodList.get(i)).id+"--Varify");/*The line above, prints 1, 2 , and
3 in three iterations*/
  i++;
            System.out.println("Prod successsfully added!!!!");
            cm.close();/*But here comes the source of problem, that is, all three lines print "3"
which is assumed to be the output of 3rd line ONLY*/
                System.out.println(((Product)prodList.get(0)).id+"--Varify22");
                System.out.println(((Product)prodList.get(1)).id+"--Varify22");
                System.out.println(((Product)prodList.get(2)).id+"--Varify22");
            return true;
        catch(Exception e)
            e.printStackTrace();
            System.out.println("Exception has been caught!!!!");
            cm.close();
             return false;
    }

Answer 1

Hi Dear,
Please user the following code to solve your problem
String sql = "SELECT * FROM product";
cm = new connectionMngr();
// Product prod=new Product(); //.........(1)
Product prod1=new Product();
System.out.println(sql);
try
rs = cm.executeQuery(sql);
int i=0;
while(rs.next())
Product prod=new Product(); // ................(2)
prod.id= rs.getString("id");
prod.name= rs.getString("name");
prod.catagory= rs.getString("category");
prod.purchasePrice= rs.getInt("purchasePrice");
prod.salePrice= rs.getInt("salePrice");
prod.quantity= rs.getInt("quantity");
prod.threshold= rs.getInt("threshold");
if(prodList.add((Object)prod))
//System.out.println(prod.id + " in DL");
I have corrected the code as above .Please check at line mark as (1) and (2)
thanks
sushil