Decode and case statement in the update..

Question

Its is more to it, but I want to check with you guys, the experts on this, this look busy to me, it should be a more simplify way of doing it, do you think will work
The government decide to change the ethnic codes, and we have to come with certain rules to in our report, anyway, do you think this will work? again It is more to it I declare my variables, this is just one part of the precedure.
BEGIN
      UTL_FILE.fclose_all;
      v_file_handle := UTL_FILE.fopen (v_out_path, v_out_file, 'a');
      UTL_FILE.put_line (v_file_handle,
                         CHR (10) || TO_CHAR (SYSDATE, 'DD-MON-YYYY HH:MI:SS')
      UTL_FILE.put_line (v_file_handle, 'Entering  spbpers_update');
      SELECT upd_spbpers_upd_cur IS
          spriden_pidm,
          szscapp_birth_state,
          szscapp_birth_city,
          DECODE(szscapp_hisp_or_latino_ind,Y,'2',N,'1'),
          DECODE(szscapp_hisp_or_latino_options,XCM,'2',CUB,'2',MEX,'2',PRI,'2',XSM,'2',ESP,'2',XOH,'2'),  
          DECODE(szscapp_amer_indn_alaska_opt,XAN,'1','1',XCW,'1',XCH,'1',XCK,'1',XNV,'1',XSX,'1'),         
          DECODE(szscapp_amer_indn_alaska_other,XON,'1') (,IND,'1',JPN,'1',KOR,'1',PAK,'1',PHL,'1',VNM,'1',XEA,'1',XIS,'1',XSA,'1'),  
          DECODE(szscapp_asian_options,IND,'1',JPN,'1',KOR,'1',PAK,'1',PHL,'1',VNM,'1',XEA,'1',XIS,'1',XSA,'1'),   ,          
          DECODE(szscapp_other_east_asia,(IND,'1',JPN,'1',KOR,'1',PAK,'1',PHL,'1',VNM,'1',XEA,'1',XIS,'1',XSA,'1'),            
          DECODE(szscapp_other_indian_subcont,XIS,'1'),    
          DECODE(szscapp_other_southeast_asia,XSA,'1'),   
          DECODE(szscapp_blk_or_afr_amer_opt,XAA,'1',XAF,'1',XCB,'1',XOA,'1'),     
          DECODE(szscapp_blk_or_afr_amer_other,XOA,'1'),   
          DECODE(szscapp_natve_hawaian_options,GUM,'1',XHI,'1',ASM,'1',XOP,'1'), 
          DECODE(szscapp_hawaiian_other,XOP,'1'),             
          DECODE(szscapp_white_options,XEU,'1',XME,'1',XOW,'1'),           
          DECODE(szscapp_white_other(XOW,'1')
     FROM
         saturn_midd.szscapp 
     WHERE
     spriden_id =  szscapp_id
     AND  spriden_ntyp_code = 'CAPL'
   IF upd_spbpers_upd_cur%ISOPEN
      THEN
         CLOSE upd_spbpers_upd_cur;
      END IF;
      OPEN upd_spbpers_upd_cur;
      LOOP
         FETCH upd_spbpers_upd_cur
          INTO v_pidm,v_birth_state,v_birth_city,v_latino_ind,v_latino_options,
               v_indn_alaska_opt,v_indn_alaska_other,v_asian_options,
               v_other_east_asia,v_other_indian_subcont,v_other_southeast_asia,
               v_blk_or_afr_amer_opt,v_blk_or_afr_amer_other,v_natve_hawaian_options,           
               v_hawaiian_other,v_white_options,v_white_other;
         EXIT WHEN upd_spbpers_upd_cur%NOTFOUND; 
         IF upd_spbpers_upd_cur%FOUND
           UPDATE  saturn.spbpers
                       set SPBPERS_ETHN_CODE  = CASE
               WHEN v_latino_ind            IS NOT NULL THEN (spbpers_ethn_code = v_latino_ind,spbpers_activity_date = sysdate)     
               WHEN v_latino_options        IS NOT NULL THEN (spbpers_ethn_code = v_latino_options,spbpers_activity_date = sysdate)
               WHEN v_indn_alaska_opt       IS NOT NULL THEN (spbpers_ethn_code = v_indn_alaska_opt,spbpers_activity_date = sysdate)
               WHEN v_indn_alaska_other     IS NOT NULL THEN (spbpers_ethn_code = v_indn_alaska_other,spbpers_activity_date = sysdate)
               WHEN v_asian_options         IS NOT NULL THEN (spbpers_ethn_code = v_asian_options,spbpers_activity_date = sysdate)
               WHEN v_other_east_asia       IS NOT NULL THEN (spbpers_ethn_code = v_other_east_asia,spbpers_activity_date = sysdate)             
               WHEN v_other_indian_subcont  IS NOT NULL THEN (spbpers_ethn_code = v_other_indian_subcont,spbpers_activity_date = sysdate)
               WHEN v_other_southeast_asia  IS NOT NULL THEN (spbpers_ethn_code = v_other_southeast_asia,spbpers_activity_date = sysdate)
               WHEN v_blk_or_afr_amer_opt   IS NOT NULL THEN (spbpers_ethn_code = v_blk_or_afr_amer_opt,spbpers_activity_date = sysdate)
               WHEN v_blk_or_afr_amer_other IS NOT NULL THEN (spbpers_ethn_code = v_blk_or_afr_amer_other,spbpers_activity_date = sysdate)
               WHEN v_natve_hawaian_options IS NOT NULL THEN (spbpers_ethn_code = v_natve_hawaian_options,spbpers_activity_date = sysdate)
               WHEN v_hawaiian_other        IS NOT NULL THEN (spbpers_ethn_code = v_hawaiian_other,spbpers_activity_date = sysdate)
               WHEN v_white_options         IS NOT NULL THEN (spbpers_ethn_code = v_white_options,spbpers_activity_date = sysdate)
               WHEN v_white_other           IS NOT NULL THEN (spbpers_ethn_code = v_white_other,spbpers_activity_date = sysdate)
               WHEN v_birth_state           IS NOT NULL THEN (spbpers_stat_code_birth = v_birth_state,spbpers_activity_date = sysdate)
               WHEN v_birth_city            IS NOT NULL THEN (spbpers_city_birth = v_birth_city,spbpers_activity_date = sysdate)
               WHERE spbpers_pidm = v_pidm;
              END
                 END IF;
      END LOOP;

Answer 1

Did the procedure compile ?
Doesn't look like a right Decode syntax.
DECODE (col1,'VAL1','This','VAL2','That','ElseThis')
means
--Psuedocode
IF col1 = 'VAL1' THEN 'This'
IF col1 = 'VAL2' THEN 'That'
ELSE 'ElseThis'You can use CASE statement Instead of DECODE
CASE
when      szscapp_amer_indn_alaska_other
     in ('XON','IND','JPN','KOR','PAK' ..... )  THEN '1'
when      szscapp_hisp_or_latino_options
     in ('XCM','CUB','MEX','PRI','XSM','ESP','XOH' ...) THEN '2'
END  SS