Download servlet

Question

Hi!
I'm building a servet to download files from a database. It works fine when you choose save in the IE dialog, but of you choose open you get an error message: File not found...
Here is my code (at least part of it):
OutputStream os = response.getOutputStream();
response.setContentType(file.getMimeType() + "; name=\"" + file.getName() + "\"");
response.setContentLength((int)file.getSize());
response.setHeader("Content-Disposition", "attachment; filename=\"" + file.getName() + "\"");
os.write(file.getContent());
os.close();Does anyone know how to fix this?
Thanks,
// Magnus

Answer 1

First of all, don't close the output stream. If you close the stream, how is IE supposed to read from it? Secondly, I wouldn't use os.write(file.getContent()). I recently wrote a downloadservlet for my organization. It downloads excel spreadsheets and works very well with the browser. It takes BLOBS from an oracle database. This is where the spreadsheets are saved.
package com.wellsfargo.servlet;
import javax.servlet.*;
import javax.servlet.http.*;
import java.io.*;
import java.sql.*;
* Servlet Class
* @web.servlet name="XLDownload" display-name="Name for XLDownload"
*              description="Description for XLDownload"
* @web.servlet-mapping url-pattern="/XLDownload"
* @web.servlet-init-param name="A parameter" value="A value"
public class XLDownloadServlet extends HttpServlet {
     protected void doGet(HttpServletRequest req, HttpServletResponse resp)
               throws ServletException, IOException {
          // TODO Auto-generated method stub
          doPost(req, resp);
     protected void doPost(HttpServletRequest req, HttpServletResponse resp)
               throws ServletException, IOException {
          ServletOutputStream os = null;
          Connection conn = null;
          PreparedStatement pstmt = null;
          String forwardPage = req.getParameter("forwardPage");
          try {
               String selectedDeal = req.getParameter("selectedDeal");
               // Set the content header information
               String contentDisposition = "attachment; filename=";
               // Connection to database
               conn = DBHelper.getConnection();
               // Query to get the data content
               String sql = "select * from redd.t_clpr_attachment where attachmentname = ?";
               pstmt = conn.prepareStatement(sql);
               pstmt.setString(1, selectedDeal);
               ResultSet rs = pstmt.executeQuery();
               if (rs.next()) {
                    Blob blob = rs.getBlob("attachmentdata");
                    String mimetype = rs.getString("mimetype");
                    System.out.println("found " + selectedDeal + " type "
                              + mimetype);
                    String filename = selectedDeal + ".xls";
                    int length = contentDisposition.length() + filename.length();
                    StringBuffer sb = new StringBuffer(length);
                    sb.append(contentDisposition).append(filename);
                    resp.setContentType(mimetype);
                    resp.setHeader("Content-Disposition", sb.toString());
                    InputStream in = blob.getBinaryStream();
                    os = resp.getOutputStream();
                    byte by[] = new byte[32768];
                    int index = in.read(by, 0, 32768);
                    while (index != -1) {
                         os.write(by, 0, index);
                         index = in.read(by, 0, 32768);
                    os.flush();
               } else {
                    System.out.println(selectedDeal + " does not exist");
          } catch (Exception e) {
               System.out.println(e.toString());
          } finally {
               if (os != null)
                    os.close();
               if (pstmt != null)
                    try {
                         pstmt.close();
                    } catch (Exception e) {
               if (conn != null)
                    try {
                         conn.close();
                    } catch (Exception e) {
               RequestDispatcher dispatcher = getServletContext()
                         .getRequestDispatcher(forwardPage);
               dispatcher.forward(req, resp);
}