Duplicate Records in Output

Question

I have a script which works fine however what I cant seem to work out is why I get duplicate records in the output. If anyone knows why it would be a great help/
My code is below:
Connect-QADService "domain.com"
Function CheckUserExistance {
if(Get-QADUser -Identity $Global:Sam) {
Write-Host "User Found: $Global:Sam"
$Example = $Global:Sam + "2"
$prompt = "This User Already Exists, Please Choose Another Name. (e.g. $Example)"
$Title = "Error"
Add-Type -AssemblyName microsoft.visualbasic
$popup = [Microsoft.VisualBasic.interaction]::MsgBox($prompt,"OkOnly,Critical", $title)
if ($popup -eq "Ok"){
$prompt = "Please Enter The Name To Create (All Lowercase e.g john.smith):"
$Title = "User To Create"
Add-Type -AssemblyName microsoft.visualbasic
$Global:Sam = [Microsoft.VisualBasic.interaction]::inputbox($prompt,$title)
if ($Global:Sam -eq ""){exit}
# The following Function is used to randomly generate complex passwords.
function New-Password
param
[int]$length,
[switch]$lowerCase,
[switch]$upperCase,
[switch]$numbers,
[switch]$specialChars
BEGIN
# Usage Instructions
function Usage()
Write-Host ''
Write-Host 'FUNCTION NAME: New-Password' -ForegroundColor White
Write-Host ''
Write-Host 'USAGE'
Write-Host ' New-Password -length 10 -upperCase -lowerCase -numbers'
Write-Host ' New-Password -length 10 -specialChars'
Write-Host ' New-Password -le 10 -lo -u -n -s'
Write-Host ' New-Password'
Write-Host ''
Write-Host 'DESCRIPTION:'
Write-Host ' Generates a random password of a given length (-length parameter)'
Write-Host ' comprised of at least one character from each subset provided'
Write-Host ' as a switch parameter.'
Write-Host ''
Write-Host 'AVAILABLE SWITCHES:'
Write-Host ' -lowerCase : include all lower case letters'
Write-Host ' -upperCase : include all upper case letters'
Write-Host ' -numbers : include 0-9'
Write-Host ' -specialChars : include the following- !@#$%^&*()_+-={}[]<>'
Write-Host ''
Write-Host 'REQUIREMENTS:'
Write-Host ' You must provide the -length (four or greater) and at least one character switch'
Write-Host ''
function generate_password
if ($lowerCase)
$charsToUse += $lCase
$regexExp += "(?=.*[$lCase])"
if ($upperCase)
$charsToUse += $uCase
$regexExp += "(?=.*[$uCase])"
if ($numbers)
$charsToUse += $nums
$regexExp += "(?=.*[$nums])"
if ($specialChars)
$charsToUse += $specChars
$regexExp += "(?=.*[\W])"
$test = [regex]$regexExp
$rnd = New-Object System.Random
do
$pw = $null
for ($i = 0 ; $i -lt $length ; $i++)
$pw += $charsToUse[($rnd.Next(0,$charsToUse.Length))]
Start-Sleep -milliseconds 20
until ($pw -match $test)
return $pw
# Displays help
if (($Args[0] -eq "-?") -or ($Args[0] -eq "-help"))
Usage
break
else
$lCase = 'abcdefghijklmnopqrstuvwxyz'
$uCase = $lCase.ToUpper()
$nums = '1234567890'
$specChars = '!@#$%^&*()_+-={}[]<>'
PROCESS
if (($length -ge 4) -and ($lowerCase -or $upperCase -or $numbers -or $specialChars))
$newPassword = generate_password
else
Usage
break
$newPassword
END
Import-Csv "C:\ExternalADAccounts.csv" |
ForEach-Object {
$First = $_.Forename
$Last = $_.Surname
$Password = New-Password -length 8 -upperCase -lowerCase -numbers -specialChars
$stuff = $_.stuff
$OU = "domain.com/ou"
$UPN = "$First.$Last@$stuff.domain.com"
$Global:Sam = "$First.$Last"
$Display = "$First $Last"
$Global:Sam = $Global:Sam -Replace " ", ""
$Global:Sam = $Global:Sam -Replace "'",""
$Count = $Global:Sam.Length
If($Count -gt "19"){
$Global:Sam = $First[0] + "." + $Last
Do{CheckUserExistance}
While(Get-QADUser -Identity $Global:Sam)
Write-Host "Creating User: $Global:Sam"
New-QADUser -FirstName $First `
-LastName $Last `
-DisplayName $Display `
-Name $Global:Sam `
-SamAccountName $Global:Sam.ToLower() `
-UserPassword $Password `
-UserPrincipalName $UPN.ToLower() `
-ParentContainer $OU
do{
$Test = Get-QADUser -Identity $Global:Sam
} until(Get-QADUser -Identity $Global:Sam)
Set-QADUser $Global:Sam -Title 'Non-Managed'
} | Select-Object @{label="DisplayName";expression={$Display}},@{label="SamAccountName";expression={$Global:Sam}}, @{label="Password";expression={$Password}}, @{label="Stuff";expression={$Stuff}} |
Sort-Object $Stuff |
Export-Csv "C:\NonManagedCreated.csv" -NoTypeInformation
Any help is greatly appreciated.
James

Answer 1

Hi James,
Please try the script below, which will use Psobject to format the output:
$output=@()##########
Import-Csv "C:\ExternalADAccounts.csv" |
ForEach-Object {
do{
$Test = Get-QADUser -Identity $Global:Sam
} until(Get-QADUser -Identity $Global:Sam)
Set-QADUser $Global:Sam -Title 'Non-Managed'
###########output
$Object = New-Object -TypeName PSObject
$object | Add-Member -Name 'DisplayName' -MemberType Noteproperty -Value $DisplayName
$object | Add-Member -Name 'SamAccountName' -MemberType Noteproperty -Value $Global:Sam
$object | Add-Member -Name 'Password' -MemberType Noteproperty -Value $Password
$object | Add-Member -Name 'Stuff' -MemberType Noteproperty -Value $Stuff
$output+=$Object
$output|select DisplayName,SamAccountName,Password,Stuff| Sort-Object Stuff |Export-Csv "C:\NonManagedCreated.csv" -NoTypeInformation
If there s anything else regarding this issue, please feel free to post back.
Best Regards,
Anna Wang