Enum confusion! Logical or in an if statement

Question

I'm using enums for the first time and I'm a bit confused.
I have:
if (type != (Board.PIT | Board.NORMAL | Board.PAIR | Board.ROT | Board.UNDER
                   Board.NORTH | Board.EAST | Board.SOUTH | Board.WEST) )
         isUpper = true;     Eclipse gives me the warning "The operator | is undefined for the argument type(s) boolean, Board.PIT."
Okay, so if I can't use |, what am I supposed to use instead? I could make a switch, but that would be very repetitive, so surely that's not the best way to do it:
switch(type) {
         case PIT: isUpper = true;
         case NORMAL: isUpper = true;...and so on.

Answer 1

| is the bitwise OR. You want the logical OR - ||[Operators in Java|http://java.sun.com/docs/books/tutorial/java/nutsandbolts/operators.html]
EDIT:
Scratch that. You want to rewrite your expression:
if ( type != Board.PIT && type != Board.NORMAL && type != Board.PAIR && type != Board.ROT && type != Board.UNDER
                   && type != Board.NORTH && type != Board.EAST && type != Board.SOUTH && type != Board.WEST)
         isUpper = true;
}//note that it's usually a good idea to include the braces for if/else/while/for even it's just one lineWith your original expression, you were asking Java to bitwise OR all the enum values and then see if the result was != type.
With my first suggestion, you would have been asking Java to logically or the enum values, which isn't correct, it's only valid for boolean or Boolean.
What you want to do is check if the value of type matches ANY of the enum values.
Edited by: nogoodatcoding on May 14, 2009 11:19 AM