Error in assigning value to local variable

Question

i am writing a stored procedure in which i have pass parameter if parameter value is zero then i assign a previously declared variable null else that value
syntax is this
create or replace
PROCEDURE usp_Add_Update_Insurance
p_CityID IN NUMBER DEFAULT NULL
as
v_CityID number(10,0);
begin
IF p_CityID = 0 THEN
BEGIN
v_CityID := NULL;-----giving error in this line
else
v_CityID:=p_CityID;
END;
END IF;
end
begin
///some query
end
please help someone

Answer 1

I think there is no added value by putting those Begin/End.
The simplest solution is just remove them
Create Or Replace
Procedure Usp_Add_Update_Insurance (
     P_Cityid In Number Default Null
) As
     V_Cityid Number(10,0);
Begin
     If P_Cityid = 0 Then    
          V_Cityid := Null;
     Else
          V_Cityid:=P_Cityid;
     End If;
     -- do something with V_Cityid    
End; The only reason for having Begin/End is if you want to catch some exceptions or perform some strange local variable declarations. But it does not seems to be case here.
MJ