Execution/ better performace on sql or java)

Question

hi experts,
i would like to began a topic on better performance or best pratice adf using sql or java codes.
basically am from Oracle forms - pl/sql background. well i knew about java and i have some awareness on Exception(my code maynt be consistent somtimes(run time) or or in other words sometimes ran into run time exceptions based on the user entries).
say as example: consider this scenario.
i had input lov named as employee, if the entered data is not avaiable i would throw an entered employee is not found.
basically i would like to follow this method.
method 1:
vo query :
Select * From sometable
Where Btx = :px1 And
:px2 Between Btbx And Btbxo And Btb_x=:pxamimpl.code
public void Validatex(String px ,String px1, oracle.jbo.domain.Date px2 ) {
       someVOImpl vo1 = (someVOImpl)this.getsomeRequest1();
        Row r = vo1.getCurrentRow();
        String Schx = (String)r.getAttribute("Btrxxx");
          if(Schxx.equals("somevalue"))
            xffVOImpl vo2 = (xffVOImpl)this.getxkEff1();
            vo2.setNamedWhereClauseParam("px", px.toString());
            vo2.setNamedWhereClauseParam("px1", px1.toString());
            vo2.setNamedWhereClauseParam("px2", px2);
            vo2.executeQuery();
             if(vo2.getEstimatedRowCount() == 0)
               throw new JboException("xxx Not Found");
       if(Scheme.equalsIgnoreCase("somevalue"))
        xxffVOImpl vo = (xxxffVOImpl)this.getxxkEff1();
        vo.setNamedWhereClauseParam("px", px);
        vo.setNamedWhereClauseParam("px1", px1);
        vo.setNamedWhereClauseParam("px2", px2);
        vo.executeQuery();
         if(vo.getEstimatedRowCount() == 0)
            throw new JboException("xxx Not Found");
       }this will exposed as method called in when valuechange listeners. it's work fine.
my question is :
if i wrote same thing in java like this. i think it take some more time than above methods sometimes exceptions comes out.
public void Validatex(String px ,String px1, oracle.jbo.domain.Date px2 ) {
some vos... as like same of which i mentioned above
using iterator iterate each and every row.
try{
for (.......)
if(...)
else
} } catch()
}which would be best practice.? i hope that iterating each and every row taking little bit amount of time.
but i feel that method1 without any exception and smarter time produce result.
so people suggest me ? where am which would be better approach.
thanks&&REgards
adf7.

Answer 1

Hi,
before went into testing. could please tel me. how to get/display both of the method time taken to execute and some memory consumption.See if this helps..
    public HashMap doSomethingInProc(Long serialNo, Long custNo) {
        HashMap map = new HashMap();
        CallableStatement cs = null;
        String stmt = "sy_pkg_xx.p_doSomethingInProc(?,?,?,?)";
        logger.info("execute " + stmt);
        try {
            cs = getCurrentConnection().prepareCall("begin " + stmt + "; end;");
            cs.registerOutParameter("O_2", OracleTypes.VARCHAR);
            cs.registerOutParameter("O_1", OracleTypes.NUMBER);
            cs.setLong("I_SerialNo", serialNo);
            cs.setLong("I_CustNo", custNo);
            Long start = System.currentTimeMillis();
            cs.execute();
            Long end = System.currentTimeMillis();
            logger.info("time taken to execute " + stmt + " : " + (end - start) + " ms.");
            map.put("1", cs.getString("O_1"));
            map.put("2", cs.getLong("O_2"));
            logger.info("map : " + map.toString());
        } catch (SQLException e) {
            throw new JboException(e);
            }finally{
            if(cs!=null){
                try{
                    cs.close();
                }catch(SQLException ex){
        return map;
    private Connection getCurrentConnection() {
        Statement st = null;
        try {
            st = getDBTransaction().createStatement(0);
            return st.getConnection();
        } catch (SQLException s) {
            s.printStackTrace();
            return null;
        } finally {
            if (st != null)
                try {
                    st.close();
                } catch (SQLException s2) {
    }The main code is
            Long start = System.currentTimeMillis();
            cs.execute();
            Long end = System.currentTimeMillis();
            logger.info("time taken to execute " + stmt + " : " + (end - start) + " ms.");In fact i say that every body should use this approach while executing any procedure or function as it helps us to track which part of application is running slow..
Hope this helps !!!
Regards,
Edited by: Santosh Vaza on Jul 16, 2012 3:50 PM