FireTableRowsInserted(ind,ind) without adding a new row consequnces?

Question

Hello all,
I am looking at code where someone is calling fireTableRowsInserted(index,index) when there is no new row being inserted or deleted?
What are the consequences when the above happens?
Does anything abnormal happen?
Method a
if(bool)
fireTableRowsInserted(0,0);
else if(bool2)
else if(bool3)
fireTableRowsInserted(0,0);
What will happen if bool is true?
fireTableRowsInserted will be called twice but there is only one row added!
Edited by: javapunt on Jun 24, 2008 9:08 AM
Edited by: javapunt on Jun 24, 2008 10:03 AM

Answer 1

camickr wrote:
When you fire an event from the TableModel you are just notifying the table that data has changed so the table can repaint itself.
So unless you have some code based on that event, nothing abnormal should happen, other than the table repainting itself twice.
unfortunately that's not entirely true (or maybe you have a different notion of "abnormal" than me ;-)
- in all versions: the selection gets corrupted.
- since 1.6: throws an ArrayIndexOutOfBounds on sorting
As a very general, very basic rule: never-ever fire bogus events - there's always at least one listener which gets confused. This rule applies especially to events which notify about a structural change (like inserts, deletes). Code which does is broken and must be fixed asap. Plus, the only collaborator to call fireXX should be the model itself, consequently the scope of any fire methods should be narrowed to at least protected (not possible for those core classes with public methods - which was a design accident ;-)
Attached is a small example (which should have come with your question, javapunt, hint, hint ...) to show the side-effects
HTH
Jeanette
* Created on 25.06.2008
package org.jdesktop.swingx.table;
import java.awt.event.ActionEvent;
import java.util.Locale;
import javax.swing.AbstractAction;
import javax.swing.Action;
import javax.swing.Box;
import javax.swing.JButton;
import javax.swing.JComponent;
import javax.swing.JFrame;
import javax.swing.JScrollPane;
import javax.swing.JTable;
import javax.swing.SwingUtilities;
import javax.swing.table.AbstractTableModel;
public class FireBogeyInsert {
    private JComponent createContent() {
        JComponent content = Box.createVerticalBox();
        final Locale[] locales = Locale.getAvailableLocales();
        final AbstractTableModel model = new AbstractTableModel() {
            @Override
            public int getColumnCount() {
                return 3;
            @Override
            public int getRowCount() {
                return locales.length;
            @Override
            public Object getValueAt(int rowIndex, int columnIndex) {
                switch (columnIndex) {
                case 0:
                    return locales[rowIndex].getDisplayName();
                case 1:
                    return locales[rowIndex].getDisplayLanguage();
                case 2:
                    return locales[rowIndex].getDisplayCountry();
                return null;
        Action fireInsert = new AbstractAction("fire bogey insert") {
            @Override
            public void actionPerformed(ActionEvent e) {
                model.fireTableRowsInserted(0, 0);
        JTable table = new JTable(model);
        table.setAutoCreateRowSorter(true);
        table.setRowSelectionInterval(0, 0);
        content.add(new JScrollPane(table));
        content.add(new JButton(fireInsert));
        return content;
    public static void main(String[] args) {
        SwingUtilities.invokeLater(new Runnable() {
            public void run() {
                JFrame frame = new JFrame("");
                frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
                frame.add(new FireBogeyInsert().createContent());
                frame.setLocationRelativeTo(null);
                frame.pack();
                frame.setVisible(true);
}