FOX Formula does not calculate ratio

Question

Dear guys,
We are customizing the process for calculation of data which will be used for elimination of profit/loss in stock and revenue and expenses during consolidation of manufacturing companies group's financials.
At the moment we're customizing a FOX Formula for calculation of share of revenue from (source) materials sold to other companies inside the group and used for production of other (target) materials and total revenue received for each of these source products.
We use the following key figures and characteristics in the level:
0CS_VERSION     Consolidation (End-Result) Version
0CURKEY_GC     Currency Key for Group Currency
0FISCPER3     Posting period
0FISCVARNT     Fiscal year variant
0FISCYEAR     Fiscal year
0MOVE_TYPE     Movement Type
MPZZFKOD     Source Material Consolidation Code
PRODUCER     Company - Producer
SL_TYPE          Sales Location Type: Export/Domestic
TRG_COMP     Target Company
ZZFKOD          Target Material Consolidation Code
COGSGGC     COGS Gross GC
SREVENGC     Revenue Statistical GC
VS_SUPSH     VS Supplier Share
MPZZFKOD ZZFKOD     TRG_COMP  COGSGGC    SREVENGC      VS_SUPSH
2651     #      #           0             10.070.099     0,00000
2651     2703      3           21.000              0                     0,00000
2651     2704      3           19.116              0                     0,00000
We need to calculate a ratio of COGSGGC for each ZZFKOD and total SREVENGC. (21.000/10.070.099 and 19.116/10.070.099).
Below is a program code:
DATA SUM_KF TYPE F.
DATA SHARE  TYPE F.
DATA FLAG   TYPE I.
DATA KEYFIG TYPE F.
DATA L_ENTRIES TYPE I.
*DATA L_ZZFKOD TYPE  ZZFKOD.
*L_ZZFKOD = VARV(TMCONSCD).
*DATA L_MPZZFKOD TYPE MPZZFKOD.
DO.
IF FLAG > 1.
EXIT.
ENDIF.
ENDDO.
L_ENTRIES = VARC(VERSION).
*SUM_KF = 0.
*FOREACH L_MPZZFKOD.
SUM_KF = SUM_KF +
*{SREVENGC,'#','#'}.
*ENDFOR.
*SUM_KF = SUM_KF + {SREVENGC,'#','#'}.
*FOREACH L_MPZZFKOD.
SHARE = {COGSGGC,L_MPZZFKOD,'#'} / SUM_KF.
{VS_SUPSH,L_MPZZFKOD,'#'} = SHARE.
*ENDFOR.
*SUM_KF = SUM_KF + {SREVENGC,'#'}.
*FOREACH L_ZZFKOD.
*SUM_KF = SUM_KF + {SREVENGC,L_ZZFKOD}.
*ENDFOR.
*DO.
*IF FLAG > 1.
*EXIT.
*ENDIF.
*ENDDO.
*FOREACH L_ZZFKOD.
*SHARE = {COGSGGC,L_ZZFKOD} / SUM_KF.
*{VS_SUPSH,L_ZZFKOD} = SHARE.
*ENDFOR.
Could you help us to understand the reason the program does not work?
Mila

Answer 1

Mila,
I see some issues with your logic:
1. you are not using fiscal period at all but you declared it.  Is it in your field to be changed or just in your field for condition or package / filter?  Also version 0CS_VERSION?
2. What is the purpose of Flag > 1?
3. You are very confused in your looping logic...  You need to think more logically about what you want to do
4. What is the 3rd items in your fields to be changed?  If you don't use it or change based on it in the FOX, remove it from fields to be changed.
You want to process for each source material MPZZFKOD (I persume for each fiscal period) and within each source material MPZZFKOD, you want to loop through each target material ZZFKOD.
Note: the items in the {} depends on the order of your to be changed characteristics
Give this (or a similar version to this) a whirl.
DATA SUM_KF TYPE F.
DATA SHARE TYPE F.
DATA L_MPZZFKOD TYPE MPZZFKOD.
DATA L_ZZFKOD TYPE ZZFKOD.
FOREACH L_MPZZFKOD.
  SUM_KF = {SREVENGC,L_MPZZFKOD,'#'}.
  FOREACH L_ZZFKOD.
     SHARE = {COGSGGC,L_MPZZFKOD,L_ZZFKOD} / SUM_KF.
     {VS_SUPSH,L_MPZZFKOD,L_ZZFKOD} = SHARE.
  ENDFOR.
ENDFOR.
You can even do without the share if you map it directly.
     {VS_SUPSH,L_MPZZFKOD,L_ZZFKOD}
            = {COGSGGC,L_MPZZFKOD,L_ZZFKOD} / SUM_KF.
Hope this helps.  Sounds like you need to read up on some documents on FOX and/or practice with it.
Mary