Frames (Cannot Edit a Record)

Question

I have a program.
It displays the Form. On the form are the various controls i.e text fields and buttons.
They ask the user to enter the name and phone nos.
Their are also add record button, find record button, delete record button and save record button.
My problem is that when I am suppose to edit a record it does not do so.
Please help.
I am using java version 1.3.1
<---------------------------------------------------------------------->
Here is the Phone.java file
<---------------------------------------------------------------------->
public class Phone
public Phone(long aPhoneNo, String aName)
phoneNo = aPhoneNo;
name = aName;
public long getPhoneNo()
return phoneNo;
public String getName()
return name;
private long phoneNo;
private String name;
<---------------------------------------------------------------------->
Here is the PhoneBook.java file
<---------------------------------------------------------------------->
import java.util.ArrayList;
public class PhoneBook
public PhoneBook()
records = new ArrayList();
public void addPhone(Phone aPhone)
records.add(aPhone);
public long findPhone(String name)
long phoneNo;
Phone p;
for (int i = 0; i < records.size(); i++)
p = (Phone)records.get(i);
if (name.equals(p.getName()))
return phoneNo = p.getPhoneNo();
return 0;
public void deletePhone(Phone aPhone)
long phone1, phone2;
String name1, name2;
for (int i = 0; i < records.size(); i++)
Phone p = (Phone)records.get(i);
phone1 = p.getPhoneNo();
name1 = p.getName();
phone2 = aPhone.getPhoneNo();
name2 = aPhone.getName();
if ((phone1 == phone2) && name1.equals(name2))
records.remove(i);
public void editPhone(long phoneNo, String name)
Phone p = new Phone(phoneNo, name);
long phone1, phone2;
String name1, name2;
for (int i = 0; i < records.size(); i++)
Phone pObj = (Phone)records.get(i);
phone1 = p.getPhoneNo();
name1 = p.getName();
phone2 = pObj.getPhoneNo();
name2 = pObj.getName();
if ((phone1 == phone2) && name1.equals(name2))
records.set(i, p);
private ArrayList records;
<---------------------------------------------------------------------->
Here is the PhoneGui.java file
<---------------------------------------------------------------------->
import javax.swing.JLabel;
import javax.swing.JButton;
import javax.swing.JTextField;
import javax.swing.JPanel;
import java.awt.GridLayout;
import java.awt.BorderLayout;
import java.awt.Dimension;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import javax.swing.JFrame;
* <p>Title: Assignment No. 3</p>
* <p>Description: </p>
* <p>Copyright: Copyright (c) 2003</p>
* <p>Company: Humber College</p>
* @author Gurjeet Singh
* @version 1.0
public class PhoneGui extends JFrame
public PhoneGui()
objectPhoneBook = new PhoneBook();
createEnterDataPanel();
createButtonsPanel();
public void createEnterDataPanel()
JPanel enterDataPanel = new JPanel();
enterDataPanel.setLayout(new GridLayout(2, 2));
JLabel lblName = new JLabel("Enter a Name : ");
txtName = new JTextField(50);
JLabel lblPhone = new JLabel("Enter a Phone# : ");
txtPhone = new JTextField(12);
enterDataPanel.setPreferredSize(new Dimension(PANEL_WIDTH, PANEL_HEIGHT));
enterDataPanel.add(lblName);
enterDataPanel.add(txtName);
enterDataPanel.add(lblPhone);
enterDataPanel.add(txtPhone);
getContentPane().add(enterDataPanel, BorderLayout.NORTH);
public void createButtonsPanel()
JPanel buttonsPanel = new JPanel();
buttonsPanel.setPreferredSize(new Dimension(PANEL_WIDTH, PANEL_HEIGHT));
buttonsPanel.setLayout(new GridLayout(1, 4));
JButton buttonAddRecord = new JButton("Add a Record");
JButton buttonFindRecord = new JButton("Find and display");
JButton buttonDeleteRecord = new JButton("Delete");
JButton buttonEditRecord = new JButton("Save");
buttonsPanel.add(buttonAddRecord);
buttonsPanel.add(buttonFindRecord);
buttonsPanel.add(buttonDeleteRecord);
buttonsPanel.add(buttonEditRecord);
getContentPane().add(buttonsPanel, BorderLayout.SOUTH);
class ButtonListener1 implements ActionListener
public void actionPerformed(ActionEvent event)
phoneNo = Long.parseLong(txtPhone.getText());
name = txtName.getText();
objectPhoneBook.addPhone(new Phone(phoneNo, name));
ButtonListener1 listener1 = new ButtonListener1();
class ButtonListener2 implements ActionListener
public void actionPerformed(ActionEvent event)
name = txtName.getText();
phoneNo = objectPhoneBook.findPhone(name);
if (phoneNo != 0)
txtPhone.setText("" + phoneNo);
else
txtPhone.setText("No Record found");
ButtonListener2 listener2 = new ButtonListener2();
class ButtonListener3 implements ActionListener
public void actionPerformed(ActionEvent event)
name = txtName.getText();
phoneNo = Long.parseLong(txtPhone.getText());
objectPhoneBook.deletePhone(new Phone(phoneNo, name));
ButtonListener3 listener3 = new ButtonListener3();
class ButtonListener4 implements ActionListener
public void actionPerformed(ActionEvent event)
name = txtName.getText();
phoneNo = Long.parseLong(txtPhone.getText());
objectPhoneBook.editPhone(phoneNo, name);
ButtonListener4 listener4 = new ButtonListener4();
buttonAddRecord.addActionListener(listener1);
buttonFindRecord.addActionListener(listener2);
buttonDeleteRecord.addActionListener(listener3);
buttonEditRecord.addActionListener(listener4);
private static final int PANEL_WIDTH = 520;
private static final int PANEL_HEIGHT = 100;
private JTextField txtName;
private JTextField txtPhone;
private long phoneNo;
private String name;
PhoneBook objectPhoneBook;
<---------------------------------------------------------------------->
Here is the PhoneGui.java file
<---------------------------------------------------------------------->
import javax.swing.JFrame;
public class TestPhoneGui
public static void main(String[] args)
JFrame frame = new PhoneGui();
frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
frame.show();
frame.pack();

Answer 1

Ok, first, don't post so damn much, it makes it really annoying to read.
public void editPhone(long phoneNo, String name)
Phone p = new Phone(phoneNo, name);
long phone1, phone2;
String name1, name2;
for (int i = 0; i < records.size(); i++)
Phone pObj = (Phone)records.get(i);
phone1 = p.getPhoneNo();
name1 = p.getName();
phone2 = pObj.getPhoneNo();
name2 = pObj.getName();
if ((phone1 == phone2) && name1.equals(name2))
records.set(i, p);
} // end if
} // end for
} // end editPhone()Okay, you are correct... this method DOES do nothing.
Why should it? It creates a new Phone object, compares that against each of the existing Phone objects, if it finds one that matches, it replaces it with THE SAME ONE.
It might be a better idea to either make
public void editPhone(long phoneNo, String name)
so that when it finds an entry that matches, it prompts for user input for a new phoneNo and name.
That, or make
public void editPhone(Phone toFind, Phone toReplace)
which I think is simplest and most obvious.
I personally would have made a method
PhoneBook.editPhone(Phone toFind)
editPhone(toFind.getPhoneNo(), toFind.getName());
PhoneBook.editPhone(long number, String name)
for (int i = 0; i < records.size(); i++)
Phone p = (Phone)records.get(i);
if ((number == p.getNumber()) && name.equals(p.getName()))
p.edit();
return;
} // end if
} // end for
} // end editPhone()And have a Phone.edit() method, but that would be most suited to a console app.
You need to have a look at how you want to edit a phonebook entry, and what it was you were currently doing.
Good luck
Radish21