"FROM" in a string in a LOV query

An LOV query such as this:
select c001 || ' from ' d, seq_id r
from apex_collections
where collection_name = 'ABC'
order by 1produces this error when trying to save the LOV: "LOV query is invalid, a display and a return value are needed, the column names need to be different. If your query contains an in-line query, the first FROM clause in the SQL statement must not belong to the in-line query."
Splitting the string into two pieces (e.g., ' fr' || 'om ') avoids the problem. Looks like the parser isn't tokenizing strings before looking for keywords.
Rodney

Rodney,
Looks like it just doesn't like the space at the beginning.
That said, this worked for me:
SELECT c001||chr(32)||'from ' d, seq_id r
FROM apex_collections
WHERE
(collection_name = 'ABC'
ORDER BY 1
Chad

Similar Messages

LOV query is invalid, a display and a return value are needed

hello - i am having this issue and can't get around this when creating a popup LOV based on sql.
below is LOV query. as you see the view has only two columns. I tried various ways by giving alias to columns in query but nothing works. What did I miss here?
select description,inventory_item_id from xx_apex_inv_v
1 error has occurred
LOV query is invalid, a display and a return value are needed, the column names need to be different. If your query contains an in-line query, the first FROM clause in the SQL statement must not belong to the in-line query.

Did you try it like this?
select description d, inventory_item_id v from xx_apex_inv_v

How to accessing current row report column value in Lov Query?

Hi,
which access methods (eg. bind variables, substitutions, ...) for getting the current row report column value can be used in the "Lov Query" property of a report column?
As what I know of and what I have read on the forum there are no bind variables for the report columns. For the "Link Text" property it seems that the column values exist as substitution strings (#COLUMN_NAME#). But they don't work in the Lov Query. => And would be good because of a hard parse each time the Lov query is executed.
The following post (Re: Simulating a correlated sub query in lov
is showing a solution to use package variables for temporary storage of the referenced value, but the only problem with that solution is that if a new record is added with the "Add rows to tabular form" process the package variable still contains the value from the last queried row! Is there a way (variable, APEX package, ...) to determine if the lov query is executed for a new record so that the package can return null?
I know that I could write the package in a way that the value is immediately cleared when lov_pkg.keyval is called (one time read), but then I would have to create several variables if I'm accessing the value multiple times in the query or in another query => I think an one time read solution would be very obscurely.
Thanks for your help
Patrick
http://inside-apex.blogspot.com

Hi Patrick,
I agree that it's a waste to continually use Ajax to go back to the server to get the contents of a dynamic select list.
There are no bind variables for any row item - but what you do have, as per my previous post, is the value of the data entered by the user in the first row. You can pass this into your application process (using get.add("VARIABLENAME", value)), which can use it to retrieve the correct LOV in your Ajax code - this will give you a "bind variable" that your process can use.
What you could do, however, is generate hidden select lists on your page - one for each possible LOV list and replace the contents of the new row's select list with the contents of the appropriate hidden select list. This is easy to do with javascript (using innerHTML functions). Obviously, though, the usefulness of this depends on the number and size of the select lists.
Even if you don't generate them to start with, you can keep a copy of any select lists returned by Ajax in the DOM for use on new rows. So, if you have retrieved a select list, you will have a copy of it in DOM which you can then copy into the new row. If you don't have the list in DOM, use Ajax to get it, store a copy of it and copy it into the new row.
Which method you use will depend on the number/size of select lists needed. If they are few in number and/or size, I would suggest generating hidden lists. If they are large, use Ajax to get them once, store them and then retrieve them from the DOM when needed.
There is another thread here where Arie recommends going to the server every time to make sure you get the most up-to-date data for the lists. If you want to follow this advice, for this reason, use get.add("VARIABLENAME", value) to pass the value to your process. If this is not an issue, you can use one of the other methods I outlined above.
Regards
Andy

BUG ? : ADF creating extra VO instance using bind variables in a LOV query

ADF 11.1.1.1.0
After "playing around" with bind variables Setting bind variables in view objects for LOV I've come across something strange that I've reproduce using the HR schema and tables Employees and Departments. Its a bit long but here goes :
Using the HR schema tables departments and employeesI'm trying to create a LOV (selectOneChoice) for the
employee department, the LOV having a bind variable that limits the values returned in this case returning only DepartmentId = 50
I've create a VO lovDepartment (not based on an EO) with the following query :
SELECT Departments.DEPARTMENT_ID,
       Departments.DEPARTMENT_NAME,
       Departments.MANAGER_ID,
       Departments.LOCATION_ID
FROM DEPARTMENTS Departments
where DEPARTMENT_ID = :pDeptIdA LOV has been defined on the DepartmentId attribute of the EmployeesView.
The lovDepartmentImpl overrides the executeQueryForCollection to set the bind variable value.
    @Override
    protected void executeQueryForCollection(Object object, Object[] object2,
                                             int i) {
        setNamedWhereClauseParam("pDeptId", "50");
        super.executeQueryForCollection(object, object2, i);
    }When using an ADF form to create a new employee the DepartmentId lov is empty.
Enabling SQL tracing shows the following :
[370] _LOCAL_VIEW_USAGE_model_EmployeesView_lovDepartment1_0 ViewRowSetImpl.doSetWhereClause(-1, pDeptId, null)
[371] _LOCAL_VIEW_USAGE_model_EmployeesView_lovDepartment1_0 ViewRowSetImpl.execute caused params to be "un"changed
[372] Column count: 4
[373] _LOCAL_VIEW_USAGE_model_EmployeesView_lovDepartment1_0 ViewRowSetImpl.doSetWhereClause(-1, pDeptId, null)
[374] _LOCAL_VIEW_USAGE_model_EmployeesView_lovDepartment1 ViewRowSetImpl.setNamedWhereClauseParam(pDeptId, 50)
[375] ViewObject: _LOCAL_VIEW_USAGE_model_EmployeesView_lovDepartment1 Created new QUERY statement
[376] _LOCAL_VIEW_USAGE_model_EmployeesView_lovDepartment1>#q computed SQLStmtBufLen: 235, actual=195, storing=225
[377] SELECT Departments.DEPARTMENT_ID,
       Departments.DEPARTMENT_NAME,
       Departments.MANAGER_ID,
       Departments.LOCATION_ID
FROM DEPARTMENTS Departments
where DEPARTMENT_ID = :pDeptId
[378] Bind params for ViewObject: _LOCAL_VIEW_USAGE_model_EmployeesView_lovDepartment1
[379] For RowSet : _LOCAL_VIEW_USAGE_model_EmployeesView_lovDepartment1_0
[380] Binding null of type 12 for "pDeptId"
[381] No Resource Bundle found but null value id:LOV_DepartmentId_LOVUIHints_NullValueId is defined in an ListBinding Definition.It would seem that 2 lovDepartment instances are used one at line 370 LOCALVIEW_USAGE_model_EmployeesView_lovDepartment1_0
and one at line 374 LOCALVIEW_USAGE_model_EmployeesView_lovDepartment1
The one at line 374 LOCALVIEW_USAGE_model_EmployeesView_lovDepartment1 gets the variable bound at line 374
however LOCALVIEW_USAGE_model_EmployeesView_lovDepartment1_0 gets a null value and would explain the empty LOV
Can anybody explain what is happening here ? (and how to use bind variables in LOV queries)
Regards
Paul
(bump)
Edited by: Paul (MITsa) on Jul 14, 2009 10:46 AM
I've now tried all types of LOV from ChoiceList to Radio groupe by testing the application module - none of them work.....
Edited by: Paul (MITsa) on 14-Jul-2009 22:52

when you rinvoke executeQueryForCollection the bind variables are allready set and they exist in Object[] object2 method parameters.
in order to change them you need something like:
private void changeGenericBindVariable(Object[] params, String paramName, Object paramValue) {
for (int i = 0; i < params.length; i++) {
if (paramName.equals(((Object[])params)[0].toString()))
((Object[])params[i])[1] = paramValue;
* executeQueryForCollection - overridden for custom java data source support.
protected void executeQueryForCollection(Object qc, Object[] params,
int noUserParams) {
changeGenericBindVariable(params, "pDeptId", "50")
super.executeQueryForCollection(object, object2, i);
But its better to set bind variables before you executeQueryForCollection. like when you invoke LOV.
For cascading LOVs and the problems i have check:
[http://adfbugs.blogspot.com/2009/07/jdeveloper-11-r1-cascading-lov-bugs.html]

How to bind variables to a LOV query

Hi,
I have a page with a messageLOVInput field. I have attached an external LOV with it. The query attached to the LOVregion has a bind parameter which should be replaced by the logged in Person's Business Group ID.
I have done all the required LOV Mappings etc for a normal LOV.
If I hardcode the business group ID and then run the page, its working fine. But if I want to bind the businessgroup id at runtime, I am getting an error saying "all variables not bound"
I tried the usual method of calling some initMethod in AM from the CO of the external LOV region, and then calling some initQuery in the VO to set the bind parameter, but this doesn't work.
How do I bind variables at runtime with the LOV VO ?
Thanks, in advance !!
-Debojyoty

Hi Deb,
Heres what you gotta do.
By default the query is going to be executed in the EO . In case of a query without any bind variables this works fine. This is because for LOV EO's one doenst' have to explicitly call the the executequery method. In your case, there is one bind variable that needs to be set, before any query is fired, either implicitly or explicitly else you are going to get Bind variable not set exception.
1. Define an init query method in your EOImpl.
public void initQuery(String p_param)
setWhereClause(null);
setWhereClauseParams(null);
setWhereClauseParam(0,p_param);
2. Define a method for initializing the query. In your AM IMPL for the LOV, recieve the EOIMPL and call the initquery method and pass the parameter that you would to base the query upon.
3. In the CO for the LOV, call the AMimpl Method defined in step 2.
Let me know if this works ? If you still have problems, I will post some sample code.
Rgds,
Venkatesh
Message was edited by:
Venkatesh

Binding a variable to an LOV query, not working... Urgent!

Hi,
Based on a column value(which gets populated at runtime), in a table, the LOV query for another column in the same table, should be restricted with this value.
1. My LOV is based on a VO.
Lov query is
SELECT ped.full_name as employee_name,
ped.employee_number as employee_number
FROM p_employee_details ped
WHERE ped.value = 'Y' and ped.work in (:1, 'Both')
2. For binding the variable, I have a method in VOImpl of the LOV.
public void initQuery(String p_param)
setWhereClauseParams(null);
setWhereClauseParam(0,p_param);
3. This method is called in the LOVAMImpl
public void initializeVO(String p_param)
LovVOImpl lovVO = (LovVOImpl)getLovVO1();
lovVO.initQuery(p_param);
4. In the CO for the LOV RN, the LOVAMimpl Method defined in step 3 is called.
public void processRequest(OAPageContext pageContext, OAWebBean webBean)
super.processRequest(pageContext, webBean);
OAApplicationModule lov_am = (OAApplicationModule) pageContext.getApplicationModule(webBean);
Dictionary lov_dict = pageContext.getLovCriteriaItems();
String lov_criteria = (String) lov_dict.get("work");
Serializable lov_params[] = {lov_criteria};
lov_am.invokeMethod("initializeVO",lov_params);
Here "work" is the column in the table whose value is needed for binding the lov query
But i am still getting an error saying not all variables bound.:
Developer Mode Exception : Lov Input should by default be the queryable criteria and Result.
I don't know what else to do.
Thanks in advance

HI,
Here the code giving on starting of the thread will work,only problem is lov mapping over here which was same as mine , u have to create one more lov mapping which will have criterial item same as the field on which lov is based.
Thanks

Dynamic LOV - Function returning LOV query

Hi All,
For some reason I can not write a generic LOV query and want to edit where clause dynamically. Is there a way to achieve it.
My LOV query will be
'SELECT D,R FROM LOV WHERE ID IN (1,2,3)' for one person and
'SELECT D,R FROM LOV WHERE ID IN (4,5,6)' for another person.
Here entire string "1,2,3" or "4,5,6" is from a page item say :P1_ID_LIST and I can not use the bind variable like 'SELECT D,R FROM LOV WHERE ID IN (:P1_ID_LIST)'.
If I have the option of function returning the LOV query I can use
return 'SELECT D,R FROM LOV WHERE ID IN (' || :P1_ID_LIST || ')'
Does there a way to acheive in Apex?
Thanks
Balaji

See Re: Search on a typed in list of values for at least part of the answer.
Scott

Invalid LOV query error

I am trying to modify a query for LOV page item but get an Invalid LOV query error when trying to Apply Changes to my page(query however works in SQL*Plus)
I am trying to change the date format of query result to MON YYYY.
Original query that works:
select distinct bill.BILLED_DATE display_value, bill.BILL_ID return_value
from BILL;
New Query that fails in APEX (but works in SQL*Plus)
select distinct to_char(bill.BILLED_DATE, 'MON YYYY') display_value,
bill.BILL_ID return_value from BILL;
Anyone have any idea what I need to do to make this work?
"1 error has occurred
LOV query is invalid, a display and a return value are needed, the column names need to be different. If your query contains an in-line query, the first FROM clause in the SQL statement must not belong to the in-line query"

Strange, this lov does work and is no different than yours:
select distinct to_char(sysdate,'MON YYYY') disp, 1 retval from dual
What are the results from the query? Can there be something wrong with that?
Regards Guido

1.6 LOV query invalid, was working in 1.5

The following LOV query was valid in 1.5:
select rd.name, rd.refdata_id from refdata rd, refdata_meta meta where meta.name = 'Title' and rd.refdata_meta_id = meta.refdata_meta_id and (:20_PATIENT_ID IS NOT NULL OR visible = 'Y') order by rank
This query is being flagged as invalid in 1.6. The problem appears to be the parenthetical OR clause, since taking it out passes validation. The error message is:
"LOV query is invalid, a display and a return value are needed, the column names need to be different. If your query contains an in-line query, the first FROM clause in the SQL statement must not belong to the in-line query."
Seems to me that the validator is equating the existence of a left parenthesis with an inline query, which of course is incorrect as the above perfectly valid SQL demonstrates.
The query with the OR clause operates to populate the LOVs just fine in my existing app migrated from 1.5, so this is a maintenance and new app creation issue.
I can of course work around it by views as needed to support a simplified LOV query, but I would much rather just get the former level of functionality back. Any prospect of fixing what appears to me to be a bug in the LOV query validator for the 1.6 platform?
thanks,
susan weber

Susan,
In 1.6, we introduced LOV query validations, to help head off problems before runtime. Looks like in this case, the check has a bug. It's trying to parse your SQL as if it were a query in a region and it fails because of the item name you are using that begins with a numeric digit and is followed by non-numeric characters. Such a query fails to parse with DBMS_SQL.PARSE. But the query does work, as you know, in an LOV, where EXECUTE IMMEDIATE with a USING clause handles it okay.
So we have three bugs, the LOV query validation algorithm, the misleading validation failure message, and the bug that allows users to create and use items with names that are not valid Oracle identifiers. Thanks for pointing this out.
Your workaround is to use v('20_PATIENT_ID') instead of using bind variable notation.
Scott

Using variable in from close of select statement for LOV

Hi all,
I had a select list based on a query with a variable in it for the database schema. Something like this:
"select name, id from &SCHEMA..countries order by name". This warked in version 1.4.4..., I don't remember the rest. Now we upgraded to version 1.6.0.00.87 and I am trying to change the condition for this select item but I recieve this error:
1 error has occurred
LOV query is invalid, a display and a return value are needed, the column names need to be different. If your query contains an in-line query, the first FROM clause in the SQL statement must not belong to the in-line query.
Whatever I'm trying to change for this item, it always gives me this error when I click on "Apply Changes" button. Everything works fine when I remove &SCHEMA. from the query and instead write directly the database schema name.
Can you help me?

Sabiha,
This is a case where the builder cannot parse the query at design time because there is no state for &SCHEMA. in the session. You can try this trick, change the lov query to: if htmldb_application.get_current_flow_sgid(:APP_ID) = htmldb_application.get_sgid then
return 'select name d, id r from &SCHEMA..countries order by name';
end if;Notice also the addition of aliases for the column names.
Scott

Problem in Dynamic LOV query

Hi,
I have a LOV in my page its query should be based on item condition.
So I tried using Apex provided Dynamic LOV Query with IF.. ELSE.. END IF condition.. But when I use this and run the page it is giving error "URL NOT FOUND".
My query is
   IF :MY_ITEM is not null THEN
   RETURN 'select ename ,eno
                from emp
                where eno = '''||:MY_ITEM||''' ';
   ELSE
    RETURN 'select ename ,eno
                from emp
                where ename = ''ALAKA'' ';
   END IF;But it is not working for me.
Please anyone help me to solve this.
Thanks
Alaka

Hi All,
It worked for me. Just I modified my code a bit. Thanks to all for help.
Just I did ,
   DECLARE
   BEGIN
         IF :MY_ITEM IS NOT NULL THEN
            RETURN 'SELECT ENAME,ENO
                        FROM EMP
                        WHERE ENAME = '''||:MY_ITEM||''' ';
       ELSE
           RETURN 'SELECT ENAME,ENO
                        FROM EMP
                        WHERE ENAME = ''ALAKA'' ';
      END IF;
      EXCEPTION
        WHEN OTHERS THEN
            HTP.PRN('ERROR'||SQLERRM);
   END;
Thanks
Alaka

Select list and subquery: "LOV query is invalid"

Hi all,
I want to create a select list with the following format:
"name1 (count of another table)"
"name2 (count of another table)"
I've boiled it down to a simple query with a non-correlated subquery that works fine in SQL*Plus but not as an LOV:
select table1.field1 || (select count(*) from table2) d,
table1.field2 r
from table1
I get this (Apex 3.2.1):
1 error has occurred
* LOV query is invalid, a display and a return value are needed, the column names need to be different. If your query contains an in-line query, the first FROM clause in the SQL statement must not belong to the in-line query.
Even this doesn't work:
select table1.field1 || (select 'a' from dual) d,
table1.field2 r
from table1
I've tried it with an inline view, joining table1 to a select from table2 that returns the count, but I get the same result. Any ideas?
Edited by: MalcA on Jan 22, 2010 12:14 PM

I don't know, but the difference is that the count(*) code goes from the select clause to the from clause.
Other times I had the same problem and always did it and it was the solution.

Need help how to change LOV query

Hi All,
Can some one help me how to use the LOV Query based on responsibility (I am using form personalization)
When the user logs in with XX_Payables Super user with say (Responsibility id =500) then the LOV should be
Select BA.bank_account_name,
BA.bank_account_num,
BA.bank_Account_id,
BA.currency_code bank_currency_code,
from CE_BANK_ACCOUNTS ba
but if the user logs in with any other responsibilits then the lov should be
Select BA.bank_account_name,
BA.bank_account_num,
BA.bank_Account_id,
BA.currency_code bank_currency_code,
from CE_BANK_ACCOUNTS ba
where BA.multi_currency_allowed_flag = 'Y'
step 1
I have created a built in builtin type : Create Record group from query
Arugument : Select statement
Group name : XX_Group
step 2
Property
Object type : LOV
target object : PAY_ACTIVE_BANK_ACCOUNTS
property name : Group name
value XX_GROUP
Using this method i am able to select only one query
How can i control this based on responsibility.
Appreciate if some one can help me to resolve this issue.
Regards,
Rajini

Thanks for your reply, I tried to use this query but i am getting error as FRM-41076 Error populating group and FRM-41072 Cannot create group
but if i use any one of the query or either of the query it works fine. but i dont see any issues when i run only any one of the query in argument in form personalization. Union all is returing rows in database.
SELECT BA.bank_account_name,
BA.bank_account_num,
BA.bank_Account_id,
BA.currency_code bank_currency_code,
CBAU.bank_acct_use_id ,
BA.multi_currency_allowed_flag bank_multi_currency_flag,
BA.zero_amount_allowed bank_zero_amounts_allowed,
BA.account_owner_org_id legal_entity_id,
CBB.bank_name,
CBB.bank_branch_name
FROM
CE_BANK_ACCOUNTS BA,
CE_BANK_BRANCHES_V CBB,
CE_BANK_ACCT_USES_OU_V CBAU
WHERE ((BA.multi_currency_allowed_flag = 'Y' AND
(BA.currency_code = :pay_sum_folder.functional_currency_code or
BA.currency_code = :parameter.pay_in_full_currency_code )) or
BA.currency_code = nvl( :parameter.pay_in_full_currency_code, BA.currency_code))
AND CBAU.BANK_ACCOUNT_ID = BA.BANK_ACCOUNT_ID
AND sysdate between TRUNC(CBB.start_date) and nvl(TRUNC(CBB.end_date), sysdate + 1)
AND CBB.branch_party_id = BA.bank_branch_id
AND SYSDATE < NVL(BA.END_DATE,SYSDATE+1)
AND BA.ACCOUNT_CLASSIFICATION = 'INTERNAL'
AND CBAU.ap_use_enable_flag = 'Y'
AND CBAU.org_id = :pay_sum_folder.org_id
AND NVL(BA.netting_acct_flag, 'N') <> 'Y'
AND fnd_global.resp_name = 'XX PAYABLES SUPER USER'
AND CBB.bank_name_alt = 'Head office bank'
UNION ALL
SELECT BA.bank_account_name,
BA.bank_account_num,
BA.bank_Account_id,
BA.currency_code bank_currency_code,
CBAU.bank_acct_use_id ,
BA.multi_currency_allowed_flag bank_multi_currency_flag,
BA.zero_amount_allowed bank_zero_amounts_allowed,
BA.account_owner_org_id legal_entity_id,
CBB.bank_name,
CBB.bank_branch_name
FROM
CE_BANK_ACCOUNTS BA,
CE_BANK_BRANCHES_V CBB,
CE_BANK_ACCT_USES_OU_V CBAU
WHERE ((BA.multi_currency_allowed_flag = 'Y' AND
(BA.currency_code = :pay_sum_folder.functional_currency_code or
BA.currency_code = :parameter.pay_in_full_currency_code )) or
BA.currency_code = nvl( :parameter.pay_in_full_currency_code, BA.currency_code))
AND CBAU.BANK_ACCOUNT_ID = BA.BANK_ACCOUNT_ID
AND sysdate between TRUNC(CBB.start_date) and nvl(TRUNC(CBB.end_date), sysdate + 1)
AND CBB.branch_party_id = BA.bank_branch_id
AND SYSDATE < NVL(BA.END_DATE,SYSDATE+1)
AND BA.ACCOUNT_CLASSIFICATION = 'INTERNAL'
AND CBAU.ap_use_enable_flag = 'Y'
AND CBAU.org_id = :pay_sum_folder.org_id
AND NVL(BA.netting_acct_flag, 'N') <> 'Y'
AND fnd_global.resp_name != 'XX PAYABLES SUPER USER'

Designing LOV Query Problem

Hello APEX people,
I posted my problem here:
Designing LOV Query Problem
What I have is a sequence like this:
CREATE SEQUENCE
DR_SEQ_FIRST_SCHEDULE_GROUP
MINVALUE 1 MAXVALUE 7 INCREMENT BY 1 START WITH 1
CACHE 6 ORDER CYCLE ;
What I need would be a SQL query returning all possible values oft my sequence like:
1
2
3
4
5
6
7
I want to use it as a source for a LOV...
The reason why I use the cycling sequence is: My app uses it to cycle scheduling priorities every month to groups identified by this number (1-7).
In the Admin Form, I want to restrict the assignment in a user friendly way - a LOV.
Thanks
Johann

Here ist the solution (posted by michales in the PL/SQL forum):
SQL> CREATE SEQUENCE
dr_seq_first_schedule_group
MINVALUE 1 MAXVALUE 7 INCREMENT BY 1 START WITH 1
CACHE 6 ORDER CYCLE
Sequence created.
SQL> SELECT LEVEL sn
FROM DUAL
CONNECT BY LEVEL <= (SELECT max_value
FROM user_sequences
WHERE sequence_name = 'DR_SEQ_FIRST_SCHEDULE_GROUP')
SN
1
2
3
4
5
6
7
7 rows selected.

Using a string variable as a query SQL statement

I want to construct a custom SQL statement in a string var, then use that var in the cfquery statement. What is the proper syntax? Here is my feeble attempt:
<cffunction ...>
<cfset var sql_txt="">
        <cfquery name="qSBJs" datasource="cfBAA_odbc">
            "#sql_txt#"
        </cfquery>
    <cfreturn qSBJs>
I've tried using no " or # or just # or just " but nothing works.
what about:
        <cfquery name="qSBJs" datasource="cfBAA_odbc" sql="#sql_txt#">
        </cfquery>
nope. I wish there was a sql property I could fill *before* the execution of the query. Any suggestions?

Hi Adam, and/or anyone who may have a few minutes to check this... I got the following code to work. It calls the getSBJs function from Flash Builder 4. I get the correct result set back. Long table names are replaced with short abreviations. Note that some local vars are declared but not used in the following example. I will use them in the future versions of this same code. Since I will in the future, like a donkey, mindlessly use this same method for all my queries, it would be much appreciated if I could get a guru to check this code for:
-Pure idiocy
-Mild insanity
-SQL injection vulnerability
-Memory leakage
-Scope dangers
(ignore emoticons, see the underlying text)
    <cffunction name="AbrvTblNms" output="false" returntype="string" >
        <cfargument name="txt" type="string" required="true" />
        <cfset var qAbrvs="">
        <cfset var output_str="#ARGUMENTS.txt#">
        <cfquery name="qAbrvs" datasource="cfBAA_odbc" result="rsltAbrvs">
            SELECT TBL_NM, ABRV FROM BAA_TBL_ABRV ORDER BY 1
        </cfquery>
    <cfloop query="qAbrvs">
            <cfset output_str = Replace(output_str, '[' & qAbrvs.TBL_NM & ']', qAbrvs.ABRV, "ALL")>
    </cfloop>
        <cfreturn output_str>
    </cffunction>
    
    <cffunction name="getSBJs" output="false" access="remote" returntype="any" >
        <cfargument name="srch_val" type="string" required="true" />
        <cfset var qSBJs="">
        <cfset var sql_txt="">
        <cfset var whr="">
        <cfset var b=False>
        <cfset var in_txt="">
        <cfset var fm_dt="">
        <cfset var to_dt="">
        <cfset var on_dt="">
        <cfset var pht="">
        <cfset var srch_str="">
        <cfset var srch_trm="">
        
        <cfset srch_str = "#ARGUMENTS.srch_val#">
        
        <cfif Not (Len(srch_str))>
            <cfset srch_str = "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX">
        </cfif>
        <cfset srch_trm = "#srch_str#">
        <cfset sql_txt =
            "SELECT DISTINCT
              [BAA_SBJ].SRC_SYS_NM, [BAA_SBJ].SRC_SYS_GUID, [BAA_SBJ].OBJ_GUID, [BAA_SBJ].SBJ_NM, [BAA_SBJ].SBJ_DOB, [BAA_SBJ].SBJ_ID, [BAA_SBJ].NOTE, [BAA_SBJ].CDT, [BAA_SBJ].CTM, [BAA_SBJ].CBY, [BAA_SBJ].MDT, [BAA_SBJ].MTM, [BAA_SBJ].MBY
            FROM
              BAA_SBJ [BAA_SBJ]
              LEFT JOIN BAA_SES [BAA_SES] ON [BAA_SES].PAR_GUID = [BAA_SBJ].OBJ_GUID
              LEFT JOIN BAA_IMG [BAA_IMG] ON [BAA_IMG].PAR_GUID = [BAA_SES].OBJ_GUID
            WHERE [WHERE_CLAUSE] ORDER BY [BAA_SBJ].SBJ_NM">
        <cfset whr = "([BAA_SBJ].SBJ_NM CONTAINING TRIM( rm_srch_trm1 ) OR " &
                "[BAA_SBJ].NOTE CONTAINING TRIM(:prm_srch_trm2 ) OR " &
                "[BAA_SBJ].SBJ_DOB CONTAINING TRIM(:prm_srch_trm3 ) OR " &
                "[BAA_SES].SES_TYP CONTAINING TRIM(:prm_srch_trm4 ) OR " &
                "[BAA_SES].NOTE CONTAINING TRIM(:prm_srch_trm5 ) OR " &
                "[BAA_IMG].NOTE CONTAINING TRIM(:prm_srch_trm6 ))">
        <cfset sql_txt = Replace(sql_txt,"[WHERE_CLAUSE]", "#whr#", "ALL")>
        <cfset sql_txt = AbrvTblNms(sql_txt)>
    
        <cfscript>
        queryService = new query();
        queryService.setDatasource("cfBAA_odbc");
        queryService.setName("qSBJs");
        queryService.setAttributes(sql="#sql_txt#");
        queryService.addParam(name="prm_srch_trm1", value="#srch_trm#", cfsqltype="VARCHAR");
        queryService.addParam(name="prm_srch_trm2", value="#srch_trm#", cfsqltype="VARCHAR");
        queryService.addParam(name="prm_srch_trm3", value="#srch_trm#", cfsqltype="VARCHAR");
        queryService.addParam(name="prm_srch_trm4", value="#srch_trm#", cfsqltype="VARCHAR");
        queryService.addParam(name="prm_srch_trm5", value="#srch_trm#", cfsqltype="VARCHAR");
        queryService.addParam(name="prm_srch_trm6", value="#srch_trm#", cfsqltype="VARCHAR");
        result = queryService.execute();
        qSBJs = result.getResult();
        </cfscript>
        
        <cfreturn qSBJs>
    </cffunction>
THANKS TO ADAM AND DAN FOR HELPIMG ME GET THIS FAR! Now, don't let me embarass you by doing something dum and giving you "credit", if you see me doing something dum above. Thanks!

"FROM" in a string in a LOV query

Similar Messages

Maybe you are looking for